New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 784832 link

Starred by 2 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

NetworkChangeNotifier::OnNetworkChanged() could use explanation

Project Member Reported by pauljensen@chromium.org, Nov 14 2017

Issue description

From https://chromium-review.googlesource.com/c/chromium/src/+/760242/1/components/drive/job_scheduler.cc#1150

Also, IsOffline() and GetConnectionType() being inconsistent with the connection type value here is surprising.
It'd be helpful if you could note this in the comment for NetworkChangeObserver, hopefully with diagrams which describe how the values returned by IsOffline(), GetConnectionType(), and NetworkChangeObserver will change in each step in various scenarios (e.g. the device being online/offline, the device switching from ethernet to wifi, the device switching from ethernet to wifi but suddenly being offline before being completely online, etc.).
 

Comment 1 by mmenke@chromium.org, Nov 14 2017

Cc: mmenke@chromium.org xunji...@chromium.org
In the future, few consumers will be using this API.  Perhaps we should be focusing on NetworkConntionTracker's docs instead.

Sign in to add a comment