New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 784811 link

Starred by 1 user
Status: Duplicate
Merged: issue 65244
Owner:
hnakashima@chromium.org
Closed: Dec 2017
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
mcnee@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Feature



Sign in to add a comment

PDF page gets reset from pinch to zoom action after performing navigation.

Reported by db...@etouch.net, Nov 14 2017 
Chrome Version:64.0.3268.0 Revision 2af1c4f37d23500cc3e71fe058ba4efd55ed35c6-refs/heads/master@{#516147}(32/64bit)
OS: Windows(10 Touch device)

What steps will reproduce the problem?
(1) Launch chrome, open NTP and open PDF file.(e.g https://graduateland.com/api/v2/users/jesper/cv)
(2) Perform pinch to zoom on PDF file, then back navigate and come back to PDF file.
(3) Observe.

Actual: PDF page gets reset after performing navigation.

Expected: PDF page should not reset.

This is a regression issue, broken in 'M56', below is bisect info:

Good Build: 56.0.2924.0
Bad Build: 56.0.2915.0

You are probably looking for a change made after 430972(known good), but no later than 430973(first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/0f8f9ca3d11f7f353edc54c6bf2898ebbdabd155..6e1abbfb2450eedddb1ab128be1b31cc93104e41

Suspecting: https://chromium.googlesource.com/chromium/src/+/6e1abbfb2450eedddb1ab128be1b31cc93104e41

Note: issue is not seen on Linux and Mac OS.
Actual_zoom.mp4
973 KB View Download
Expected_Zoom.mp4
402 KB View Download

Comment 1 by mcnee@chromium.org, Nov 14 2017 

Before we made the PDF viewer pinch zoom aware, pinch zooming would cause the viewer's UI to scale. Navigating away and back to a page restores the page scale factor. So what was being restored previously was the scaling of the viewer's UI.

Since we're now handling pinch zoom gestures and preventing the browser from changing the scale of the viewer, there is no scale change for the browser to restore.

The PDF viewer's pinch zoom mechanism updates the browser's zoom level in manual zoom mode. Zoom resets upon navigation for manual zoom mode.

I'm inclined to mark this as works as intended. dsinclair: Any thoughts?

Comment 2 by dsinclair@chromium.org, Nov 14 2017

Cc: mcnee@chromium.org
Labels: -Type-Bug-Regression -M-64 Type-Feature
Owner: hnakashima@chromium.org
Summary: PDF page gets reset from pinch to zoom action after performing navigation. (was: Regression: PDF page gets reset from pinch to zoom action after performing navigation.)
Sending this to hnakashima@ to triage for PE. We have an existing bug to remember scroll location on back/forward navigation. Remembering zoom should probably be included in that system.

Henrique, feel free to dup into an existing bug if one exists.

Comment 3 by hnakashima@chromium.org, Dec 11 2017

Mergedinto: 65244
Status: Duplicate (was: Assigned)
►

Sign in to add a comment