Issue metadata
Sign in to add a comment
|
Regression : Toggle Button is seen Enabled automatically without closing 'ENTER SIM PIN' Dialog box in Cellular Connection Page |
||||||||||||||||||||||
Issue descriptionChrome Version: 62.0.3202.97/9901.77.0 stable-channel Candy,Daisy and Reks OS: Chrome What steps will reproduce the problem? (1)Sign into User ->Insert Mobile Dongle and ensure it is connected (2)Now go to chrome://md-settings page -> At Internet Connection click on Cellular connection -> Navigates to Cellular connected page (3)Now Enable 'Enable SIM Card locking(require PIN to use Mobile data) option -> 'ENTER SIM PIN' Dialog box is seen -> Enter correct pin and click 'ENTER' (4)Now disable 'Enable SIM Card locking(require PIN to use Mobile data) option ->'ENTER SIM PIN' Dialog box is seen -> after few sec observe Toggle Button is seen enabled without closing Dialog box -> (Please refer Video) Expected: Toggle Button should be enabled only on closing 'ENTER SIM PIN' Dialog box Actual: Instead Toggle Button of 'Enable SIM Card locking(require PIN to use Mobile data) option is seen enabled automatically after 5-10 sec without closing'ENTER SIM PIN' Dialog box This is Regression issue as same is working fine in old settings page @stevenjb : Please confirm the issue Note : Issue is seen on latest M-64 also
,
Dec 1 2017
I can't reproduce this locally, but I can see how this might happen if Shill sends an update while the dialog is opened. It should be striaghtforward to protect against this. This does not seem like a P1, fixing in 65.
,
Dec 1 2017
Actually I can repro this on coral. Fix is straightforward and seems to work fine. Still probably not important enough to merge to 64 imho.
,
Dec 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5779f6fd1f56c818d04aabb28ba7c7b05a1d0f57 commit 5779f6fd1f56c818d04aabb28ba7c7b05a1d0f57 Author: Steven Bennetts <stevenjb@chromium.org> Date: Sat Dec 02 01:43:59 2017 Settings: Network: siminfo: Do not update toggle state with active dialog This CL: * Prevents updating the 'Enable SIM card locking' toggle while a SIM dialog is visible (e.g. when a network update arrives). * Debounces toggle state update. Bug: 784805 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I6780330af0675ca09ac61dca67e72e0a40e582bb Reviewed-on: https://chromium-review.googlesource.com/803629 Commit-Queue: Ben Chan <benchan@chromium.org> Reviewed-by: Ben Chan <benchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#521175} [modify] https://crrev.com/5779f6fd1f56c818d04aabb28ba7c7b05a1d0f57/ui/webui/resources/cr_components/chromeos/network/network_siminfo.js
,
Dec 4 2017
,
Oct 4
Checked and Issue is working fine on latest M-70 70.0.3538.41/11021.37.0 beta-channel Candy Thanks..!! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by dsunk...@chromium.org
, Nov 14 2017Components: OS>Systems>Mobile