New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 784804 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug-Regression



Sign in to add a comment

Regression : 'ENTER' button is seen enabled without entering SIM PIN at 'ENTER SIM PIN' Dialog box in Cellular Connection Page

Project Member Reported by mmanchala@chromium.org, Nov 14 2017

Issue description

Chrome Version: 62.0.3202.97/9901.77.0 stable-channel Candy,Daisy and Reks
OS: Chrome

What steps will reproduce the problem?
(1)Sign into User ->Insert Mobile Dongle and ensure it is connected
(2)Now go to chrome://md-settings page -> At Internet Connection click on Cellular connection -> Navigates to Cellular connected page
(3)Now Enable 'Enable SIM Card locking(require PIN to use Mobile data) option -> 'ENTER SIM PIN' Dialog box is seen and now observe 'ENTER' button is seen enabled without entering SIM PIN 
(4)Observe able to click on 'ENTER' button(Please refer Video)

Expected: 'ENTER' button should be enabled only after entering 4 digit PIN 
Actual: Instead 
a)'ENTER' button is seen enabled without entering SIM PIN 
b)On clicking 'ENTER' button 'Invalid PIN.Retries left' error message is seen

This is Regression issue as same is working fine in old settings page i.e. 'OK' button is enabled only after entering 4 digit SIM PIN

@stevenjb : Please confirm the behavior

Note : Issue is seen on latest M-64 also
 
Actual_EnterButton.webm
520 KB View Download
Actual_EnterButtonEnabled.jpg
178 KB View Download
Expected_DisabledButton.webm
804 KB View Download
Cc: dsunk...@chromium.org harpreet@chromium.org benchan@chromium.org
Components: OS>Systems>Mobile
Labels: -Pri-1 -M-64 M-65 Pri-3
Polish.

Cc: rpattumani@chromium.org
Status: WontFix (was: Assigned)
There are actually 4 different dialogs each with different critera. I don't think this is worth the effort.

Status: Assigned (was: WontFix)
@stevenjb :Issue is also seen in 'SIM Card is Locked' overlay i.e. 'UNLOCK' is seen enabled without entering SIM PIN and on clicking 'Invalid PIN.Retries left:3' error message is seen
and same for 'Change SIM PIN' overlay i.e. 'CHANGE' is seen enabled.(Please refer video and Screenshot)
Please confirm if these are intended change.

Reopening issue for confirmation

Thanks..!!
Labels: -M-65 M-66
I'll keep this open at least for the simpler case of pin unlock but it is not very high priority.

Labels: -M-66
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6202792062119091d345ff146f2125d709bd7de4

commit 6202792062119091d345ff146f2125d709bd7de4
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Tue Jun 12 22:33:35 2018

Settings > Network > SIM lock dialog: fix egde cases and cleanup

Bug:  814274 , 784804 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I50c412d8ff26b5c78fb48834215d0d43277996a6
Reviewed-on: https://chromium-review.googlesource.com/1091804
Reviewed-by: Ben Chan <benchan@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566609}
[modify] https://crrev.com/6202792062119091d345ff146f2125d709bd7de4/ui/webui/resources/cr_components/chromeos/network/network_siminfo.html
[modify] https://crrev.com/6202792062119091d345ff146f2125d709bd7de4/ui/webui/resources/cr_components/chromeos/network/network_siminfo.js

Status: Fixed (was: Assigned)
Owner: mmanchala@chromium.org
@ mmanchala, can you please verify this bug? 
Cc: steve...@chromium.org
Owner: ----
Checked and Issue is working fine on latest M-70 70.0.3538.41/11021.37.0 beta-channel Candy

Thanks..!!

Sign in to add a comment