Issue metadata
Sign in to add a comment
|
Regression: Browser get crash after opening pdf in 'Google Docs' from google drive
Reported by
nutan.ga...@etouch.net,
Nov 14 2017
|
||||||||||||||||||||||
Issue descriptionChrome Version: 64.0.3268.0 2af1c4f37d23500cc3e71fe058ba4efd55ed35c6-refs/heads/master@{#516147} 32/64 bits OS:Win(7,8,10), Linux(14.04 LTS) Pre-condition: Sign-in into Google drive 1. Launch chrome, and navigate to Google Drive 2. Go to Google Drive and right click on any pdf file and open with 'Google Docs' 3. Observe Actual: Browser gets crashed Expected: Browser should not not crash Crash id: Uploaded Crash Report ID 0acf723611c7ad27 (Local Crash ID: 4a036401-43d4-40d6-a537-6d3366c66e4d) This is Regression issue broken in M-64 and below is the bisect info: Good Build: 64.0.3267.0 Bad Build: 64.0.3268.0 You are probably looking for a change made after 516132 (known good), but no later than 516133 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/599b5bf5e68612a03f3af06304ae37c74ee19112..5b4a0cb6c9f73c4c27bddd6909706452cf2cd47e Suspect: https://chromium.googlesource.com/chromium/src/+/5b4a0cb6c9f73c4c27bddd6909706452cf2cd47e Note: Unable to check issue on Mac OS since build is not available
,
Nov 14 2017
,
Nov 14 2017
Stack Trace for the Crash ID provided: -------------------------------------- Thread 0 (id: 5336) CRASHED [EXCEPTION_ACCESS_VIOLATION_READ @ 0x00000000 ] MAGIC SIGNATURE THREAD Stack Quality100%Show frame trust levels 0x00007ffe59c6ee02 (chrome.dll -search_tab_helper.cc:242 ) SearchTabHelper::TitleWasSet(content::NavigationEntry *) 0x00007ffe57b2b939 (chrome.dll -web_contents_impl.cc:4413 ) content::WebContentsImpl::UpdateTitleForEntry(content::NavigationEntry *,std::basic_string<wchar_t,std::char_traits<wchar_t>,std::allocator<wchar_t> > const &) 0x00007ffe58179679 (chrome.dll -ipc_message_templates.h:145 ) IPC::MessageT<FrameHostMsg_UpdateTitle_Meta,std::tuple<std::basic_string<wchar_t,std::char_traits<wchar_t>,std::allocator<wchar_t> >,blink::WebTextDirection>,void>::Dispatch<content::RenderFrameHostImpl,content::RenderFrameHostImpl,void,void (content::RenderFrameHostImpl::*)(const std::basic_string<wchar_t,std::char_traits<wchar_t>,std::allocator<wchar_t> > &, blink::WebTextDirection)> 0x00007ffe57cacab4 (chrome.dll -render_frame_host_impl.cc:904 ) content::RenderFrameHostImpl::OnMessageReceived(IPC::Message const &) 0x00007ffe57cabafc (chrome.dll -render_process_host_impl.cc:2909 ) content::RenderProcessHostImpl::OnMessageReceived(IPC::Message const &) 0x00007ffe57cab9be (chrome.dll -ipc_channel_proxy.cc:321 ) IPC::ChannelProxy::Context::OnDispatchMessage(IPC::Message const &) 0x00007ffe5789c7e6 (chrome.dll -task_annotator.cc:55 ) base::debug::TaskAnnotator::RunTask(char const *,base::PendingTask *) 0x00007ffe5789c2db (chrome.dll -message_loop.cc:394 ) base::MessageLoop::RunTask(base::PendingTask *) 0x00007ffe5789c056 (chrome.dll -message_loop.cc:457 ) base::MessageLoop::DoWork() 0x00007ffe57953a9c (chrome.dll -message_pump_win.cc:173 ) base::MessagePumpForUI::DoRunLoop() 0x00007ffe578a8d24 (chrome.dll -message_pump_win.cc:56 ) base::MessagePumpWin::Run(base::MessagePump::Delegate *) 0x00007ffe5789bba3 (chrome.dll -run_loop.cc:114 ) base::RunLoop::Run() 0x00007ffe57b6e2e5 (chrome.dll -chrome_browser_main.cc:1923 ) ChromeBrowserMainParts::MainMessageLoopRun(int *) 0x00007ffe57b6e0dc (chrome.dll -browser_main_loop.cc:1206 ) content::BrowserMainLoop::RunMainMessageLoopParts() 0x00007ffe57b6e08a (chrome.dll -browser_main_runner.cc:140 ) content::BrowserMainRunnerImpl::Run() 0x00007ffe57895d0a (chrome.dll -browser_main.cc:46 ) content::BrowserMain(content::MainFunctionParams const &) 0x00007ffe57895b52 (chrome.dll -content_main_runner.cc:427 ) content::RunNamedProcessTypeMain(std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &,content::MainFunctionParams const &,content::ContentMainDelegate *) 0x00007ffe57893809 (chrome.dll -content_main_runner.cc:705 ) content::ContentMainRunnerImpl::Run() 0x00007ffe57884eaf (chrome.dll -main.cc:456 ) service_manager::Main(service_manager::MainParams const &) 0x00007ffe57884a45 (chrome.dll -content_main.cc:19 ) content::ContentMain(content::ContentMainParams const &) 0x00007ffe57882320 (chrome.dll -chrome_main.cc:125 ) ChromeMain 0x00007ff6b00b3489 (chrome.exe -main_dll_loader_win.cc:199 ) MainDllLoader::Launch(HINSTANCE__ *,base::TimeTicks) 0x00007ff6b00b169c (chrome.exe -chrome_exe_main_win.cc:230 ) wWinMain 0x00007ff6b018b7c2 (chrome.exe -exe_common.inl:283 ) __scrt_common_main_seh 0x00007ffe854b2773 (KERNEL32.DLL + 0x00012773 ) BaseThreadInitThunk 0x00007ffe86330d50 (ntdll.dll + 0x00070d50 ) RtlUserThreadStart Adding Release Blocker for this issue. Please undo if not the case. Thank You!
,
Nov 14 2017
#1 Browser crash in latest canary -64.0.3268.0 197 reports from 214 unique clients. Please fix/revert ASAP. Link to the builds which introduced the crash ============================================= https://crash.corp.google.com/browse?q=custom_data.ChromeCrashProto.ptype%3D%27browser%27%20AND%20custom_data.ChromeCrashProto.magic_signature_1.name%3D%27SearchTabHelper%3A%3ATitleWasSet%27&sql_dialect=dremelsql&ignore_case=false&enable_rewrite=true&omit_field_name=&omit_field_value=&omit_field_opt=%3D#-property-selector,-samplereports,+productversion
,
Nov 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a2ca5b14e8c61fe2f8bbe06ab758dc7e4bf35e05 commit a2ca5b14e8c61fe2f8bbe06ab758dc7e4bf35e05 Author: Avi Drissman <avi@chromium.org> Date: Tue Nov 14 21:10:47 2017 Don't crash if WebContentsObserver::TitleWasSet has no entry. BUG= 784798 , 96041 TEST=as in bug TBR=treib@chromium.org Change-Id: If085f26539fbdaef649536bb13aa77b20297ca33 Reviewed-on: https://chromium-review.googlesource.com/769336 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#516425} [modify] https://crrev.com/a2ca5b14e8c61fe2f8bbe06ab758dc7e4bf35e05/chrome/browser/ui/search/search_tab_helper.cc [modify] https://crrev.com/a2ca5b14e8c61fe2f8bbe06ab758dc7e4bf35e05/content/public/browser/web_contents_observer.h
,
Nov 14 2017
That should fix it.
,
Nov 15 2017
Update : Also tested the above issue on Win(7,8,10), Linux(14.04 LTS) using Canary #64.0.3269.0 and issue is fixed. Kindly review an attached video. Thank you!
,
Nov 15 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by nutan.ga...@etouch.net
, Nov 14 2017Status: Assigned (was: Unconfirmed)