Incorrect position of list marker below a float
Reported by
kwk...@vivliostyle.com,
Nov 14 2017
|
||||||||||||||||||
Issue description
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.94 Safari/537.36
Steps to reproduce the problem:
1. Open the attached test case
What is the expected behavior?
The list marker should be on the left side of the list content ("a")
What went wrong?
The list marker is far right to the list content.
A weird point is that the problem exists just after loading the HTML file, but it disappears when the window size is changed.
(In the screencasts the Chrome versions are 60.0.3112.78 and 62.0.3173.0, but exactly the same behavior is reproduced on 62.0.3202.94 and 64.0.3265.0)
Did this work before? No
Does this work in other browsers? Yes
Chrome version: 62.0.3202.94 Channel: stable
OS Version: OS X 10.12.6
Flash Version:
This issue is the same as I reported in comments #10 and #12 of another issue 726583 :
https://bugs.chromium.org/p/chromium/issues/detail?id=726583#c10
https://bugs.chromium.org/p/chromium/issues/detail?id=726583#c12
,
Nov 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6bbbf5324e65d016636f23489691b87e7c753c13 commit 6bbbf5324e65d016636f23489691b87e7c753c13 Author: Robert Hogan <robhogan@gmail.com> Date: Thu Nov 30 21:18:17 2017 Place list markers correctly when the line has shifted to avoid floats Bug: 784793 Change-Id: Ib41a9a940acddf8737c261c3d14b39bf683aece4 Reviewed-on: https://chromium-review.googlesource.com/789930 Commit-Queue: Robert Hogan <robhogan@gmail.com> Reviewed-by: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#520689} [add] https://crrev.com/6bbbf5324e65d016636f23489691b87e7c753c13/third_party/WebKit/LayoutTests/fast/lists/list-marker-avoid-float-5-expected.html [add] https://crrev.com/6bbbf5324e65d016636f23489691b87e7c753c13/third_party/WebKit/LayoutTests/fast/lists/list-marker-avoid-float-5.html [add] https://crrev.com/6bbbf5324e65d016636f23489691b87e7c753c13/third_party/WebKit/LayoutTests/fast/lists/list-marker-avoid-float-6-expected.html [add] https://crrev.com/6bbbf5324e65d016636f23489691b87e7c753c13/third_party/WebKit/LayoutTests/fast/lists/list-marker-avoid-float-6.html [modify] https://crrev.com/6bbbf5324e65d016636f23489691b87e7c753c13/third_party/WebKit/Source/core/layout/LayoutListItem.cpp
,
Dec 2 2017
,
Dec 2 2017
This bug requires manual review: We are only 2 days from stable. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 2 2017
We already cut M63 Stable RC, this is P2 and regressed in M62. So I'm not planning to take it in for M63. +eae@, please let me know if there is any concern here. Thank you.
,
Dec 4 2017
Do we have any reports of this affecting real-world websites? If so we likely need to merge it into M63.
,
Dec 4 2017
+abdulsyed@,manoranjanr@ & pbommana@, Do we have any reports of this affecting real-world websites on M62 and M63?
,
Dec 4 2017
Based on bug reporter comments from issue#726583 #c21 and quick search I can't find any related issues in our crbug, so not sure if there are any real-world websites which are impacted. If possible can someone please let us know how common is this implementation in order inorder to consider the CL merge to M63.
,
Dec 4 2017
I am not sure if this issue is regarded as common generally, but it appears as a common pattern in production in our web application doing special layout on browser (and our product which produces PDF using the app and Chromium). One such example is the one below: http://vivliostyle.github.io/vivliostyle.js/viewer/vivliostyle-viewer.html#x=../samples/scholarly/index.html (This page is linked from our web site: http://vivliostyle.com/en/samples/) You can try changing window size and see this issue when a list item comes below a figure, a table or a code block.
,
Dec 4 2017
Verified that the issue is fixed on latest Chrome canary on Mac i.e., 65.0.3284.0,based on the steps provided in bug report.
,
Dec 4 2017
Thank you!
,
Dec 4 2017
Rejecting merge to M63 branch 3239 per offline chat with eae@.
,
Dec 5 2017
Thank you for working on this. The issue seems to be fixed on Canary (65.0.3284.0) for the original test case I attached, but I found another case where the very similar issue occurs. I attached a reduced test case (list-marker-float3.html). This test case uses STIX fonts (STIXGeneral) bundled with macOS Sierra (10.12.6). This is derived from our real example in production. For this time, the issue persists after changing window size. If it is preferred to file a new bug, I am willing to do so.
,
Dec 6 2017
,
Dec 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8819ce57fd3cc5506c3a386bf08949d54094c190 commit 8819ce57fd3cc5506c3a386bf08949d54094c190 Author: Robert Hogan <robhogan@gmail.com> Date: Fri Dec 29 13:07:44 2017 Place list markers correctly when floats are present Bug: 784793 Change-Id: If176229f0af62fb61a40a7e4ef119057fe05449c Reviewed-on: https://chromium-review.googlesource.com/844084 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#526370} [add] https://crrev.com/8819ce57fd3cc5506c3a386bf08949d54094c190/third_party/WebKit/LayoutTests/fast/lists/list-marker-avoid-float-7-expected.html [add] https://crrev.com/8819ce57fd3cc5506c3a386bf08949d54094c190/third_party/WebKit/LayoutTests/fast/lists/list-marker-avoid-float-7.html [modify] https://crrev.com/8819ce57fd3cc5506c3a386bf08949d54094c190/third_party/WebKit/Source/core/layout/LayoutBlockFlow.h [modify] https://crrev.com/8819ce57fd3cc5506c3a386bf08949d54094c190/third_party/WebKit/Source/core/layout/LayoutListItem.cpp [modify] https://crrev.com/8819ce57fd3cc5506c3a386bf08949d54094c190/third_party/WebKit/Source/core/layout/LayoutListItem.h
,
Jan 9 2018
I appreciate your work on this very much. I tested the two test cases (list-marker-float2.html, list-marker-float3.html) on Canary (65.0.3315.0) and Dev (65.0.3311.3). For both of the test cases and both of the versions, I observed the same behavior: the bullet was on the right side just after opening the file, but it moved to the correct position when resizing the window.
,
Jan 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8266c1681920886fdab67399b11da2d1cb0e285c commit 8266c1681920886fdab67399b11da2d1cb0e285c Author: Robert Hogan <robhogan@gmail.com> Date: Tue Jan 09 21:01:06 2018 Revert "Place list markers correctly when floats are present" This reverts commit 8819ce57fd3cc5506c3a386bf08949d54094c190. Reason for revert: crbug.com/800025 Original change's description: > Place list markers correctly when floats are present > > Bug: 784793 > Change-Id: If176229f0af62fb61a40a7e4ef119057fe05449c > Reviewed-on: https://chromium-review.googlesource.com/844084 > Commit-Queue: Emil A Eklund <eae@chromium.org> > Reviewed-by: Emil A Eklund <eae@chromium.org> > Cr-Commit-Position: refs/heads/master@{#526370} TBR=robhogan@gmail.com,eae@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 784793, 800025 Change-Id: I420a7b86bc80937d8c1420e5f45548e105ee48e0 Reviewed-on: https://chromium-review.googlesource.com/857996 Reviewed-by: Robert Hogan <robhogan@gmail.com> Commit-Queue: Robert Hogan <robhogan@gmail.com> Cr-Commit-Position: refs/heads/master@{#528100} [delete] https://crrev.com/164f122a9b2ee9d10bc3c155e943aad85e2e0a7f/third_party/WebKit/LayoutTests/fast/lists/list-marker-avoid-float-7-expected.html [delete] https://crrev.com/164f122a9b2ee9d10bc3c155e943aad85e2e0a7f/third_party/WebKit/LayoutTests/fast/lists/list-marker-avoid-float-7.html [modify] https://crrev.com/8266c1681920886fdab67399b11da2d1cb0e285c/third_party/WebKit/Source/core/layout/LayoutBlockFlow.h [modify] https://crrev.com/8266c1681920886fdab67399b11da2d1cb0e285c/third_party/WebKit/Source/core/layout/LayoutListItem.cpp [modify] https://crrev.com/8266c1681920886fdab67399b11da2d1cb0e285c/third_party/WebKit/Source/core/layout/LayoutListItem.h
,
Jan 10 2018
Verified this issue on Mac OS 10.12.6 using chrome latest canary M65 #65.0.3317.0. By opening the test case provided in comment #2 observed the list marker is displayed left side of the list content ("a") as expected. Hence adding TE-Verified label for M65.
Thanks!
,
Jan 10 2018
> Verified this issue on Mac OS 10.12.6 using chrome latest canary M65 #65.0.3317.0. The first test case (list-marker-float2.html) and the test case in comment #2 (784793.html) indeed work, while the second test case I provided in comment #14 (list-marker-float3.html) still does not work. It seems that the situation has not changed since comment #14. As I said in the comment #14, if it is preferred to file a new bug for it, I am willing to do so. |
||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||
Comment 1 by robho...@gmail.com
, Nov 14 2017Status: Assigned (was: Unconfirmed)