New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 784776 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: I-Beam pointer is seen instead of arrow pointer on right click context menu options.

Reported by pranjali...@etouch.net, Nov 14 2017

Issue description

Chrome Version: 64.0.3265.0 (Official Build)630842eac3832f11f04f626774943de31b1ce35arefs /heads/master@{#515780}(64-bit)

OS:Mac(10.12.6)

URL:https://www.facebook.com/ 

Steps to reproduce:
1. Launch Chrome and navigate to above URL.
2. Type text in ‘create an account’ form,then right click in text box and select 'Undo' option and again right click in text box and     select ‘Redo' option.
3. Observe context menu.

Actual Result: I-Beam pointer is seen instead of arrow pointer on right click context menu options.
Expected Result:Arrow pointer should be seen on right click context menu options..

This is regression issue broken in ‘M-62’ and below per-revision bisect result

Using the per-revision bisect providing the bisect results,
Good Build: 62.0.3168.0
Bad Build:62.0.3169.0

You are probably looking for a change made after 490118 (known good), but no later than 490119 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.
  

https://chromium.googlesource.com/chromium/src/+log/f318f9140dfc09749c3f844011e7d1649687210f..c998cf3857d76d0773b330adb2d9098453c53050

Suspect:https://chromium.googlesource.com/chromium/src/+/c998cf3857d76d0773b330adb2d9098453c53050

@jsbell: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thank You!


 
Actual_result.mov
4.2 MB Download
Expected_result.mov
3.9 MB Download

Comment 1 by bokan@chromium.org, Nov 15 2017

Components: -Blink Blink>Input
I can repro in 64.0.3269.0 and not in 62.0.3202.94 but the suspected patch is unlikely to make a difference since it only has test related changes. jsbell@ could you confirm? Perhaps we need another try at a bisect

Comment 2 by jsb...@chromium.org, Nov 16 2017

Labels: -hasbisect-per-revision Needs-Bisect
Yeah, couldn't possibly be the suspect change.
Labels: -Needs-Bisect hasbisect-per-revision
w.r.t comment2 :

Rebisected for the above issue and getting same suspect i.e


Suspect:https://chromium.googlesource.com/chromium/src/+/c998cf3857d76d0773b330adb2d9098453c53050

@jsbell:Please help me reassign this issue if your change is not cause for it.

Comment 4 by jsb...@chromium.org, Nov 20 2017

Cc: jongkwon...@navercorp.com
Owner: pranjali...@etouch.net
There was a nearby Mac-only change to cursor logic:

https://chromium.googlesource.com/chromium/src/+/ecfc59c0dcd79727c03fd8e835036cd7a8ad8e99

It's revision 489866 which is within the good/bad revision build range:

https://chromium.googlesource.com/chromium/src/+log/62.0.3168.0..62.0.3169.0?pretty=fuller&n=10000

I think my patch(revision 489866) could cause the problem. I'll take a look.
Owner: a...@chromium.org
Thanks for the update! As per comment#4 & 5 assigning to patch(revision 489866) reviewer.

Project Member

Comment 7 by bugdroid1@chromium.org, Nov 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/679120f758e488cd002bbeff737e3a8828f16737

commit 679120f758e488cd002bbeff737e3a8828f16737
Author: jongkwon.lee <jongkwon.lee@navercorp.com>
Date: Wed Nov 22 06:49:43 2017

Do not set cursor when context menu is showing

Because updateCursor: can be called with delay, do not set cursor
when context menu is showing. It's a matter of timing and any other
Native Views or Native Windows such as Dialogs could be ignored
because they will be shown with enough delay.

Bug:  784776 
Change-Id: Ia7d0bd05757d93f8c3883509059b73a03a0b3ef7
Reviewed-on: https://chromium-review.googlesource.com/783973
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518554}
[modify] https://crrev.com/679120f758e488cd002bbeff737e3a8828f16737/content/browser/renderer_host/render_widget_host_view_mac.mm

Labels: TE-Verified-64.0.3276.0 TE-Verified-M64.
Note:
Retested the above issue on latest Canary #64.0.3276.0 for Mac(10.12.6). Fix is working as intended.
Please refer the attached screen-cast.
Result.mov
6.7 MB Download
Status: Fixed (was: Assigned)
Tagging as fixed.

Sign in to add a comment