New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 784761 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 2
Type: Bug-Security
Team-Security-UX



Sign in to add a comment

U+0D1F and U+0D2F can be used to spoof 'so.com'

Project Member Reported by js...@chromium.org, Nov 14 2017

Issue description

Spun off from  bug 756866  comment 12 (reported by xisigr@gmail.com )


> Real site:  https://www.so.com
> spoof site:  https://www.ടഠ.com/

This has to be dealt with in a separate bug. There's no script mixing. U+0D1F and U+0D20 look like Latin 's' and 'o', respectively.   Unicode util web site is down at the moment and I haven't checked if U+0D1F and U+0D20 are considered confusable with 's' and 'o' (I guess they're). If they're and 'so.com' is in the top domain list, it'd be blocked. 

 

Comment 1 by js...@chromium.org, Nov 14 2017

Blockedon: 722022

Comment 2 by mmoroz@chromium.org, Nov 14 2017

Labels: Security_Impact-Stable Security_Severity-Low M-62

Comment 3 by js...@chromium.org, Nov 14 2017

U+0D20 is in the list of confusables for Latin 'o', but U+0D1F (ട ) is not for Latin 's'. 

'so.com' and 'soso.com' are in our top 10k list. 

So, for this particular case, a fix would be to add U+0D1F to the list of confusables for Latin 's'. 

Project Member

Comment 4 by sheriffbot@chromium.org, Nov 15 2017

Labels: -Pri-3 Pri-2

Comment 5 by js...@chromium.org, Dec 3 2017

Blockedon: -722022
Status: Started (was: Assigned)
so.com is already in the top 10k list. So, it's not blocked by 722022. 
This issue is being fixed by a CL under review. 

Comment 7 by js...@chromium.org, Dec 4 2017

Labels: -M-62 M-63
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b3f0207c14fccc11aaa9d4975ebe46554ad289cb

commit b3f0207c14fccc11aaa9d4975ebe46554ad289cb
Author: Jungshik Shin <jshin@chromium.org>
Date: Tue Dec 05 09:35:25 2017

Add a few more confusable map entries

1. Map Malaylam U+0D1F to 's'.
2. Map 'small-cap-like' Cyrillic letters to "look-alike" Latin lowercase
letters.

The characters in new confusable map entries are replaced by their Latin
"look-alike" characters before the skeleton is calculated to compare with
top domain names.

Bug:  784761 , 773930 
Test: components_unittests --gtest_filter=*IDNToUni*
Change-Id: Ib26664e21ac5eb290e4a2993b01cbf0edaade0ee
Reviewed-on: https://chromium-review.googlesource.com/805214
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Jungshik Shin <jshin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521648}
[modify] https://crrev.com/b3f0207c14fccc11aaa9d4975ebe46554ad289cb/components/url_formatter/idn_spoof_checker.cc
[modify] https://crrev.com/b3f0207c14fccc11aaa9d4975ebe46554ad289cb/components/url_formatter/idn_spoof_checker.h
[modify] https://crrev.com/b3f0207c14fccc11aaa9d4975ebe46554ad289cb/components/url_formatter/top_domains/alexa_domains.list
[modify] https://crrev.com/b3f0207c14fccc11aaa9d4975ebe46554ad289cb/components/url_formatter/top_domains/alexa_skeletons.gperf
[modify] https://crrev.com/b3f0207c14fccc11aaa9d4975ebe46554ad289cb/components/url_formatter/top_domains/make_alexa_top_list.py
[modify] https://crrev.com/b3f0207c14fccc11aaa9d4975ebe46554ad289cb/components/url_formatter/url_formatter_unittest.cc

Labels: OS-Android OS-Chrome OS-iOS OS-Linux OS-Mac OS-Windows
Status: Fixed (was: Started)
will bake in canary/dev channel for a while before asking for merge to 63 branch.
Project Member

Comment 11 by sheriffbot@chromium.org, Dec 6 2017

Labels: Restrict-View-SecurityNotify

Comment 12 by xis...@gmail.com, Dec 8 2017

I had independent submitted this bug in  issue 759995 . This bug is a perfect clone of so.com, is this SecSeverity-Low?
Labels: M-64 Merge-Request-64
Asking for merge to 64 branch. 

The CL recorded in comment 8 is simple and safe. It has been baked in 65.x for a month.  

Project Member

Comment 14 by sheriffbot@chromium.org, Jan 3 2018

Labels: -Merge-Request-64 Hotlist-Merge-Review Merge-Review-64
This bug requires manual review: Less than 16 days to go before AppStore submit on M64
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
> The CL recorded in comment 8 is simple and safe. It has been baked in 65.x for a month.  


In addition to this bug, the cl also fixed  bug 773930  (also slated for M64). 

Labels: -Merge-Review-64 Merge-Approved-64
Approving merge to M64. Branch:3282
Project Member

Comment 17 by bugdroid1@chromium.org, Jan 5 2018

Labels: -merge-approved-64 merge-merged-3282
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/908ed3e510e06341b8e9143c5e5cea94dad30e30

commit 908ed3e510e06341b8e9143c5e5cea94dad30e30
Author: Jungshik Shin <jshin@chromium.org>
Date: Fri Jan 05 19:46:54 2018

[M64 branch] Add a few more confusable map entries

1. Map Malaylam U+0D1F to 's'.
2. Map 'small-cap-like' Cyrillic letters to "look-alike" Latin lowercase
letters.

The characters in new confusable map entries are replaced by their Latin
"look-alike" characters before the skeleton is calculated to compare with
top domain names.

TBR=jshin@chromium.org

(cherry picked from commit b3f0207c14fccc11aaa9d4975ebe46554ad289cb)

Bug:  784761 , 773930 
Test: components_unittests --gtest_filter=*IDNToUni*
Change-Id: Ib26664e21ac5eb290e4a2993b01cbf0edaade0ee
Reviewed-on: https://chromium-review.googlesource.com/805214
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Jungshik Shin <jshin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#521648}
Reviewed-on: https://chromium-review.googlesource.com/852973
Reviewed-by: Jungshik Shin <jshin@chromium.org>
Cr-Commit-Position: refs/branch-heads/3282@{#421}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
[modify] https://crrev.com/908ed3e510e06341b8e9143c5e5cea94dad30e30/components/url_formatter/idn_spoof_checker.cc
[modify] https://crrev.com/908ed3e510e06341b8e9143c5e5cea94dad30e30/components/url_formatter/idn_spoof_checker.h
[modify] https://crrev.com/908ed3e510e06341b8e9143c5e5cea94dad30e30/components/url_formatter/top_domains/alexa_domains.list
[modify] https://crrev.com/908ed3e510e06341b8e9143c5e5cea94dad30e30/components/url_formatter/top_domains/alexa_skeletons.gperf
[modify] https://crrev.com/908ed3e510e06341b8e9143c5e5cea94dad30e30/components/url_formatter/top_domains/make_alexa_top_list.py
[modify] https://crrev.com/908ed3e510e06341b8e9143c5e5cea94dad30e30/components/url_formatter/url_formatter_unittest.cc

Labels: Release-0-M64

Comment 19 by xis...@gmail.com, Jan 25 2018

This bug may assigned a CVE ID ?
Project Member

Comment 20 by sheriffbot@chromium.org, Mar 14 2018

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 21 by sheriffbot@chromium.org, Mar 27 2018

Labels: -M-63 -M-64 M-65

Comment 22 by xis...@gmail.com, Apr 12 2018

I noticed the issue I reported have been fixed for long time. Has it been assigned CVE number for me? Would anybody give me an explanation?
Labels: CVE_description-missing CVE-2018-6119
Labels: -CVE_description-missing CVE_description-submitted
Labels: idn-spoof

Sign in to add a comment