New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 784754 link

Starred by 1 user
Status: Fixed
Owner:
pbos@chromium.org
Closed: Dec 2017
Cc:
bsep@chromium.org
nyerramilli@chromium.org
kylixrd@chromium.org
rbasuvula@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Extra padding is observed from Right Hand Side for 'Remove Icon'in save password bubble.

Reported by shruti.j...@etouch.net, Nov 14 2017 
Chrome Version:64.0.3267.0 ea1e6ed62ee1a0d8b790238a5ff54ca90a66497c-refs/heads/master@{#515867}

OS: Win(7,8,10), Mac(10.12.6) and Linux(14.04 LTS).

Pre-Condition:Log-in with valid credentials and  Enable "Material Design in the rest of the browser's native UI" flag.

Steps to reproduce:
1.Launch chrome and Navigate to gmail.com.
2.Login with valid credentials and click on save password bubble. 
3.Observe 'Remove icon' in  save password bubble. 


Actual Result:  Extra padding is observed from Right Hand Side for 'Remove Icon'.
Expected Result:Padding should be proper from Right Hand Side for 'Remove Icon'.

This is regression issue broken in ‘M-64’ and below per-revision bisect result

Using the per-revision bisect providing the bisect results,
Good Build: 64.0.3264.0(Revision: 515410).
Bad Build: 64.0.3265.0(Revision:515780).

You are probably looking for a change made after 515558 (known good), but no lat
er than 515559 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds migh
t get missing due to failure.
  https://chromium.googlesource.com/chromium/src/+log/458bfb8222dbc1330a492eba26
be712d8face5db..98d6ac3cb23b5b06afa97b71a0f34e80c1060a24



Suspect: https://chromium.googlesource.com/chromium/src/+/98d6ac3cb23b5b06afa97b71a0f34e80c1060a24

@kylixrd: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thank You!
expected.mp4
706 KB View Download
actual.mp4
888 KB View Download
actual.png
226 KB View Download
expected.png
224 KB View Download

Comment 1 by kylixrd@chromium.org, Dec 4 2017

Cc: kylixrd@chromium.org
Owner: pbos@chromium.org
Moved to pbos@. Currently working on many changes/updates to the manage passwords dialogs/bubbles.
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ebe803acafc7cc3bd273c529edbba8f45b37b445

commit ebe803acafc7cc3bd273c529edbba8f45b37b445
Author: Peter Boström <pbos@chromium.org>
Date: Wed Dec 13 00:48:04 2017

Separate the manage-passwords dialog.

Splits up some globals and makes this a stand-alone dialog instead of a
child view to a catch-all password dialog. Uses a 6:4 ratio for
username/password rows. These ratios are always fixed and will not vary
based on content. This keeps the look consistent as the contents inside
the dialog changes.

Also fixes regression where additional padding is observed on the
right-hand side of the manage-passwords dialog.

TBR=vasilii@chromium.org

Bug:  chromium:654115 ,  chromium:784754 
Change-Id: Ic3bc8cee08be90e0f4973fb6752eae355ecd0bb1
Reviewed-on: https://chromium-review.googlesource.com/724126
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523626}
[modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/app/generated_resources.grd
[modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/cocoa/passwords/manage_passwords_view_controller.mm
[modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/cocoa/tab_dialogs_views_mac.mm
[modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc
[modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/passwords/manage_passwords_bubble_model.h
[modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc
[modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/passwords/manage_passwords_test.cc
[modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/passwords/manage_passwords_test.h
[modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/passwords/manage_passwords_view_utils.h
[modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc
[modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/views/extensions/extension_uninstall_dialog_view.cc
[modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/views/extensions/pwa_confirmation_view.cc
[modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/views/harmony/chrome_layout_provider.cc
[modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/views/harmony/chrome_layout_provider.h
[modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/views/harmony/harmony_layout_provider.cc
[modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/views/importer/import_lock_dialog_view.cc
[modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc
[modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.h
[modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/views/passwords/manage_password_items_view.cc
[modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/views/passwords/manage_password_items_view.h
[add] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/views/passwords/manage_passwords_bubble_delegate_view_base.cc
[add] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/views/passwords/manage_passwords_bubble_delegate_view_base.h
[modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
[modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h
[modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_interactive_uitest.cc
[modify] https://crrev.com/ebe803acafc7cc3bd273c529edbba8f45b37b445/chrome/browser/ui/views/tab_dialogs_views.cc

Comment 3 by pbos@chromium.org, Dec 13 2017

Cc: bsep@chromium.org
Status: Fixed (was: Assigned)
This should be fixed now. bsep@ given that we're not shipping Harmony with M64, are we good with this as is? See crrev.com/98d6ac3cb23b5b06afa97b71a0f34e80c1060a24 for reference as it caused the regression.

Comment 4 by bsep@chromium.org, Dec 13 2017

Labels: -M-64 M-65
Yes. This isn't shipping until M65, so we don't need a merge or anything.
►

Sign in to add a comment