untracked file Tools/Scripts/audit-non-blink-usagec created |
||||
Issue descriptionI suspect that's the cached compiled python code for Tools/Scripts/audit-non-blink-usage other scripts in that dir don't created cached code
,
Nov 14 2017
,
Nov 17 2017
It looks like Morten added this to a .gitignore in r516643. I think it would be nicer if this file ended in .py, so that the *.pyc in src/.gitignore would catch it (and so that it would be more obvious what it is). But I'll leave that up to dcheng.
,
Nov 17 2017
I agree, and that was what I suggested in the review =) I'll rename to py and undo the .gitignore change.
,
Nov 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/02bad72f88ba3f356af8fd150ace6b70966ce1cb commit 02bad72f88ba3f356af8fd150ace6b70966ce1cb Author: Daniel Cheng <dcheng@chromium.org> Date: Fri Nov 17 07:35:38 2017 Add .py suffix to audit-non-blink-usage Python likes to cache the bytecode for imported modules in pyc files. These files should be ignored by git. Since audit-non-blink-usage didn't end in py, this created bytecode files that showed up as noise in git status. TBR=qyearsley@chromium.org Bug: 784738 Change-Id: I613bd3fdb6bfa4b2f8e4bea3ebfdc3cadef355d6 Reviewed-on: https://chromium-review.googlesource.com/776414 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#517336} [modify] https://crrev.com/02bad72f88ba3f356af8fd150ace6b70966ce1cb/third_party/WebKit/PRESUBMIT.py [delete] https://crrev.com/f3946268c07321bc7f6c5cc06f399b2311e9ae04/third_party/WebKit/Tools/.gitignore [modify] https://crrev.com/02bad72f88ba3f356af8fd150ace6b70966ce1cb/third_party/WebKit/Tools/Scripts/OWNERS [rename] https://crrev.com/02bad72f88ba3f356af8fd150ace6b70966ce1cb/third_party/WebKit/Tools/Scripts/audit-non-blink-usage.py
,
Nov 17 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by eseckler@chromium.org
, Nov 14 2017