The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fdcd9ef404584870d9d8d0429a74f958b2d2f3ec

commit fdcd9ef404584870d9d8d0429a74f958b2d2f3ec
Author: Eugene But <eugenebut@chromium.org>
Date: Wed Nov 15 16:08:48 2017

Deprecated base::test::ios functions because they DCHECK.

TimeUntilCondition and 2 WaitUntilCondition functions DCHECK on timeout.
DCHECKing brings down the whole test suite by crashing the test harness.
testing::WaitUntilConditionOrTimeout() should be used instead.

|DEPRECATED - Do not use in new code. http://crbug.com/784735| comment
is supposed to trigger a deprecated warning in presubmit.

TBR=rohitrao@chromium.org

Bug: 784735
Change-Id: I337b33067a1de0ed59fdad085301aeec1f12cf02
Reviewed-on: https://chromium-review.googlesource.com/768429
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516709}
[modify] https://crrev.com/fdcd9ef404584870d9d8d0429a74f958b2d2f3ec/base/test/ios/wait_util.h

I will do this for //ios/chrome/browser/passwords and //ios/chrome/browser/ui/settings.

CL for #4 is at https://crrev.com/c/774266

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd1103852dbb5b2a724d8ed18e3440ee10279972

commit dd1103852dbb5b2a724d8ed18e3440ee10279972
Author: Vaclav Brozek <vabr@chromium.org>
Date: Fri Nov 17 11:15:43 2017

testing::WaitUntilConditionOrTimeout in iOS settings and passwords

base::test::ios waiting helpers are deprecated and should be replaced
with testing::WaitUntilConditionOrTimeout, which does not bring the
whole test down with a DCHECK on failure.

This CL migrates the tests in
//ios/chrome/browser/{ui/settings|passwords} directories.

It also adds a new waiting constant kWaitForActionTimeout (10
seconds), which is based on TestTimeouts::action_timeout() (currently
10 seconds). The latter was used as the default argument for the
base::test::ios helpers which did not specify another timeout.

Bug: 784735
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I84a528127eb061baefff799f6e467b72d6b1465a
Reviewed-on: https://chromium-review.googlesource.com/774266
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517376}
[modify] https://crrev.com/dd1103852dbb5b2a724d8ed18e3440ee10279972/ios/chrome/browser/passwords/BUILD.gn
[modify] https://crrev.com/dd1103852dbb5b2a724d8ed18e3440ee10279972/ios/chrome/browser/passwords/password_controller_unittest.mm
[modify] https://crrev.com/dd1103852dbb5b2a724d8ed18e3440ee10279972/ios/chrome/browser/ui/settings/BUILD.gn
[modify] https://crrev.com/dd1103852dbb5b2a724d8ed18e3440ee10279972/ios/chrome/browser/ui/settings/autofill_collection_view_controller_unittest.mm
[modify] https://crrev.com/dd1103852dbb5b2a724d8ed18e3440ee10279972/ios/chrome/browser/ui/settings/block_popups_collection_view_controller_unittest.mm
[modify] https://crrev.com/dd1103852dbb5b2a724d8ed18e3440ee10279972/ios/chrome/browser/ui/settings/save_passwords_collection_view_controller_unittest.mm
[modify] https://crrev.com/dd1103852dbb5b2a724d8ed18e3440ee10279972/ios/chrome/browser/ui/settings/sync_create_passphrase_collection_view_controller_unittest.mm
[modify] https://crrev.com/dd1103852dbb5b2a724d8ed18e3440ee10279972/ios/chrome/browser/ui/settings/sync_encryption_passphrase_collection_view_controller_unittest.mm
[modify] https://crrev.com/dd1103852dbb5b2a724d8ed18e3440ee10279972/ios/testing/wait_util.h
[modify] https://crrev.com/dd1103852dbb5b2a724d8ed18e3440ee10279972/ios/testing/wait_util.mm

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54f6bc142086502d39c44499ce61fee3748275f7

commit 54f6bc142086502d39c44499ce61fee3748275f7
Author: Eugene But <eugenebut@google.com>
Date: Wed Nov 22 17:45:25 2017

Fixed waiting for condition in WebTestWithWebState::ExecuteJavaScript

Replaced WaitUntilCondition with WaitUntilConditionOrTimeout.
WebTestWithWebState::ExecuteJavaScript should return bool instead of
failing (crbug.com/780062), but replacing WaitUntilCondition with
WaitUntilConditionOrTimeout is still an improvement.

Also fixed local variable names to follow C++ Style Guide inside
WebTestWithWebState::ExecuteJavaScript and added JS logging on failure.

Bug: 787827,784735
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I321571c9bce45cccdb8dbb489900897f49a7581f
Reviewed-on: https://chromium-review.googlesource.com/786070
Reviewed-by: Mike Baxley <baxley@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518673}
[modify] https://crrev.com/54f6bc142086502d39c44499ce61fee3748275f7/ios/web/public/test/web_test_with_web_state.mm

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c101865c0fb75d315e42be50b2218de4b28a4a81

commit c101865c0fb75d315e42be50b2218de4b28a4a81
Author: Eugene But <eugenebut@google.com>
Date: Fri Jan 19 23:52:55 2018

Prevent ExecuteBlockAndWaitForLoad from hanging on the bots.

Replace WaitUntilCondition with WaitUntilConditionOrTimeout.

Bug: 784735
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I73039a4c54223d64ddab73a8ef9a7eb8e93ea1a3
Reviewed-on: https://chromium-review.googlesource.com/874552
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530667}
[modify] https://crrev.com/c101865c0fb75d315e42be50b2218de4b28a4a81/ios/web/navigation/history_state_operations_inttest.mm
[modify] https://crrev.com/c101865c0fb75d315e42be50b2218de4b28a4a81/ios/web/navigation/window_location_inttest.mm
[modify] https://crrev.com/c101865c0fb75d315e42be50b2218de4b28a4a81/ios/web/test/BUILD.gn
[modify] https://crrev.com/c101865c0fb75d315e42be50b2218de4b28a4a81/ios/web/test/web_int_test.h
[modify] https://crrev.com/c101865c0fb75d315e42be50b2218de4b28a4a81/ios/web/test/web_int_test.mm
[modify] https://crrev.com/c101865c0fb75d315e42be50b2218de4b28a4a81/ios/web/web_state/navigation_and_load_callbacks_inttest.mm

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/d179aac6cf262ffd1e97ce6afe886586f2321da7

commit d179aac6cf262ffd1e97ce6afe886586f2321da7
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Fri Jul 13 01:52:34 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12be145f421045629aa157c91dbb4a9786135592

commit 12be145f421045629aa157c91dbb4a9786135592
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Fri Jul 13 16:42:22 2018

[IOS] Move ios/testing/wait_util.* to base/test/ios/wait_util.*

It allows using WaitUntilConditionOrTimeout in the iOS components code

Bug: 784735
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ie370a3562c6774a24b0faa4838d05da3f379c201
Reviewed-on: https://chromium-review.googlesource.com/1132301
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574946}
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/base/test/ios/wait_util.h
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/base/test/ios/wait_util.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/autofill/BUILD.gn
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/autofill/form_input_egtest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/browser_state/BUILD.gn
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/browser_state/browser_state_services_egtest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/browsing_data/BUILD.gn
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/browsing_data/browsing_data_remover_impl_unittest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/context_menu/BUILD.gn
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/context_menu/context_menu_egtest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/download/BUILD.gn
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/download/download_directory_util_unittest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/feature_engagement/BUILD.gn
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/feature_engagement/feature_engagement_egtest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/metrics/BUILD.gn
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/metrics/tab_usage_recorder_test_util.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/metrics/ukm_egtest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/metrics/ukm_url_recorder_unittest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/net/BUILD.gn
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/net/cookie_util_unittest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ntp_tiles/BUILD.gn
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ntp_tiles/ntp_tiles_egtest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/passwords/BUILD.gn
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/passwords/credential_manager_egtest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/passwords/password_controller_unittest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/reading_list/BUILD.gn
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/reading_list/favicon_web_state_dispatcher_impl_unittest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ssl/BUILD.gn
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ssl/ios_captive_portal_blocking_page_unittest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/store_kit/BUILD.gn
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/translate/BUILD.gn
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/translate/translate_egtest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/activity_services/BUILD.gn
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/activity_services/canonical_url_retriever_unittest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/alert_coordinator/repost_form_coordinator_unittest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/authentication/BUILD.gn
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/authentication/authentication_flow_unittest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/authentication/chrome_signin_view_controller_unittest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/bookmarks/BUILD.gn
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/bookmarks/bookmarks_egtest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/content_suggestions/BUILD.gn
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/content_suggestions/content_suggestions_egtest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/coordinators/BUILD.gn
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/coordinators/browser_coordinator_test_util.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/dialogs/BUILD.gn
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/dialogs/javascript_dialog_egtest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/download/BUILD.gn
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/download/download_manager_coordinator_unittest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/download/download_manager_egtest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/download/download_manager_mediator_unittest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/download/pass_kit_coordinator_unittest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/download/pass_kit_egtest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/elements/activity_overlay_coordinator_unittest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/elements/selector_coordinator_unittest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/find_bar/BUILD.gn
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/find_bar/find_in_page_egtest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/first_run/BUILD.gn
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/first_run/first_run_egtest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/fullscreen/BUILD.gn
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/fullscreen/fullscreen_egtest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/history/BUILD.gn
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/history/history_ui_egtest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/ntp/BUILD.gn
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/ntp/new_tab_page_egtest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/payments/BUILD.gn
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/payments/address_edit_coordinator_unittest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/payments/billing_address_selection_coordinator_unittest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/payments/contact_info_edit_coordinator_unittest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/payments/contact_info_selection_coordinator_unittest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/payments/country_selection_coordinator_unittest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/payments/credit_card_edit_coordinator_unittest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/payments/payment_items_display_coordinator_unittest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/payments/payment_method_selection_coordinator_unittest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/payments/payment_request_coordinator_unittest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/payments/payment_request_egtest_base.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/payments/payment_request_error_coordinator_unittest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/payments/payment_request_show_egtest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/payments/shipping_address_selection_coordinator_unittest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/payments/shipping_option_selection_coordinator_unittest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/reading_list/BUILD.gn
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/reading_list/reading_list_egtest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/settings/BUILD.gn
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/settings/autofill_collection_view_controller_unittest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/settings/block_popups_collection_view_controller_unittest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/settings/passwords_settings_egtest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/settings/save_passwords_collection_view_controller_unittest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/settings/settings_egtest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/settings/sync_create_passphrase_collection_view_controller_unittest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/settings/sync_encryption_passphrase_collection_view_controller_unittest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/settings/sync_utils/BUILD.gn
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/settings/sync_utils/sync_fake_server_egtest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/signin_interaction/BUILD.gn
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/signin_interaction/signin_interaction_controller_egtest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/stack_view/BUILD.gn
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/stack_view/stack_view_egtest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/tab_grid/BUILD.gn
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/tab_grid/grid/BUILD.gn
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/tab_grid/grid/grid_view_controller_unittest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/tab_switcher/BUILD.gn
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/tab_switcher/tab_switcher_controller_egtest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/tab_switcher/tab_switcher_transition_egtest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/webui/BUILD.gn
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/ui/webui/web_ui_egtest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/web/BUILD.gn
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/web/app_launching_state_unittest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/web/browsing_egtest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/web/cache_egtest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/web/forms_egtest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/web/http_auth_egtest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/browser/web/page_placeholder_tab_helper_unittest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/test/app/BUILD.gn
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/test/app/history_test_util.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/test/app/static_html_view_test_util.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/test/app/tab_test_util.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/test/earl_grey/BUILD.gn
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/test/earl_grey/chrome_earl_grey.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/chrome/test/earl_grey/chrome_earl_grey_ui.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/net/BUILD.gn
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/net/cookies/system_cookie_store_unittest_template.h
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/testing/earl_grey/BUILD.gn
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/web/BUILD.gn
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/web/browser_state_web_view_partition_inttest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/web/download/BUILD.gn
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/web/download/download_controller_impl_unittest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/web/download/download_inttest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/web/download/download_task_impl_unittest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/web/interstitials/BUILD.gn
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/web/navigation/history_state_operations_inttest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/web/navigation/window_location_inttest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/web/net/cookies/system_cookie_store_util_unittest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/web/net/cookies/wk_http_system_cookie_store_unittest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/web/public/test/BUILD.gn
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/web/public/test/earl_grey/js_test_util.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/web/public/test/earl_grey/web_view_actions.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/web/public/test/js_test_util.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/web/public/test/navigation_test_util.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/web/public/test/web_test_with_web_state.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/web/public/test/web_view_content_test_util.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/web/public/test/web_view_interaction_test_util.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/web/shell/test/BUILD.gn
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/web/shell/test/earl_grey/shell_earl_grey.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/web/shell/test/earl_grey/shell_matchers.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/web/shell/test/pdf_egtest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/web/shell/test/service_manager_egtest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/web/test/BUILD.gn
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/web/test/web_int_test.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/web/web_state/error_page_inttest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/web/web_state/favicon_callbacks_inttest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/web/web_state/http_auth_inttest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/web/web_state/js/context_menu_js_unittest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/web/web_state/navigation_and_load_callbacks_inttest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/web/web_state/session_certificate_policy_cache_impl_unittest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/web/web_state/ui/crw_web_controller_unittest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/web/web_state/web_state_unittest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/web/webui/web_ui_mojo_inttest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/web_view/BUILD.gn
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/web_view/internal/autofill/cwv_autofill_controller_unittest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/web_view/internal/autofill/cwv_autofill_data_manager_unittest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/web_view/internal/autofill/cwv_credit_card_verifier_unittest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/web_view/shell/test/BUILD.gn
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/web_view/shell/test/earl_grey/web_view_shell_matchers.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/web_view/test/BUILD.gn
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/web_view/test/scroll_view_kvo_inttest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/web_view/test/web_view_autofill_inttest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/web_view/test/web_view_kvo_inttest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/web_view/test/web_view_script_command_inttest.mm
[modify] https://crrev.com/12be145f421045629aa157c91dbb4a9786135592/ios/web_view/test/web_view_test_util.mm

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/85d234c9daa1d5014cebe79849bb80d7c6fd33ef

commit 85d234c9daa1d5014cebe79849bb80d7c6fd33ef
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Mon Jul 16 14:19:35 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/9ae61376621c86960e0c35d6667a494243a1d602

commit 9ae61376621c86960e0c35d6667a494243a1d602
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Fri Jul 20 18:37:21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/86c90e341745f8f5c80e09e5828db5f1723f66fb

commit 86c90e341745f8f5c80e09e5828db5f1723f66fb
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Fri Jul 20 18:40:30 2018

[IOS] Move ios/testing/wait_util.* to base/test/ios/wait_util.* (cleanup)

Cleans up //ios/testing:ios_test_support that had been kept around to avoid
breaking ios downstream

Bug: 784735
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ib07bf8aa8d5e70a1980c2517fb3dbe709467c5a5
Reviewed-on: https://chromium-review.googlesource.com/1136903
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576937}
[modify] https://crrev.com/86c90e341745f8f5c80e09e5828db5f1723f66fb/components/autofill/ios/form_util/BUILD.gn
[modify] https://crrev.com/86c90e341745f8f5c80e09e5828db5f1723f66fb/ios/testing/BUILD.gn
[delete] https://crrev.com/4c5bdca5f2995c4ea619c076f18c9c5ad738673d/ios/testing/wait_util.h
[delete] https://crrev.com/4c5bdca5f2995c4ea619c076f18c9c5ad738673d/ios/testing/wait_util.mm

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2aaad0026e2adb37bf37426ef9e762ab96315a4f

commit 2aaad0026e2adb37bf37426ef9e762ab96315a4f
Author: Eugene But <eugenebut@google.com>
Date: Mon Sep 10 18:23:02 2018

Use WaitUntilConditionOrTimeout in CRWWebControllerPageScrollStateTest.

WaitUntilConditionOrTimeout replaces deprecated WaitUntilCondition.

Bug: 784735
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I7be4ef5e89e72e2bdee8721a6be7fcaba96107a8
Reviewed-on: https://chromium-review.googlesource.com/1214425
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589986}
[modify] https://crrev.com/2aaad0026e2adb37bf37426ef9e762ab96315a4f/ios/web/web_state/ui/crw_web_controller_unittest.mm

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f42bab08c24ce4bdc95090ea3bef30f0bbcdb915

commit f42bab08c24ce4bdc95090ea3bef30f0bbcdb915
Author: Eugene But <eugenebut@google.com>
Date: Mon Sep 10 19:13:32 2018

Make ios_chrome_unittest run till the end.

Replaced deprecated WaitUntilCondition with WaitUntilConditionOrTimeout
(the former method wait 2 days before DCHECKing).

Replaced DCHECK with EXPECT in test helper.

Bug: 784735
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I823b1671280ed4d52133009af75691c044c06f9e
Reviewed-on: https://chromium-review.googlesource.com/1212267
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590014}
[modify] https://crrev.com/f42bab08c24ce4bdc95090ea3bef30f0bbcdb915/ios/web/public/test/js_test_util.mm
[modify] https://crrev.com/f42bab08c24ce4bdc95090ea3bef30f0bbcdb915/ios/web/public/test/web_test_with_web_state.mm