New issue
Advanced search Search tips

Issue 784699 link

Starred by 1 user
Status: Fixed
Owner:
dtseng@chromium.org
Closed: Nov 2017
Cc:
dtseng@chromium.org
lpalmaro@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment

A11Y: Odd wrap to top behavior with search+down at end of settings

Project Member Reported by dsexton@chromium.org, Nov 14 2017 
Google Chrome 63.0.3239.26 (Official Build) beta (64-bit)
Firmware Version Google_Samus.6300.174.0

Steps to repro
# With ChromeVox enabled, navigate to settings
# Press search+h until 'Advanced' is focused
# Press search+down
# Notice that the entire settings screen has focus and ChromeVox appears to have wrapped to the top
# Press search+ up
# Notice that focus does not change and ChromeVox has not wrapped back to bottom

Expected: An announcement or sound to indicate that I was at the end of the document

Actual: Wrapped to top and search+up from this location did not return to bottom.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4fba109b31c6da6863fe87ec50c459e7a9a5e02d

commit 4fba109b31c6da6863fe87ec50c459e7a9a5e02d
Author: David Tseng <dtseng@chromium.org>
Date: Fri Nov 17 19:16:28 2017

Fix wrapping in settings

- uncaught error to Cursor::move. Closure should have caught this as a function
  that takes two args; only passed one.

- remove deep equivalent changes in cursor line movement. This causes us to get stuck in various circumstances.

- add AutomationUtil.getLastNode. It computes the last node visited by a predicate. The assumption is that we prefer ancestors that match the predicate. Elsewhere, this is expressed as skipping initial subtree hwne moving forward.

Bug:  784699 
Test: existing chromevox_tests.
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ib9713acf4e749cef31c5f816407df0aa45d5f87e
Reviewed-on: https://chromium-review.googlesource.com/775083
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517506}
[modify] https://crrev.com/4fba109b31c6da6863fe87ec50c459e7a9a5e02d/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util.js
[modify] https://crrev.com/4fba109b31c6da6863fe87ec50c459e7a9a5e02d/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util_test.extjs
[modify] https://crrev.com/4fba109b31c6da6863fe87ec50c459e7a9a5e02d/chrome/browser/resources/chromeos/chromevox/cvox2/background/command_handler.js
[modify] https://crrev.com/4fba109b31c6da6863fe87ec50c459e7a9a5e02d/chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors.js

Comment 2 by dtseng@chromium.org, Nov 17 2017

Owner: dtseng@chromium.org
Status: fixed (was: Available)

Comment 3 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 4 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)
►

Sign in to add a comment