"Allow notifications from the following" label padding is wrong on RTL langauges |
|||||
Issue descriptionChrome Version: ToT OS: Chrome OS What steps will reproduce the problem? (1) Change the system language to RTL one (e.g. Hebrew) (2) Open message center from the left bottom. (3) Click the notifier settings button. What is the expected result? "Allow notifications from the following" label should have appropriate padding. What happens instead? See the screenshot.
,
Nov 14 2017
I also noticed that the caption text ("Notifications" in english) is not shown in the screensot.
,
Nov 14 2017
#2 couldn't be reproduced
,
Nov 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4351d6de273e5983e8212603083ce632e0f6cad2 commit 4351d6de273e5983e8212603083ce632e0f6cad2 Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Wed Nov 15 03:39:43 2017 Adjust padding in RTL and add solid border in notifier settings. This CL makes following changes: - Adds solid border under the button bar in notifier settings. - Adds padding to "Allow notifications from the following" label so that it would be shown correctly in RTL languages. TEST=manual, both in English and Hebrew (RTL) BUG= 784694 ,779881 Change-Id: Ic815847cdc752bb6f89dbd60b038607e7219ed83 Reviewed-on: https://chromium-review.googlesource.com/768324 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#516583} [modify] https://crrev.com/4351d6de273e5983e8212603083ce632e0f6cad2/ash/message_center/notifier_settings_view.cc
,
Nov 15 2017
,
Jan 22 2018
,
Jan 23 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by tetsui@chromium.org
, Nov 14 2017