Flash CU failure at 10118.0.0 |
|||
Issue descriptionComponent update fails with FAIL: Failed: after download no component at /var/lib/imageloader/PepperFlashPlayer https://crosland.corp.google.com/log/10117.0.0..10118.0.0 Notice this regression is reproducible locally. 1) This is not a problem with a server or the uploaded binaries. 2) Chrome did not change. 3) ARC did not change either. Very few other changes in the delta above.
,
Nov 14 2017
Which build/board is failing? Do you have a link?
,
Nov 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/120cb3f16bda3221ac77f51550d0bc2a2ab7812e commit 120cb3f16bda3221ac77f51550d0bc2a2ab7812e Author: Ilja H. Friedel <ihf@chromium.org> Date: Tue Nov 14 01:59:08 2017 Revert "login: optionally disable component updates" This reverts commit f2410d1228a97ad6d0e0a9cac0e6e6c22076e7f8. Somehow the flag ends up on the command line for caroline and co. BUG=b:68863601, chromium:784687 Change-Id: I0b1d1065da6d4e0f3597e164552a1e36224a4cb0 Reviewed-on: https://chromium-review.googlesource.com/767969 Reviewed-by: Ilja H. Friedel <ihf@chromium.org> Tested-by: Ilja H. Friedel <ihf@chromium.org> [modify] https://crrev.com/120cb3f16bda3221ac77f51550d0bc2a2ab7812e/login_manager/chrome_setup.cc
,
Nov 14 2017
https://wmatrix.googleplex.com/unfiltered?hide_missing=True&releases=tot&tests=component_UpdateFlash&days_back=14 Just take any post 10118 build, login and check the flags. It will show --disable-component-update on the command line.
,
Nov 14 2017
chromeos-base/libchromeos-use-flags doesn't have the USE flag so it doesn't end up in the config file that the code checks which means --disable-component-update is passed to all devices
,
Nov 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/c2fd562b2b7483df7d29f1af67f35ae08691fe38 commit c2fd562b2b7483df7d29f1af67f35ae08691fe38 Author: Nicolas Norvez <norvez@chromium.org> Date: Wed Nov 15 08:39:51 2017 UI USE flags: add compupdates Depending on whether the "compupdates" USE flag is on or off, Chrome will enable/disable component updates. BUG=b:68863601 BUG= chromium:784687 TEST=Chrome on betty no longer has the --disable-component-update switch Change-Id: If5bc2e4d6ee79255e806dce99871135f355a0644 Reviewed-on: https://chromium-review.googlesource.com/770140 Commit-Ready: Nicolas Norvez <norvez@chromium.org> Tested-by: Nicolas Norvez <norvez@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [rename] https://crrev.com/c2fd562b2b7483df7d29f1af67f35ae08691fe38/chromeos-base/libchromeos-use-flags/libchromeos-use-flags-0.0.1-r41.ebuild [modify] https://crrev.com/c2fd562b2b7483df7d29f1af67f35ae08691fe38/chromeos-base/libchromeos-use-flags/libchromeos-use-flags-0.0.1.ebuild
,
Nov 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/4bf3cb94eb034df913e15a1e2c60fca3866a795e commit 4bf3cb94eb034df913e15a1e2c60fca3866a795e Author: Nicolas Norvez <norvez@chromium.org> Date: Wed Nov 15 08:39:51 2017 Reland "login: optionally disable component updates" This is a reland of f2410d1228a97ad6d0e0a9cac0e6e6c22076e7f8 Relanding after fixing the libchromeos-use-flags ebuild to accept the "compupdates" USE flag, cf. CL:770140 Original change's description: > login: optionally disable component updates > > Some targets, such as embedded systems or some VM images do not want > component updates, disable them. > > BUG=b:68863601 > TEST=no Flash update notification on novato. > CQ-DEPEND=CL:*501216 > > Change-Id: I7d94d322d7d4eec0bd7f511b03a5b9897f1f05d3 > Reviewed-on: https://chromium-review.googlesource.com/762384 > Commit-Ready: Nicolas Norvez <norvez@chromium.org> > Tested-by: Nicolas Norvez <norvez@chromium.org> > Reviewed-by: Nicolas Norvez <norvez@chromium.org> Bug: b:68863601 BUG= chromium:784687 CQ-DEPEND=CL:770140 Change-Id: I4b74cd92cad6f79fabb96d8938d4bb8053ccb8b8 Reviewed-on: https://chromium-review.googlesource.com/770170 Commit-Ready: Nicolas Norvez <norvez@chromium.org> Tested-by: Nicolas Norvez <norvez@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/4bf3cb94eb034df913e15a1e2c60fca3866a795e/login_manager/chrome_setup.cc
,
Nov 15 2017
Reland (with a fix) of the CL that broke 10118.0.0 (https://chromium-review.googlesource.com/c/chromiumos/platform2/+/762384) has landed in 10130.0.0. There are still a few failures of component_UpdateFlash on 10130.0.0 but those boards started failing before 10118.0.0 so it seems unrelated.
,
Nov 15 2017
Looks good, thanks! |
|||
►
Sign in to add a comment |
|||
Comment 1 by ihf@chromium.org
, Nov 14 2017Status: Assigned (was: Untriaged)