Button hover animations in the user menu make it feel laggy |
|||||||
Issue descriptionChrome Version: 64.0.3265.0 OS: macOS 10.12 What steps will reproduce the problem? (1) Click the user button at the far right of the tabstrip so that the user menu appears (2) Hover over menu items What is the expected result? Quick update of rolled-over menu items. What happens instead? Menu items are slow to update.
,
Nov 14 2017
,
Nov 14 2017
This is from r515443 - we have an email thread going about the treatment here. The lag is not performance or latency related -- it's just due to the hover effects animating their opacity over time, and affects all desktop platforms. If we set the animation time to 0ms then the perception of lag will go away. We should probably just do this, unless designers say otherwise :)
,
Nov 14 2017
Is there a bug we should dupe this one into that's already tracking this?
,
Nov 14 2017
no other bug that I know of - r515443 is quite recent. The thread is http://go/abzuz
,
Nov 15 2017
Hi trent, So I guess I can assign this bug to you?
,
Nov 15 2017
I guess assigning this bug to Patti seems better.
,
Nov 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2dd7f6c07aa8da74798ccdee953cc33e8d484b2c commit 2dd7f6c07aa8da74798ccdee953cc33e8d484b2c Author: Patti <patricialor@chromium.org> Date: Thu Nov 16 05:21:19 2017 Profile Chooser/Views: Only one HoverButton can be highlighted at a time. When mouse hovering and tabbing through the buttons in the ProfileChooserView at the same time, it is possible to get two different buttons to be highlighted. Prevent this by requesting focus on hover, then highlighting on focus only. This prevents confusion about which item actually has keyboard focus. This has the desired side effect of making the fade-in animation duration instant as well ( crbug.com/784684 ). Bug: 785164 , 785262 , 784684 Change-Id: Id379f2c373307f2c49dbce58cf40d3d61f9f324e Reviewed-on: https://chromium-review.googlesource.com/773319 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#516996} [modify] https://crrev.com/2dd7f6c07aa8da74798ccdee953cc33e8d484b2c/chrome/browser/ui/views/hover_button.cc [modify] https://crrev.com/2dd7f6c07aa8da74798ccdee953cc33e8d484b2c/chrome/browser/ui/views/hover_button.h
,
Nov 16 2017
,
Nov 17 2017
Tested this issue on Windows 7,Mac 10.12.6 & ubuntu 14.04 using chrome #64.0.3271.0 as per C#0 . Observed quick highlight on the menu list items when we quickly/slowly hover on the list.As it is working as intended, adding TE Verified labels . Please find the attached screencast for reference. Thanks.! |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by ew...@chromium.org
, Nov 14 2017Owner: jlebel@chromium.org