New issue
Advanced search Search tips

Issue 784664 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 784661



Sign in to add a comment

[Telemetry] Provide non-noisey MSE test cases.

Project Member Reported by crouleau@chromium.org, Nov 14 2017

Issue description

I'm reducing noise and adding built-in re-runs to support issue 784661. 

 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28897f84d2d2457d38305b310a5a6ca90ea244a7

commit 28897f84d2d2457d38305b310a5a6ca90ea244a7
Author: Caleb Rouleau <crouleau@chromium.org>
Date: Tue Nov 14 23:39:20 2017

[Media Cases] Reduce noise in MSE tests by waiting until xhr completes.

This will mean that networking changes will not affect
time_to_video_play and other metrics.

Bug:  784664 
Change-Id: I73204bfcdf650ece2250361264970371544675a1
Reviewed-on: https://chromium-review.googlesource.com/767889
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516500}
[modify] https://crrev.com/28897f84d2d2457d38305b310a5a6ca90ea244a7/tools/perf/page_sets/media_cases/mse.js

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05121b638fb7d738846e17d445d8c7fc7a7d3ce2

commit 05121b638fb7d738846e17d445d8c7fc7a7d3ce2
Author: Caleb Rouleau <crouleau@chromium.org>
Date: Wed Nov 15 02:06:57 2017

[Telemetry] Repeat MSE test case runs.

This reduces noise. The MSE cases are pretty noisy right now.
See https://chromeperf.appspot.com/report?sid=ea77547fca270648c54a3719118abc4a70877c94bd7da1d53e6a002f74efb9af
We only want to repeat the MSE cases, not the other tests in that benchmark.

This should add .5 (seconds/addition run) * 9 (additional runs) * 4 (test cases) = ~18 seconds

Bug:  784664 
Change-Id: Ia4862ba4e8ede1a15e5a8d5ba92e01bdb1bce5a2
Reviewed-on: https://chromium-review.googlesource.com/767896
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516558}
[modify] https://crrev.com/05121b638fb7d738846e17d445d8c7fc7a7d3ce2/tools/perf/page_sets/media_cases.py

Status: Fixed (was: Assigned)
Fixed. issue 784661 should be unblocked.
Components: Tests>Telemetry Internals>Media

Sign in to add a comment