New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 784653 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Remove is_loaded from OfflinePageModel interface

Project Member Reported by romax@chromium.org, Nov 14 2017

Issue description

Since is_loaded() is no longer used in OfflinePageModelTaskified, and there has been a TODO in offline_page_model.h for a while, it should probably be cleaned up.
 
Labels: OS-Android
Owner: chili@chromium.org
Cathy, please consider this as a good entry level bug for Candice to get started.

Comment 2 by chili@chromium.org, Nov 14 2017

Owner: cmsy@google.com
Status: Assigned (was: Available)
@Candice another good starter bug
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d577dd09adcfe8a2a9e7391c306b55c2e785593

commit 3d577dd09adcfe8a2a9e7391c306b55c2e785593
Author: Candice Sy <cmsy@google.com>
Date: Sat Nov 18 00:26:56 2017

Removed is_loaded() from OfflinePageModel

Clean up because is_loaded() is no longer used. The function was removed from OfflinePageModel and classes that overrode it.

Bug:  784653 
Change-Id: I72f38e5621ba67762d0086d5a1c1cafbb614e6b3
Reviewed-on: https://chromium-review.googlesource.com/772977
Commit-Queue: Candice Sy <cmsy@google.com>
Reviewed-by: Yafei Duan <romax@chromium.org>
Reviewed-by: vitaliii <vitaliii@chromium.org>
Reviewed-by: Cathy Li <chili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517630}
[modify] https://crrev.com/3d577dd09adcfe8a2a9e7391c306b55c2e785593/chrome/browser/ntp_snippets/download_suggestions_provider.cc
[modify] https://crrev.com/3d577dd09adcfe8a2a9e7391c306b55c2e785593/chrome/browser/offline_pages/android/evaluation/offline_page_evaluation_bridge.cc
[modify] https://crrev.com/3d577dd09adcfe8a2a9e7391c306b55c2e785593/chrome/browser/offline_pages/android/offline_page_bridge.cc
[modify] https://crrev.com/3d577dd09adcfe8a2a9e7391c306b55c2e785593/chrome/browser/offline_pages/recent_tab_helper_unittest.cc
[modify] https://crrev.com/3d577dd09adcfe8a2a9e7391c306b55c2e785593/components/ntp_snippets/offline_pages/offline_pages_test_utils.cc
[modify] https://crrev.com/3d577dd09adcfe8a2a9e7391c306b55c2e785593/components/ntp_snippets/offline_pages/offline_pages_test_utils.h
[modify] https://crrev.com/3d577dd09adcfe8a2a9e7391c306b55c2e785593/components/offline_pages/core/model/offline_page_model_taskified.cc
[modify] https://crrev.com/3d577dd09adcfe8a2a9e7391c306b55c2e785593/components/offline_pages/core/model/offline_page_model_taskified.h
[modify] https://crrev.com/3d577dd09adcfe8a2a9e7391c306b55c2e785593/components/offline_pages/core/offline_page_model.h
[modify] https://crrev.com/3d577dd09adcfe8a2a9e7391c306b55c2e785593/components/offline_pages/core/offline_page_model_impl.cc
[modify] https://crrev.com/3d577dd09adcfe8a2a9e7391c306b55c2e785593/components/offline_pages/core/offline_page_model_impl.h
[modify] https://crrev.com/3d577dd09adcfe8a2a9e7391c306b55c2e785593/components/offline_pages/core/offline_page_model_impl_unittest.cc
[modify] https://crrev.com/3d577dd09adcfe8a2a9e7391c306b55c2e785593/components/offline_pages/core/stub_offline_page_model.cc
[modify] https://crrev.com/3d577dd09adcfe8a2a9e7391c306b55c2e785593/components/offline_pages/core/stub_offline_page_model.h

Comment 4 by romax@chromium.org, Nov 20 2017

Status: Fixed (was: Assigned)
This is fixed after the CL landed. Closing as fixed.

Sign in to add a comment