CQ merged my CL when trybots are still running |
|||||||
Issue descriptionCQ merged my CL when trybots are still running: https://chromium-review.googlesource.com/c/chromium/src/+/764597 And there is test failure about this CL so this CL shouldn't be merged at all. This is pretty bad.
,
Nov 14 2017
Unfortunately, at this point I can't easily tell which jobs were still running, or what the failures were. Can you provide more info? It's possible that this is related to my CQ config change, but without more info it's hard to say.
,
Nov 14 2017
linux_chromium_chromeos_rel_ng is failed constantly in https://chromium-review.googlesource.com/c/chromium/src/+/764597. CL is merged in the middle way of "submit to CQ" procedure. Hopefully this is transient.
,
Nov 14 2017
Thanks. linux_chromium_chromeos_rel_ng was replaced by linux-chromeos-rel, and so when the CQ landed your change it saw a green build for the latter and decided things were good to go (i.e., this part was correct). However, looking at https://build.chromium.org/p/tryserver.chromium.chromiumos/builders/linux-chromeos-rel/builds/1711 https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/550586 The former isn't running any tests and the latter is. That's not good. I will see what's going on.
,
Nov 14 2017
Apparently they're not running any tests because I didn't tell them to run any tests :(. Fixing now ...
,
Nov 14 2017
(I think non-Fuchsia, removing tag)
,
Nov 14 2017
This should be fixed now (crrev.com/c/768095), but we may see fallout today from tryjobs that ran before my fix that the CQ thinks were good enough.
,
Jan 22 2018
,
Jan 23 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by jamescook@chromium.org
, Nov 14 2017Components: Infra
Labels: Infra-Troopers