New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 784628 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Task



Sign in to add a comment

Update Annotee version used by BuildBot.

Project Member Reported by d...@chromium.org, Nov 13 2017

Issue description

For context: https://groups.google.com/a/google.com/forum/#!topic/chromeos-infra-discuss/4KTTY44DqDA/discussion

Notably: https://groups.google.com/a/google.com/d/msg/chromeos-infra-discuss/4KTTY44DqDA/kP26CLUBAQAJ

This is something that has come up a few times in CrOS discussion after LogDog was enabled everywhere due to build failure e-mails. Assigning to iannucci@ as per the discussion thread, feel free to pass on to someone else.
 
IIUC, I just need to bump annotee to latest in buildbotland?

Comment 2 by d...@chromium.org, Nov 13 2017

I believe that is correct. Note that this also involves updating Butler, which in turn pulls in new "winio" usage on Windows and "luci_context" awareness.

This is believed to be fine, b/c I switched back to "winio" after they fixed the bug that is the reason we switched away, but keep an eye out. I think this is probably also tested heavily via our numerous Kitchen deployments: https://chromium.googlesource.com/infra/infra/+/master/go/src/infra/tools/kitchen/cook_logdog_windows.go
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/8eca8459779b6bc461447d43ca974d003515d2de

commit 8eca8459779b6bc461447d43ca974d003515d2de
Author: Robert Iannucci <iannucci@chromium.org>
Date: Tue Nov 14 00:37:46 2017

[logdog] Bump canary infra logdog+anotee versions to latest

R=dnj@chromium.org, vadimsh@chromium.org

Bug:  784628 
Change-Id: Ic37925bdc89b284b44d88bdbc70d0c5055eb0fb9
Reviewed-on: https://chromium-review.googlesource.com/767597
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/8eca8459779b6bc461447d43ca974d003515d2de/scripts/slave/logdog_bootstrap.py

Comment 5 by hinoka@chromium.org, Nov 15 2017

Labels: -Type-Bug Type-Task
Status: Started (was: Untriaged)
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/0ecb4389b058b978e3d6d8a46b92d51c495d70e3

commit 0ecb4389b058b978e3d6d8a46b92d51c495d70e3
Author: Robert Iannucci <iannucci@chromium.org>
Date: Wed Nov 15 22:44:08 2017

[logdog] Bump prod logdog+annotee versions to latest.

R=dnj@chromium.org, vadimsh@chromium.org

Bug:  784628 
Change-Id: Icb3e912efb83771defa46e0367c16c3e38d76fad
Reviewed-on: https://chromium-review.googlesource.com/772972
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/0ecb4389b058b978e3d6d8a46b92d51c495d70e3/scripts/slave/logdog_bootstrap.py

Status: Fixed (was: Started)

Sign in to add a comment