api.platforms.win._get_os_numbers() fails on latest Windows update. |
|||
Issue descriptionDescribe infrastructure request/issue: api.platforms.win._get_os_numbers() fails on the latest Windows 10 feature update. The new output from ver is "Microsoft Windows [Version 10.0.16299.19]". The regex isn't expecting the fourth number, so fails to match.
,
Nov 13 2017
becf2fa1a709f5e1e5ce6bada457adc1eaddd210 is broken.
,
Nov 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/luci/luci-py.git/+/1d74186c2d88aaaff81cf877df72da24515e875f commit 1d74186c2d88aaaff81cf877df72da24515e875f Author: Marc-Antoine Ruel <maruel@chromium.org> Date: Tue Nov 14 00:58:00 2017 swarming_bot: fix regression in becf2fa1a709f5e. The regexp was incorrect. Add unit test to confirm the new one works. TBR=benjaminwagner@chromium.org Bug: 784626 Change-Id: I65f57768b876db4c770f075454461fac7d937f69 Reviewed-on: https://chromium-review.googlesource.com/767908 Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> [modify] https://crrev.com/1d74186c2d88aaaff81cf877df72da24515e875f/appengine/swarming/swarming_bot/api/platforms/win.py [modify] https://crrev.com/1d74186c2d88aaaff81cf877df72da24515e875f/appengine/swarming/swarming_bot/api/platforms/win_test.py
,
Nov 14 2017
Fix is live. I'll slowly deploy to all instances but there's a bunch of changes os I don't want to be too aggressive. |
|||
►
Sign in to add a comment |
|||
Comment 1 by mar...@chromium.org
, Nov 13 2017Owner: mar...@chromium.org
Status: Assigned (was: Untriaged)