New issue
Advanced search Search tips

Issue 784594 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

[Media Router] Add provider ID attribute to MediaRoute and MediaSink

Project Member Reported by taku...@chromium.org, Nov 13 2017

Issue description

Making MediaRoute and MediaSink aware of which MediaRouteProvider they belong to will simplify route and sink management in MediaRouterMojoImpl.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2feabf471f0b15b80d19ab5ef1d444dc2496e090

commit 2feabf471f0b15b80d19ab5ef1d444dc2496e090
Author: Takumi Fujimoto <takumif@chromium.org>
Date: Tue Dec 05 00:13:14 2017

[Media Router] Add provider_id attribute to MediaSink

This allows us to simplify how sinks are stored in MediaRouterMojoImpl::MediaSinksQuery.
We need to typemap mojom::MediaRouteProvider::Id to a C++ enum because MediaSink is used by Android but the mojo files aren't.

A CL to add provider_id to MediaRoute will follow.

Bug: 784594
Change-Id: I61fef4b2d2416333b5016313addbc64381aabda1
Reviewed-on: https://chromium-review.googlesource.com/761697
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521542}
[modify] https://crrev.com/2feabf471f0b15b80d19ab5ef1d444dc2496e090/chrome/browser/media/router/mojo/extension_media_route_provider_proxy_unittest.cc
[modify] https://crrev.com/2feabf471f0b15b80d19ab5ef1d444dc2496e090/chrome/browser/media/router/mojo/media_router_desktop.cc
[modify] https://crrev.com/2feabf471f0b15b80d19ab5ef1d444dc2496e090/chrome/browser/media/router/mojo/media_router_desktop.h
[modify] https://crrev.com/2feabf471f0b15b80d19ab5ef1d444dc2496e090/chrome/browser/media/router/mojo/media_router_desktop_unittest.cc
[modify] https://crrev.com/2feabf471f0b15b80d19ab5ef1d444dc2496e090/chrome/browser/media/router/mojo/media_router_mojo_impl.cc
[modify] https://crrev.com/2feabf471f0b15b80d19ab5ef1d444dc2496e090/chrome/browser/media/router/mojo/media_router_mojo_impl.h
[modify] https://crrev.com/2feabf471f0b15b80d19ab5ef1d444dc2496e090/chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc
[modify] https://crrev.com/2feabf471f0b15b80d19ab5ef1d444dc2496e090/chrome/browser/media/router/mojo/media_router_mojo_test.cc
[modify] https://crrev.com/2feabf471f0b15b80d19ab5ef1d444dc2496e090/chrome/browser/media/router/mojo/media_router_mojo_test.h
[modify] https://crrev.com/2feabf471f0b15b80d19ab5ef1d444dc2496e090/chrome/browser/media/router/mojo/mock_mojo_media_router.h
[modify] https://crrev.com/2feabf471f0b15b80d19ab5ef1d444dc2496e090/chrome/browser/media/router/mojo/wired_display_media_route_provider.cc
[modify] https://crrev.com/2feabf471f0b15b80d19ab5ef1d444dc2496e090/chrome/browser/media/router/mojo/wired_display_media_route_provider.h
[modify] https://crrev.com/2feabf471f0b15b80d19ab5ef1d444dc2496e090/chrome/browser/media/router/mojo/wired_display_media_route_provider_unittest.cc
[modify] https://crrev.com/2feabf471f0b15b80d19ab5ef1d444dc2496e090/chrome/common/media_router/BUILD.gn
[modify] https://crrev.com/2feabf471f0b15b80d19ab5ef1d444dc2496e090/chrome/common/media_router/discovery/media_sink_internal.h
[modify] https://crrev.com/2feabf471f0b15b80d19ab5ef1d444dc2496e090/chrome/common/media_router/discovery/media_sink_service_base_unittest.cc
[add] https://crrev.com/2feabf471f0b15b80d19ab5ef1d444dc2496e090/chrome/common/media_router/media_route_provider_helper.h
[modify] https://crrev.com/2feabf471f0b15b80d19ab5ef1d444dc2496e090/chrome/common/media_router/media_sink.cc
[modify] https://crrev.com/2feabf471f0b15b80d19ab5ef1d444dc2496e090/chrome/common/media_router/media_sink.h
[modify] https://crrev.com/2feabf471f0b15b80d19ab5ef1d444dc2496e090/chrome/common/media_router/media_sink_unittest.cc
[modify] https://crrev.com/2feabf471f0b15b80d19ab5ef1d444dc2496e090/chrome/common/media_router/mojo/media_router.mojom
[modify] https://crrev.com/2feabf471f0b15b80d19ab5ef1d444dc2496e090/chrome/common/media_router/mojo/media_router.typemap
[modify] https://crrev.com/2feabf471f0b15b80d19ab5ef1d444dc2496e090/chrome/common/media_router/mojo/media_router_struct_traits.cc
[modify] https://crrev.com/2feabf471f0b15b80d19ab5ef1d444dc2496e090/chrome/common/media_router/mojo/media_router_struct_traits.h
[modify] https://crrev.com/2feabf471f0b15b80d19ab5ef1d444dc2496e090/chrome/common/media_router/mojo/media_router_struct_traits_unittest.cc
[modify] https://crrev.com/2feabf471f0b15b80d19ab5ef1d444dc2496e090/chrome/renderer/resources/extensions/media_router_bindings.js

Can this be closed out?
Not yet, we still need to add the attribute to MediaRoute.
Labels: -M-65 M-66
Labels: -M-66 M-67
Labels: -M-67
Prioritizing other work.
Cc: powerb@chromium.org

Sign in to add a comment