New issue
Advanced search Search tips

Issue 784590 link

Starred by 1 user
Status: Assigned
Owner:
ekaramad@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 330264



Sign in to add a comment

Should is_guest_view_hack_ be on RWHVBase?

Project Member Reported by dmazz...@chromium.org, Nov 13 2017 
It's used by both Mac and Aura already, we could avoid some duplication by putting it there.

Here's one example:

https://cs.chromium.org/search/?q=is_guest_view_hack_.*GetFocusedWidget&sq=package:chromium&type=cs

Comment 1 by ekaramad@chromium.org, Nov 14 2017 

Thanks for filing this. |is_guest_view_hack_| is only relevant on desktop and top-level views. So RWHVChildFrame and RWHVAndroid do not need it. So we could move it there for Aura and Mac.

However, we are moving all guest views and PDF viewer to using OOPIFs which will eventually pave the path for removing the legacy guest view code including this flag. So long as the flag is not causing lots of headache we can leave it be and hopefully it will be removed early 2018.
►

Sign in to add a comment