Remove dependency on /boot/autorun for Fuchsia runner |
||
Issue descriptionFuchsia/Zircon would like to remove /boot/autorun in favour of a kernel command line option, see https://fuchsia-review.googlesource.com/c/zircon/+/86815 This would break our test running. I'll take a look to update so we instead use the kernel command line rather than relying on /system/autorun getting automatically run.
,
Nov 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e30279e8e36d57ab7495bb069600a5dce5f8b2fd commit e30279e8e36d57ab7495bb069600a5dce5f8b2fd Author: Scott Graham <scottmg@chromium.org> Date: Tue Nov 14 21:20:50 2017 fuchsia: Use zircon.autorun.system instead of relying on magic autorun Implicit launch of /system/autorun is being deprecated in https://fuchsia-review.googlesource.com/c/zircon/+/86815. Instead, use kernel command line option to accomplish the same. The autorun script file is also renamed from /system/autorun to /system/cr_autorun so that in the overlapping time before that CL lands, the autorun script won't be run twice at startup. Bug: 784586 Change-Id: I7ac2eeb9aa79b20c1683e3b5fb504875b0d79191 Reviewed-on: https://chromium-review.googlesource.com/767373 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#516428} [modify] https://crrev.com/e30279e8e36d57ab7495bb069600a5dce5f8b2fd/build/fuchsia/runner_common.py
,
Nov 14 2017
,
Nov 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/588f886a6a920a8db60eda7f7f623f46d1950085 commit 588f886a6a920a8db60eda7f7f623f46d1950085 Author: Scott Graham <scottmg@chromium.org> Date: Wed Nov 15 01:30:08 2017 fuchsia: Remove kernel.halt_on_panic halt_on_panic became incorrect in August, but we didn't notice (spelunking at https://fuchsia-review.googlesource.com/c/zircon/+/87815). I think that option was copied from some Zircon run scripts, but I don't think at the Chromium level we care to debug the kernel too much, and since the option hasn't been doing anything since August (should have been halt-on-panic instead), just remove it. Bug: 784586 Change-Id: I3ab05ddc7eaa9efa69099682d715f6c712a04ede Reviewed-on: https://chromium-review.googlesource.com/769748 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#516546} [modify] https://crrev.com/588f886a6a920a8db60eda7f7f623f46d1950085/build/fuchsia/runner_common.py |
||
►
Sign in to add a comment |
||
Comment 1 by scottmg@chromium.org
, Nov 13 2017