New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 784582 link

Starred by 1 user
Status: Verified
Owner:
zmin@chromium.org
Closed: Feb 2018
Cc:
█ leslieh@google.com
msarda@chromium.org
█ ainslie@chromium.org
georgesak@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Change text in embedded sign-in flow when forced sign-in is enabled

Project Member Reported by ew...@chromium.org, Nov 13 2017 
See here for more background: https://groups.google.com/a/google.com/forum/#!topic/chrome-signin/sRCl6-sxPzc

We should remove the "sign in to Chrome"/"sync" text from the embedded sign-in page (see here: https://screenshot.googleplex.com/1WEtaHMSMwi.png), and instead replace it with: "with your Google Account" (so the entire text should read "Sign in to Chrome / with your Google Account").

Per the email thread, we should add a new value for the flow parameter to indicate to GAIA that this body text should be changed.

Comment 1 by ew...@chromium.org, Nov 15 2017 

For the record, we've settled on using "flow=enterprisefsi" on the email thread: https://groups.google.com/a/google.com/forum/#!topic/chrome-signin/sRCl6-sxPzc

Comment 2 by zmin@chromium.org, Nov 15 2017

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b5f8dcd5060091143d34ca767b4e9abe1fc3f58

commit 7b5f8dcd5060091143d34ca767b4e9abe1fc3f58
Author: Owen Min <zmin@chromium.org>
Date: Tue Nov 21 20:41:43 2017

Add flow=enterprisefsi into gaia sign in url dialog if force-sign-in is enabled

With this new flow parameter value, sign in dialog will not contains chrome
sync related information in the embedded sign-in page.

Bug:  784582 
Change-Id: I2b315d381750bc1ad3932d5a8bf3edcab8a64285
Reviewed-on: https://chromium-review.googlesource.com/775693
Commit-Queue: Owen Min <zmin@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518377}
[modify] https://crrev.com/7b5f8dcd5060091143d34ca767b4e9abe1fc3f58/chrome/browser/ui/cocoa/profiles/user_manager_mac.mm
[modify] https://crrev.com/7b5f8dcd5060091143d34ca767b4e9abe1fc3f58/chrome/browser/ui/user_manager.h
[modify] https://crrev.com/7b5f8dcd5060091143d34ca767b4e9abe1fc3f58/chrome/browser/ui/views/profiles/user_manager_view.cc
[modify] https://crrev.com/7b5f8dcd5060091143d34ca767b4e9abe1fc3f58/chrome/browser/ui/webui/signin/inline_login_handler.cc
[modify] https://crrev.com/7b5f8dcd5060091143d34ca767b4e9abe1fc3f58/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc
[modify] https://crrev.com/7b5f8dcd5060091143d34ca767b4e9abe1fc3f58/chrome/browser/ui/webui/signin/signin_create_profile_handler.cc
[modify] https://crrev.com/7b5f8dcd5060091143d34ca767b4e9abe1fc3f58/chrome/browser/ui/webui/signin/user_manager_screen_handler.cc
[modify] https://crrev.com/7b5f8dcd5060091143d34ca767b4e9abe1fc3f58/components/signin/core/browser/signin_metrics.h
[modify] https://crrev.com/7b5f8dcd5060091143d34ca767b4e9abe1fc3f58/tools/metrics/histograms/enums.xml

Comment 4 by zmin@chromium.org, Feb 27 2018

Status: Verified (was: Started)
►

Sign in to add a comment