Using the 'revert' Gerrit button enqueues the reverted CL with CR+1, instead of maximum available code review value |
|||||||
Issue descriptionIf I revert a CL, such as here: https://chromium-review.googlesource.com/c/angle/angle/+/767128 The revert feature successfully creates the revert CL and enqueues it in code review, but uses CQ+2 CR+1. With ANGLE we have CR+1 and CR+2, where CR+2 is required to land CLs. The revert should be landed with CR+2.
,
Nov 16 2017
I should be able to do this pretty easily using change.permitted_labels in a followup to https://chromium-review.googlesource.com/c/infra/gerrit-plugins/chromium-behavior/+/757676
,
Jan 4 2018
Removing myself from all Pri-2/3 Gerrit issues and setting them to Available, to more accurately reflect the fact that there are a bunch of Pri-1 bugs open, and I'm splitting my time between codereview and codesearch.
,
Jan 4
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 4
I think this actually was fixed at some point. But I'm not sure how to test it without actually reverting a landed CL.
,
Jan 17
(6 days ago)
Unsure what fixed this but it works now: https://chromium-review.googlesource.com/c/angle/angle/+/1417771
,
Jan 17
(6 days ago)
,
Jan 17
(6 days ago)
Looks like. Thanks! |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by jmad...@chromium.org
, Nov 13 2017