New issue
Advanced search Search tips

Issue 784573 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 748910



Sign in to add a comment

Chrome OS VPN backed by ARC++ UI support

Project Member Reported by lgcheng@google.com, Nov 13 2017

Issue description

Comment 1 by lgcheng@google.com, Nov 13 2017

Blocking: 748910
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7bfe4e9e05566b029baa7d45a0b58eb2aee3201a

commit 7bfe4e9e05566b029baa7d45a0b58eb2aee3201a
Author: lgcheng <lgcheng@google.com>
Date: Wed Nov 29 00:53:32 2017

Add internet_page_browser_proxy

Add internet_page_browser_proxy to hold Chrome.send() for external VPN
providers which are not going to be depericated.

Bug:  784573 
Test: Manual
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Icfcab81de857864611c4a0cde89245853513bcc5
Reviewed-on: https://chromium-review.googlesource.com/779712
Commit-Queue: Long Cheng <lgcheng@google.com>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519936}
[modify] https://crrev.com/7bfe4e9e05566b029baa7d45a0b58eb2aee3201a/chrome/browser/resources/settings/internet_page/compiled_resources2.gyp
[modify] https://crrev.com/7bfe4e9e05566b029baa7d45a0b58eb2aee3201a/chrome/browser/resources/settings/internet_page/internet_page.js
[add] https://crrev.com/7bfe4e9e05566b029baa7d45a0b58eb2aee3201a/chrome/browser/resources/settings/internet_page/internet_page_browser_proxy.html
[add] https://crrev.com/7bfe4e9e05566b029baa7d45a0b58eb2aee3201a/chrome/browser/resources/settings/internet_page/internet_page_browser_proxy.js
[modify] https://crrev.com/7bfe4e9e05566b029baa7d45a0b58eb2aee3201a/chrome/browser/resources/settings/internet_page/internet_shared_css.html
[modify] https://crrev.com/7bfe4e9e05566b029baa7d45a0b58eb2aee3201a/chrome/browser/resources/settings/internet_page/internet_subpage.js
[modify] https://crrev.com/7bfe4e9e05566b029baa7d45a0b58eb2aee3201a/chrome/browser/resources/settings/settings_resources.grd

Project Member

Comment 3 by bugdroid1@chromium.org, Nov 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4f2e233609217c2783357006ed5bcd730119d11

commit e4f2e233609217c2783357006ed5bcd730119d11
Author: lgcheng <lgcheng@google.com>
Date: Wed Nov 29 01:57:24 2017

Arc vpn provider support in Chrome://settings

Support Arc vpn provider UI support in Chrome://settings page

Bug:  784573 
Test: Manual
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I1fde7f3ed3dce9243f444578f7e24e0e44ac1c66
Reviewed-on: https://chromium-review.googlesource.com/757760
Commit-Queue: Long Cheng <lgcheng@google.com>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519954}
[modify] https://crrev.com/e4f2e233609217c2783357006ed5bcd730119d11/chrome/app/settings_strings.grdp
[modify] https://crrev.com/e4f2e233609217c2783357006ed5bcd730119d11/chrome/browser/resources/settings/internet_page/compiled_resources2.gyp
[modify] https://crrev.com/e4f2e233609217c2783357006ed5bcd730119d11/chrome/browser/resources/settings/internet_page/internet_detail_page.js
[modify] https://crrev.com/e4f2e233609217c2783357006ed5bcd730119d11/chrome/browser/resources/settings/internet_page/internet_page.html
[modify] https://crrev.com/e4f2e233609217c2783357006ed5bcd730119d11/chrome/browser/resources/settings/internet_page/internet_page.js
[modify] https://crrev.com/e4f2e233609217c2783357006ed5bcd730119d11/chrome/browser/resources/settings/internet_page/internet_page_browser_proxy.js
[modify] https://crrev.com/e4f2e233609217c2783357006ed5bcd730119d11/chrome/browser/resources/settings/internet_page/internet_subpage.html
[modify] https://crrev.com/e4f2e233609217c2783357006ed5bcd730119d11/chrome/browser/resources/settings/internet_page/internet_subpage.js
[modify] https://crrev.com/e4f2e233609217c2783357006ed5bcd730119d11/chrome/browser/ui/webui/settings/chromeos/internet_handler.cc
[modify] https://crrev.com/e4f2e233609217c2783357006ed5bcd730119d11/chrome/browser/ui/webui/settings/chromeos/internet_handler.h
[modify] https://crrev.com/e4f2e233609217c2783357006ed5bcd730119d11/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/e4f2e233609217c2783357006ed5bcd730119d11/chrome/browser/ui/webui/settings/md_settings_ui.cc
[modify] https://crrev.com/e4f2e233609217c2783357006ed5bcd730119d11/chrome/test/data/webui/settings/internet_page_tests.js

Comment 4 by lgcheng@google.com, Nov 29 2017

Status: Fixed (was: Untriaged)

Sign in to add a comment