New issue
Advanced search Search tips

Issue 784566 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

coral version file shows temp files

Project Member Reported by sjg@chromium.org, Nov 13 2017

Issue description

The output shows the full path including the temporary files. It should only show something like */models/image-coral.bin

Model:        astronaut
BIOS image:   4f201cec1e3955a4503b575725244e9a */build/coral/tmp/portage/chromeos-base/chromeos-firmware-coral-9999/temp/tmplkuNRQ.pack_firmware-14042/models/astronaut/image-coral.bin
BIOS version: Google_Coral.10068.14.0
EC image:     0769d9b60cd620811e9ad21c8efac9aa */build/coral/tmp/portage/chromeos-base/chromeos-firmware-coral-9999/temp/tmplkuNRQ.pack_firmware-14042/models/astronaut/ec.bin
EC version:   coral_v1.1.7248-2605737c4
Chrome Version: (copy from chrome://version)
OS: (e.g. Win7, OSX 10.9.5, etc...)

What steps will reproduce the problem?
(1)
(2)
(3)

What is the expected result?

What happens instead?

Please use labels and text to provide additional information.


For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

 
Cc: nsanders@chromium.org

Comment 2 by sjg@chromium.org, Jan 3 2018

Status: Started (was: Untriaged)
CL here:

https://chromium-review.googlesource.com/c/chromiumos/platform/firmware/+/849553
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/firmware/+/a599255552a59e299d2d2d948912afd95f567754

commit a599255552a59e299d2d2d948912afd95f567754
Author: Simon Glass <sjg@chromium.org>
Date: Fri Jan 05 03:17:54 2018

pack_firmware: Drop unnecessary temp filename path

The temporary directory that was used to create the images is not useful
information for the VERSION file. Drop it.

BUG= chromium:784566 
TEST=FEATURES=test emerge-coral --nodeps chromeos-firmware-coral
See that we now get:

BIOS image:   b4e8409794df91b9cffb698bda0bef84
			*/build/coral/firmware/image-coral.bin

instead of:

BIOS image:   82cdf7746e70e40c0d1d72cfd7d5f33e
		*/build/coral/tmp/portage/chromeos-base/
		chromeos-firmware-coral-0.0.1-r77/temp/
		tmpx7RMFO.pack_firmware-92196/models/astronaut/image-coral.bin

Change-Id: Ib6dd9379697fba08c1a0cc989347e5d28283a93a
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/849553
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/a599255552a59e299d2d2d948912afd95f567754/pack_firmware.py

Comment 4 by sjg@chromium.org, Jan 5 2018

Status: Fixed (was: Started)

Sign in to add a comment