New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 784563 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 2
Type: Bug

Blocking:
issue 703263



Sign in to add a comment

LayerWithRealCompositorTest.CompositorObservers is flaky

Project Member Reported by adithyas@chromium.org, Nov 13 2017

Issue description

Comment 1 by danakj@chromium.org, Nov 14 2017

Cc: vollick@chromium.org piman@chromium.org
Components: Internals>Compositing UI>Aura Tests>Flaky

Comment 2 by danakj@chromium.org, Nov 14 2017

Failure looks like:

[ RUN      ] LayerWithRealCompositorTest.CompositorObservers
../../ui/compositor/layer_unittest.cc(1431): error: Value of: observer.notified()
  Actual: false
Expected: true
[  FAILED  ] LayerWithRealCompositorTest.CompositorObservers (552 ms)

On the failing run it repeated and failed multiple times. So maybe the test isn't flaky itself but depending on some global state.

Comment 4 by danakj@chromium.org, Nov 15 2017

Blocking: 703263

Comment 5 by guidou@chromium.org, Nov 17 2017

Labels: -Sheriff-Chromium
Disabling the test on Windows to avoid flakes.
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/121a6e2583225ebe4f435827fcdcb4580f16d947

commit 121a6e2583225ebe4f435827fcdcb4580f16d947
Author: Guido Urdaneta <guidou@chromium.org>
Date: Fri Nov 17 11:01:08 2017

Disable flaky LayerWithRealCompositorTest.CompositorObservers on Windows

TBR=danakj@chromium.org

Bug: 784563
Change-Id: I22a662b374b54a50f086fc2c7bcfce8a0c240e81
Reviewed-on: https://chromium-review.googlesource.com/776793
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517368}
[modify] https://crrev.com/121a6e2583225ebe4f435827fcdcb4580f16d947/ui/compositor/layer_unittest.cc

Labels: OS-Linux
Just saw this flake on Linux, here:
https://ci.chromium.org/buildbot/tryserver.chromium.linux/linux_chromium_tsan_rel_ng/289659

[ RUN      ] LayerWithRealCompositorTest.CompositorObservers
../../ui/compositor/layer_unittest.cc:1480: Failure
Value of: observer.notified()
  Actual: false
Expected: true
[26952:26971:0413/170533.671897:11105165847:ERROR:gl_context_virtual.cc(39)] Trying to make virtual context current without decoder.
[26952:26971:0413/170533.676080:11105170031:ERROR:gl_context_virtual.cc(39)] Trying to make virtual context current without decoder.
[  FAILED  ] LayerWithRealCompositorTest.CompositorObservers (1789 ms)
[142/210] LayerWithRealCompositorTest.CompositorObservers (1789 ms)

Comment 8 by danakj@chromium.org, Apr 19 2018

Cc: danakj@chromium.org
 Issue 834026  has been merged into this issue.

Comment 9 by danakj@chromium.org, Apr 19 2018

Owner: ----
Status: Available (was: Assigned)
This was written in https://chromium.googlesource.com/chromium/src/+/05fab8dc892f2eaebc9a176ffe228c5754dff18f by vollick and modified in https://chromium.googlesource.com/chromium/src/+/b14cc10ccf83caad627156403239fc6758c2dbbb%5E%21/ui/compositor/layer_unittest.cc by staraz from WaitForDraw to WaitForSwap.

staraz is no longer on the team.
Labels: Hotlist-DesktopUIToolingRequired Hotlist-DesktopUIChecked
**UI Mass Triage**

Sign in to add a comment