Issue metadata
Sign in to add a comment
|
blink_perf.canvas/draw-{static,dynamic}-canvas-2d-to-hw-accelerated-canvas-2d.html in blink_perf.canvas failing on multiple builders |
||||||||||||||||||
Issue descriptionblink_perf.canvas/draw-static-canvas-2d-to-hw-accelerated-canvas-2d.html in blink_perf.canvas failing on multiple builders Builders failed on: - Android Nexus5 Perf: https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5%20Perf - Android Nexus5X Perf: https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5X%20Perf - Android Nexus5X WebView Perf: https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5X%20WebView%20Perf Going to launch a bisect and disable the stories on Android 5, 5X, and WebView.
,
Nov 13 2017
=== Auto-CCing suspected CL author chrome-release-bot@chromium.org === Hi chrome-release-bot@chromium.org, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Test failure found with culprit Suspected Commit Author : chrome-release-bot Commit : 84767d03e6728d949f8d4fbbd8d55a0aeaf218a0 Date : Thu Nov 09 04:08:29 2017 Subject: Updating trunk VERSION from 3263.0 to 3264.0 Bisect Details Configuration: android_nexus5_perf_bisect Benchmark : blink_perf.canvas Metric : draw-dynamic-canvas-2d-to-hw-accelerated-canvas-2d/draw-dynamic-canvas-2d-to-hw-accelerated-canvas-2d.html Revision Exit Code N chromium@514974 0 +- N/A 2 good chromium@515033 0 +- N/A 2 good chromium@515063 0 +- N/A 2 good chromium@515078 0 +- N/A 2 good chromium@515085 0 +- N/A 2 good chromium@515089 0 +- N/A 2 good chromium@515091 0 +- N/A 2 good chromium@515092 1 +- N/A 2 bad <-- Please refer to the following doc on diagnosing blink_perf regressions: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/benchmark_harnesses/blink_perf.md To Run This Test src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=draw.dynamic.canvas.2d.to.hw.accelerated.canvas.2d.html blink_perf.canvas More information on addressing performance regressions: http://g.co/ChromePerformanceRegressions Debug information about this bisect: https://chromeperf.appspot.com/buildbucket_job_status/8963007292876333584 For feedback, file a bug with component Speed>Bisection
,
Nov 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/99918e59e68bf8d97c1e0ffdc92aca8ef264a4bc commit 99918e59e68bf8d97c1e0ffdc92aca8ef264a4bc Author: Charlie Andrews <charliea@chromium.org> Date: Mon Nov 13 23:19:24 2017 Disable several failing stories in blink_perf.canvas TBR=nednguyen@google.com, junov@chromium.org Bug: 784540 Change-Id: Ie82891952ed92ca920d2e14c42b7bc1520068310 Reviewed-on: https://chromium-review.googlesource.com/767288 Reviewed-by: Charlie Andrews <charliea@chromium.org> Commit-Queue: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#516091} [modify] https://crrev.com/99918e59e68bf8d97c1e0ffdc92aca8ef264a4bc/tools/perf/benchmarks/blink_perf.py
,
Nov 15 2017
Alex, it looks like your updating of the trunk version is causing crashes in our blink_perf.canvas Telemetry tests. Do you know what the right course of action here is? Do we not care about these tests, meaning that they should be deleted? Or should the trunk version be rolled back?
,
Nov 15 2017
The bump to the VERSION file should have 0 impact on tests in any capacity, and if it does, then those tests are written incorrectly. Literally the only thing that's used for is in setting the version number for a given build. So, you either need to reach out to the test owners in case it's an issue in their tests, or reach out to the perf bisect team to figure out why this CL got blamed erroneously. Let me know if you really think this CL is to blame, though...
,
Nov 15 2017
Also meant to note - we should not be reverting bumps to VERSION files, ever, otherwise you'd attempt to force Chrome to build the same version twice, which would be bad.
,
Nov 15 2017
That makes sense. Thanks Alex. I'm going to rerun the bisect and, if it turns up the same thing, dig deeper into what's going on.
,
Nov 15 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8962838483337365920
,
Nov 15 2017
=== BISECT JOB RESULTS === Test failure found with culprit Suspected Commit Author : chrome-release-bot Commit : 84767d03e6728d949f8d4fbbd8d55a0aeaf218a0 Date : Thu Nov 09 04:08:29 2017 Subject: Updating trunk VERSION from 3263.0 to 3264.0 Bisect Details Configuration: android_nexus5_perf_bisect Benchmark : blink_perf.canvas Metric : draw-dynamic-canvas-2d-to-hw-accelerated-canvas-2d/draw-dynamic-canvas-2d-to-hw-accelerated-canvas-2d.html Revision Exit Code N chromium@514974 0 +- N/A 2 good chromium@515033 0 +- N/A 2 good chromium@515063 0 +- N/A 2 good chromium@515078 0 +- N/A 2 good chromium@515085 0 +- N/A 2 good chromium@515089 0 +- N/A 2 good chromium@515091 0 +- N/A 2 good chromium@515092 1 +- N/A 2 bad <-- Please refer to the following doc on diagnosing blink_perf regressions: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/benchmark_harnesses/blink_perf.md To Run This Test src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=draw.dynamic.canvas.2d.to.hw.accelerated.canvas.2d.html blink_perf.canvas More information on addressing performance regressions: http://g.co/ChromePerformanceRegressions Debug information about this bisect: https://chromeperf.appspot.com/buildbucket_job_status/8962838483337365920 For feedback, file a bug with component Speed>Bisection
,
Nov 15 2017
junov@, I have absolutely no idea why this test failure would bisect to an update of the Chrome VERSION files. Any ideas?
,
Nov 16 2017
Due to a bug (https://github.com/catapult-project/catapult/issues/4045), these are still failing on 5X webview. I'm sending through a CL to disable them there now.
,
Nov 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d0c9cacb91ac27fcf7f72ebf469fd6099ef0deef commit d0c9cacb91ac27fcf7f72ebf469fd6099ef0deef Author: Charlie Andrews <charliea@chromium.org> Date: Thu Nov 16 18:53:26 2017 Disable failing blink_perf.canvas stories on Webview too Even though they're failing on 5X webview and they're disabled on 5X, there's a bug where 5X webview isn't matching the 5X test condition (https://github.com/catapult-project/catapult/issues/4045). TBR=ashleymarie@chromium.org NOTRY=true Bug: 784540 Change-Id: I100929183b15c1d84ff4e0cecddb15236644bb84 Reviewed-on: https://chromium-review.googlesource.com/775433 Reviewed-by: Charlie Andrews <charliea@chromium.org> Commit-Queue: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#517137} [modify] https://crrev.com/d0c9cacb91ac27fcf7f72ebf469fd6099ef0deef/tools/perf/benchmarks/blink_perf.py
,
Nov 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d0c58e4fe501c6bb0fd9ac5236cdf159712d0059 commit d0c58e4fe501c6bb0fd9ac5236cdf159712d0059 Author: rnephew <rnephew@chromium.org> Date: Fri Nov 17 17:41:01 2017 Revert "Disable failing blink_perf.canvas stories on Webview too" This reverts commit d0c9cacb91ac27fcf7f72ebf469fd6099ef0deef. Reason for revert: 5X AOSP bug is fixed and rolled. https://chromium-review.googlesource.com/c/chromium/src/+/776353 Original change's description: > Disable failing blink_perf.canvas stories on Webview too > > Even though they're failing on 5X webview and they're disabled on 5X, > there's a bug where 5X webview isn't matching the 5X test condition > (https://github.com/catapult-project/catapult/issues/4045). > > TBR=ashleymarie@chromium.org > NOTRY=true > > Bug: 784540 > Change-Id: I100929183b15c1d84ff4e0cecddb15236644bb84 > Reviewed-on: https://chromium-review.googlesource.com/775433 > Reviewed-by: Charlie Andrews <charliea@chromium.org> > Commit-Queue: Charlie Andrews <charliea@chromium.org> > Cr-Commit-Position: refs/heads/master@{#517137} TBR=charliea@chromium.org,ashleymarie@chromium.org Change-Id: Ib48acc82b6fb1b2a1e3aa3c4f3966456cf88103f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 784540 Reviewed-on: https://chromium-review.googlesource.com/777060 Reviewed-by: rnephew <rnephew@chromium.org> Commit-Queue: rnephew <rnephew@chromium.org> Cr-Commit-Position: refs/heads/master@{#517457} [modify] https://crrev.com/d0c58e4fe501c6bb0fd9ac5236cdf159712d0059/tools/perf/benchmarks/blink_perf.py
,
Nov 22 2017
The NextAction date has arrived: 2017-11-22
,
Jul 25
,
Jan 11
Setting defect without priority to Pri-2. |
|||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Nov 13 2017