Tab attention indicator is outside of the tab if it doesn't have a favicon |
||
Issue description
Chrome Version: 64.0.3264.0
OS: macOS 10.12.6
What steps will reproduce the problem?
(1) Open a tab that doesn't have a favicon at all. (Could this just be the NTP?)
(2) Run this in the console: setTimeout(() => { alert('foo'); }, 1000)
(3) Immediately switch tabs, wait.
What is the expected result?
A dot appears… somewhere on the tab? Or not at all.
What happens instead?
Part of a dot appears outside the bounds of the tab.
,
Nov 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2b8d0d511f1ba3564db11e3b5f10f492f14099f0 commit 2b8d0d511f1ba3564db11e3b5f10f492f14099f0 Author: Avi Drissman <avi@chromium.org> Date: Wed Nov 15 04:11:13 2017 Don't show an attention indicator dot if there is no favicon. BUG= 784537 TEST=as in bug Change-Id: I2c6674b735b879bad0a8bf3f188920b1f17fe15d Reviewed-on: https://chromium-review.googlesource.com/767748 Reviewed-by: Sidney San Martín <sdy@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#516591} [modify] https://crrev.com/2b8d0d511f1ba3564db11e3b5f10f492f14099f0/chrome/browser/ui/cocoa/tabs/tab_controller.mm
,
Nov 15 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by sdy@chromium.org
, Nov 13 2017