HDR not working on Chrome canary |
|||
Issue descriptionMy local HDR machine is failing to display HDR content. This is on Canary 64.0.3266.0 (Windows) Some parts are in HDR - in about:gpu it reports that the display is in HDR mode. - YouTube plays HDR video Some parts aren't in HDR - the aforementioned YouTube videos are clipped to sRGB - WCG images are clipped to sRGB A local Chromium build does not have this problem. On both builds about:flags was reset.
,
Nov 13 2017
Nope :/
,
Nov 17 2017
,
Nov 18 2017
I was assuming that something was dropped on the floor here, but that appears not to be the case -- we create the surface for HDR at https://cs.chromium.org/chromium/src/gpu/ipc/service/direct_composition_child_surface_win.cc?rcl=f810ef4a0a7693fa3c22b5f1b4e5e4c0b95ffce1&l=90 Somehow it's just not taking.
,
Nov 18 2017
The output surface is being correctly created -- I changed the final shader to amp-up the values and they are consumed correctly by the system. I suspect that we are failing to create float-16 textures.
,
Nov 18 2017
Root cause is that we do not populate in the passthrough decoder: Present here: https://cs.chromium.org/chromium/src/gpu/command_buffer/service/gles2_cmd_decoder.cc?rcl=db41d7c10a86467a7c5b62352bcf05f1a9f371d4&l=3963 Missing here: https://cs.chromium.org/chromium/src/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc?rcl=14e8a9bb81b244d39909a0f5897489fed3652365&l=1152 This is like-a-hundred-lines of copy-pasted code. I'll merge them.
,
Nov 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/58c07c7bdf1b9c9d0ebc853e96342f3376d875bf commit 58c07c7bdf1b9c9d0ebc853e96342f3376d875bf Author: Christopher Cameron <ccameron@chromium.org> Date: Tue Nov 21 21:48:32 2017 Initialize color_buffer_half_float_rgba in passthrough If HDR is requested, DCHECK that RGBA_16F is supported. R=geofflang TBR=zmo Bug: 784536 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ib775c15c8a0a0d4f89c33f408c3dede2907d49ce Reviewed-on: https://chromium-review.googlesource.com/779865 Reviewed-by: ccameron <ccameron@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#518407} [modify] https://crrev.com/58c07c7bdf1b9c9d0ebc853e96342f3376d875bf/components/viz/service/display/gl_renderer.cc [modify] https://crrev.com/58c07c7bdf1b9c9d0ebc853e96342f3376d875bf/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc
,
Dec 14 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by hubbe@chromium.org
, Nov 13 2017