Tab attention indicator gets stuck if a page with a pending dialog reloads |
||
Issue description
Chrome Version: 64.0.3264.0
OS: macOS 10.12.6
What steps will reproduce the problem?
(1) Visit about:blank.
(2) Run this in the console: setTimeout(() => { window.location.reload(); }, 2000); setTimeout(() => { alert('foo'); }, 1000)
(3) Immediately switch tabs, wait.
What is the expected result?
A dot shows up on the tab's favicon, then goes away when it reloads.
What happens instead?
A dot shows up on the tab's favicon and never goes away, even if I visit the tab. You can also trigger this by just running the alert() part in the console and then right clicking the tab to reload it.
,
Nov 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/83abf42cc8c96453d30702b7cd91553ad2e4329d commit 83abf42cc8c96453d30702b7cd91553ad2e4329d Author: Avi Drissman <avi@chromium.org> Date: Wed Nov 15 06:19:52 2017 Clear tab attention if disposing of the pending dialog. BUG= 784532 TEST=as in bug Change-Id: Idfb75b985ed74f22c7742d830d39846c36fd5266 Reviewed-on: https://chromium-review.googlesource.com/767570 Reviewed-by: Sidney San MartÃn <sdy@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#516603} [modify] https://crrev.com/83abf42cc8c96453d30702b7cd91553ad2e4329d/chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc
,
Nov 15 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by sdy@chromium.org
, Nov 13 2017