Shouldn't rewrite config.asm for arm/arm-neon atchitect
Reported by
joey...@amazon.com,
Nov 13 2017
|
|||
Issue descriptionChrome Version : 64.0.3240.0 We recently did a change for third-party ffmpeg: https://chromium.googlesource.com/chromium/third_party/ffmpeg/+/ba8c55198776e254055940020793874e68701d16%5E%21/#F4 The new change updates config.asm for win, yet there is no config.asm file for arm/arm-neon architect. So, a target_architect check should be added for arm/arm-neon architect, otherwise it would break the BuildFFmpeg method. What is the expected result? BuildFFmpeg works for arm/arm-neon architect target_arch What happens instead? BuildFFmpeg failed because config.asm file cannot be found Please provide any additional information below. Attach a screenshot if possible.
,
Nov 14 2017
As per C#0 assigning this issue. @Chris Cunningham: could you please take a look at this issue and please help us to reassign this issue to a right owner if not with respect to your change. Thanks!
,
Nov 14 2017
I think this is already been removed in latest version. I removed it since it was an unncesssary rewrite; the var wasn't used: https://cs.chromium.org/chromium/src/third_party/ffmpeg/chromium/scripts/build_ffmpeg.py
,
Nov 14 2017
Thanks for looking at this :) |
|||
►
Sign in to add a comment |
|||
Comment 1 by joey...@amazon.com
, Nov 13 2017