New issue
Advanced search Search tips

Issue 784519 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

JS TypeError for this.updateVisiblity in Print Preview

Project Member Reported by thestig@chromium.org, Nov 13 2017

Issue description

Chrome Version: r515722
OS: Mac

What steps will reproduce the problem?
(1) Launch Chromium debug build from a command line terminal
(2) Print a webpage
(3) Click "Open PDF in Preview" link on the bottom left.

There's a JS error:

"Uncaught TypeError: this.updateVisibility in not a function", source: chrome://resources/js/cr/ui/focus_outline_manager.js (46)
 

Comment 1 by dpa...@chromium.org, Nov 13 2017

Cc: -dpa...@chromium.org
Owner: dpa...@chromium.org
Status: Started (was: Untriaged)
Ah, that's probably because of https://chromium-review.googlesource.com/c/chromium/src/+/749887. Should be an easy fix.
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bca60bdd4d43aeb8cabc696d7d3c321b750f9862

commit bca60bdd4d43aeb8cabc696d7d3c321b750f9862
Author: dpapad <dpapad@chromium.org>
Date: Wed Nov 15 19:37:35 2017

WebUI: Bind callback correctly in focus_outline_manager.js

Bug:  784519 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I460e224ecdadc841afbbeba312b8c25902b7b728
Reviewed-on: https://chromium-review.googlesource.com/767154
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516786}
[modify] https://crrev.com/bca60bdd4d43aeb8cabc696d7d3c321b750f9862/ui/webui/resources/js/cr/ui/focus_outline_manager.js

Comment 3 by dpa...@chromium.org, Nov 15 2017

Status: Fixed (was: Started)

Sign in to add a comment