New issue
Advanced search Search tips

Issue 784516 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 607844



Sign in to add a comment

Change display mirroring UI settings

Project Member Reported by weidongg@chromium.org, Nov 13 2017

Issue description

Blocking: 607844
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/acbc818ed3453f11bd7d6c4420548747930da7cd

commit acbc818ed3453f11bd7d6c4420548747930da7cd
Author: Weidong Guo <weidongg@chromium.org>
Date: Tue Nov 14 22:16:29 2017

Change display mirroring UI

Changes:
1. Replace toggle button with checkbox and Use label "Mirror
<DISPLAY_NAME>".
2. Put the checkbox outside each display tab.
3. Replace display name in the Arragement with "Mirrored" when mirror
mode is on.

Specs: https://screenshot.googleplex.com/2nDXdwpsagu
Screenshot: https://screenshot.googleplex.com/QPHLPTXGCrd

BUG= 784516 

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I9cc77c11b250265ae469bcfee83efb53356af3bb
Reviewed-on: https://chromium-review.googlesource.com/767012
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516455}
[modify] https://crrev.com/acbc818ed3453f11bd7d6c4420548747930da7cd/chrome/app/settings_strings.grdp
[modify] https://crrev.com/acbc818ed3453f11bd7d6c4420548747930da7cd/chrome/browser/resources/settings/device_page/display.html
[modify] https://crrev.com/acbc818ed3453f11bd7d6c4420548747930da7cd/chrome/browser/resources/settings/device_page/display.js
[modify] https://crrev.com/acbc818ed3453f11bd7d6c4420548747930da7cd/chrome/browser/resources/settings/device_page/display_layout.html
[modify] https://crrev.com/acbc818ed3453f11bd7d6c4420548747930da7cd/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Status: Fixed (was: Assigned)

Sign in to add a comment