New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 784512 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Task

Blocking:
issue 775262
issue 776430



Sign in to add a comment

Update BigQueryHelper to expect protobuf

Project Member Reported by katthomas@chromium.org, Nov 13 2017

Issue description

We're transitioning to protobufs for event table schemas and need to update the tables. 
 
Cc: yyanagisawa@chromium.org
Status: Started (was: Assigned)
Blocking: 776430
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/01aecd1b0d1f813d00e716a608a4e22ef68ce5b4

commit 01aecd1b0d1f813d00e716a608a4e22ef68ce5b4
Author: Katie Thomas <katthomas@google.com>
Date: Sat Nov 18 00:45:28 2017

[bootstrap] update google-cloud-bigquery

And update BigQueryHelper. The new version obviates the need for insert
ids, so remove those too.

Bug:784512
Change-Id: Ia1e8c4b5226758d1aab9fc67b8fd27a702636432
Reviewed-on: https://chromium-review.googlesource.com/776006
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Katie Thomas <katthomas@google.com>

[modify] https://crrev.com/01aecd1b0d1f813d00e716a608a4e22ef68ce5b4/bootstrap/deps.pyl
[modify] https://crrev.com/01aecd1b0d1f813d00e716a608a4e22ef68ce5b4/infra/libs/bigquery/helper.py
[modify] https://crrev.com/01aecd1b0d1f813d00e716a608a4e22ef68ce5b4/infra/libs/bigquery/test/helper_test.py

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/0e1c8b0ce3e7a4004b0492d1991f3eadf51a8191

commit 0e1c8b0ce3e7a4004b0492d1991f3eadf51a8191
Author: John Budorick <jbudorick@chromium.org>
Date: Sat Nov 18 17:21:37 2017

Revert "[bootstrap] update google-cloud-bigquery"

This reverts commit 01aecd1b0d1f813d00e716a608a4e22ef68ce5b4.

Reason for revert: Sure enough, this fails tests & I have to rev infra again :/ Sorry.

Original change's description:
> [bootstrap] update google-cloud-bigquery
> 
> And update BigQueryHelper. The new version obviates the need for insert
> ids, so remove those too.
> 
> Bug:784512
> Change-Id: Ia1e8c4b5226758d1aab9fc67b8fd27a702636432
> Reviewed-on: https://chromium-review.googlesource.com/776006
> Reviewed-by: Nodir Turakulov <nodir@chromium.org>
> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
> Commit-Queue: Katie Thomas <katthomas@google.com>

TBR=iannucci@chromium.org,nodir@chromium.org,katthomas@google.com

Change-Id: I83313d86a08d5053cffbd9778d8104b1ca92354e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  784512 
Reviewed-on: https://chromium-review.googlesource.com/778130
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>

[modify] https://crrev.com/0e1c8b0ce3e7a4004b0492d1991f3eadf51a8191/bootstrap/deps.pyl
[modify] https://crrev.com/0e1c8b0ce3e7a4004b0492d1991f3eadf51a8191/infra/libs/bigquery/helper.py
[modify] https://crrev.com/0e1c8b0ce3e7a4004b0492d1991f3eadf51a8191/infra/libs/bigquery/test/helper_test.py

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/26940384ca1da7cf4ef24b201c10461442872287

commit 26940384ca1da7cf4ef24b201c10461442872287
Author: Katie Thomas <katthomas@google.com>
Date: Mon Nov 20 19:34:34 2017

[bootstrap] update google-cloud-bigquery

And update BigQueryHelper. The new version obviates the need for insert
ids, so remove those too.

Also update six, because google_cloud_api requires a newer version:
https://github.com/GoogleCloudPlatform/google-cloud-python/issues/3880

Bug:784512
Change-Id: I7404c9cc67d35fe319d9a4b9008a392296ffd9e6
Reviewed-on: https://chromium-review.googlesource.com/779942
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Katie Thomas <katthomas@google.com>

[modify] https://crrev.com/26940384ca1da7cf4ef24b201c10461442872287/bootstrap/deps.pyl
[modify] https://crrev.com/26940384ca1da7cf4ef24b201c10461442872287/infra/libs/bigquery/helper.py
[modify] https://crrev.com/26940384ca1da7cf4ef24b201c10461442872287/infra/libs/bigquery/test/helper_test.py

Project Member

Comment 6 by bugdroid1@chromium.org, Nov 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/3522bfc28a7312943103fdedb1f0b2654465e39c

commit 3522bfc28a7312943103fdedb1f0b2654465e39c
Author: Katie Thomas <katthomas@google.com>
Date: Mon Nov 20 20:52:15 2017

[bootstrap] add urllib3 package

google-cloud-bigquery needs it

Bug:784512
Change-Id: I35adb147f0a5ae236cd0499582f9f2ac32b4387e
Reviewed-on: https://chromium-review.googlesource.com/779305
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Katie Thomas <katthomas@google.com>

[modify] https://crrev.com/3522bfc28a7312943103fdedb1f0b2654465e39c/bootstrap/deps.pyl

Project Member

Comment 7 by bugdroid1@chromium.org, Nov 20 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal/+/50326e9ae48a59483cadbddb0036b07a5e482652

commit 50326e9ae48a59483cadbddb0036b07a5e482652
Author: Katie Thomas <katthomas@google.com>
Date: Mon Nov 20 22:53:30 2017

Status: Fixed (was: Started)
Project Member

Comment 10 by bugdroid1@chromium.org, Nov 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/1e8154971b63cee21b6014df61081f2e6c0b784a

commit 1e8154971b63cee21b6014df61081f2e6c0b784a
Author: Nodir Turakulov <nodir@google.com>
Date: Tue Nov 21 23:26:03 2017

[bigquery] simplify imports

Simplify imports and prepare them to be used as wheels (not assume infra.libs.)

Bug:  784512 
Change-Id: Ica4dc846a572d2f1ca141b0ee5f9e76ec0e731fd
Reviewed-on: https://chromium-review.googlesource.com/783631
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Katie Thomas <katthomas@google.com>

[modify] https://crrev.com/1e8154971b63cee21b6014df61081f2e6c0b784a/infra/libs/bigquery/__init__.py

Sign in to add a comment