New issue
Advanced search Search tips

Issue 784509 link

Starred by 5 users
Status: Available
Owner: ----
Cc:
aga...@chromium.org
rmis...@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: ----


Previous locations:
gerrit:7706


Sign in to add a comment

Enforce OWNER approval for Submit (to CQ) in Gerrit

Project Member Reported by jamescook@chromium.org, Nov 8 2017 
Many CLs require approval from multiple OWNERS before they will pass CQ. The current UI seems to highlight the "Submit to CQ" button after a single +1.

It should either wait until you have approval from the required OWNERS (which I don't think that gerrit understands) or the button shouldn't be emphasized like that.

Comment 1 by thestig@chromium.org, Nov 10 2017 

Related - the +1 button goes away after a single +1, so after the first reviewer hits +1, all the other reviewers have to "Reply -> +1".

Comment 2 by logan@google.com, Nov 13 2017

Components: -PolyGerrit
Labels: Proj-Gerrit-Migration

Comment 3 by logan@google.com, Nov 13 2017

Project: chromium
Moved issue gerrit:7706 to now be issue chromium:784509.

Comment 4 by aga...@chromium.org, Jan 3 2018

Components: Infra>Codereview>Gerrit
Labels: -Proj-Gerrit-Migration Pri-1
Status: Available (was: New)
Summary: Enforce OWNER approval for Submit (to CQ) in Gerrit (was: "Submit to CQ" should not be blue/default after a single +1)
I thought I already had a bug on file to track this, but I can't find it.

Yep, being able to enforce OWNER review in Gerrit itself, instead of during presubmit, is one of my big priorities for this year. It's even mentioned in my Q1 OKRs, though kinda as a stretch and I can't guarantee I'll get to it this quarter with so much of my time taken up with codesearch.

The second issue mentioned by thestig@ is tracked in gerrit:5625

Comment 5 by aga...@chromium.org, Jan 18 2018 

 Issue 803271  has been merged into this issue.

Comment 6 by aga...@chromium.org, Feb 14 2018

Cc: aga...@chromium.org
 Issue gerrit:8308  has been merged into this issue.
►

Sign in to add a comment