consider adding a VaapiPictureFactory |
||
Issue descriptionTesting with static factory methods is hard: https://cs.chromium.org/search/?q=VaapiPicture::CreatePicture&sq=package:chromium&type=cs instead of having a static VaapiPicture::CreatePicture(), make a VaapiPictureFactory and inject it into VaapiVideoDecodeAccelerator, so tests can override it.
,
Nov 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a46b5520de61eed4e27855f29d0764d91cb8da8c commit a46b5520de61eed4e27855f29d0764d91cb8da8c Author: Miguel Casas <mcasas@chromium.org> Date: Thu Nov 23 05:11:03 2017 vaapi: extract static methods into a VaapiPictureFactory This CL creates a new VaapiPictureFactory and moves the static methods from VaapiPicture there. VaapiVideoDecodeAccelerator, the only client of the static methods, now uses a fully owned instance. Bug: 784507 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Idbdae95d6833315524568fd1b6ecfb80d170e0b8 Reviewed-on: https://chromium-review.googlesource.com/767375 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by: Fredrik Hubinette <hubbe@chromium.org> Cr-Commit-Position: refs/heads/master@{#518853} [modify] https://crrev.com/a46b5520de61eed4e27855f29d0764d91cb8da8c/media/gpu/BUILD.gn [modify] https://crrev.com/a46b5520de61eed4e27855f29d0764d91cb8da8c/media/gpu/vaapi/vaapi_picture.cc [modify] https://crrev.com/a46b5520de61eed4e27855f29d0764d91cb8da8c/media/gpu/vaapi/vaapi_picture.h [add] https://crrev.com/a46b5520de61eed4e27855f29d0764d91cb8da8c/media/gpu/vaapi/vaapi_picture_factory.cc [add] https://crrev.com/a46b5520de61eed4e27855f29d0764d91cb8da8c/media/gpu/vaapi/vaapi_picture_factory.h [modify] https://crrev.com/a46b5520de61eed4e27855f29d0764d91cb8da8c/media/gpu/vaapi_video_decode_accelerator.cc [modify] https://crrev.com/a46b5520de61eed4e27855f29d0764d91cb8da8c/media/gpu/vaapi_video_decode_accelerator.h [modify] https://crrev.com/a46b5520de61eed4e27855f29d0764d91cb8da8c/media/gpu/vaapi_video_decode_accelerator_unittest.cc
,
Nov 23 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by mcasas@chromium.org
, Nov 13 2017