New issue
Advanced search Search tips

Issue 784506 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 784356
Owner: ----
Closed: Nov 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug-Regression



Sign in to add a comment

10.1%-12.1% regression in blink_perf.layout (fixed-grid-lots-of-stretched-data) at 515203:515435

Project Member Reported by lukasza@chromium.org, Nov 13 2017

Issue description

 Issue 784356  reported a regression in 2 benchmarks.  Let's track down the cause of the fixed-grid-lots-of-stretched-data regression using this/new bug (while focusing the old bug on the iframe-append-remove regression).
 
(I think) I have kicked off a XXX-specific bisect job at https://chromeperf.appspot.com/buildbucket_job_status/8963011947676519664
Labels: -Type-Bug Performance-Sheriff Type-Bug-Regression
s/XXX-specific/fixed-grid-lots-of-stretched-data-specific/g in #c2... :-/
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Nov 14 2017

Mergedinto: 784356
Status: Duplicate (was: Untriaged)

=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Lukasz Anforowicz
  Commit : 6b4a012891b2b9ab32b2c12fe196d8c79cae0001
  Date   : Thu Nov 09 20:41:38 2017
  Subject: Avoid restoring subframes created *dynamically*.

Bisect Details
  Configuration: winx64intel_perf_bisect
  Benchmark    : blink_perf.parser
  Metric       : iframe-append-remove/iframe-append-remove
  Change       : 10.62% | 344.40050999 -> 307.833992052

Revision             Result                  N
chromium@515202      344.401 +- 6.92488      6      good
chromium@515261      340.986 +- 4.9746       6      good
chromium@515276      344.198 +- 5.55125      6      good
chromium@515278      343.912 +- 7.92309      6      good
chromium@515279      303.898 +- 11.5379      6      bad       <--
chromium@515280      305.062 +- 10.461       6      bad
chromium@515283      302.257 +- 7.2991       6      bad
chromium@515290      302.014 +- 10.4038      6      bad
chromium@515319      308.573 +- 5.6243       6      bad
chromium@515435      307.834 +- 9.9962       6      bad

Please refer to the following doc on diagnosing blink_perf regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/speed/benchmark_harnesses/blink_perf.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.parser

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8963011947676519664


For feedback, file a bug with component Speed>Bisection

Sign in to add a comment