New issue
Advanced search Search tips

Issue 784495 link

Starred by 3 users
Status: Fixed
Owner:
jdufault@chromium.org
Closed: Sep 20
Cc:
atwilson@chromium.org
pmarko@chromium.org
agawronska@google.com
achuith@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocked on:
issue 792654
issue 792579
issue 792656
issue 792742
issue 820212
issue 866535
Blocking:
issue 787292



Sign in to add a comment

Views-based login

Project Member Reported by jdufault@chromium.org, Nov 13 2017 
High level bug for eng work specific to views-based login

Comment 1 by achuith@chromium.org, Nov 14 2017

Cc: achuith@chromium.org
Components: UI>Shell>StartScreen
Labels: -Pri-3 OS-Chrome Pri-2
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ab655714394e790818b3564f9511e3e554461bd

commit 2ab655714394e790818b3564f9511e3e554461bd
Author: Jacob Dufault <jdufault@google.com>
Date: Wed Nov 15 21:15:05 2017

cros: Add LoginDisplayHostViews and --show-views-login

Bug:  784495 
Change-Id: If8ec878df243c24545eb6857f5e488b5e87359b4
Reviewed-on: https://chromium-review.googlesource.com/753125
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516832}
[modify] https://crrev.com/2ab655714394e790818b3564f9511e3e554461bd/ash/public/cpp/ash_switches.cc
[modify] https://crrev.com/2ab655714394e790818b3564f9511e3e554461bd/ash/public/cpp/ash_switches.h
[modify] https://crrev.com/2ab655714394e790818b3564f9511e3e554461bd/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/2ab655714394e790818b3564f9511e3e554461bd/chrome/browser/chromeos/login/chrome_restart_request.cc
[add] https://crrev.com/2ab655714394e790818b3564f9511e3e554461bd/chrome/browser/chromeos/login/ui/login_display_host_views.cc
[add] https://crrev.com/2ab655714394e790818b3564f9511e3e554461bd/chrome/browser/chromeos/login/ui/login_display_host_views.h
[modify] https://crrev.com/2ab655714394e790818b3564f9511e3e554461bd/chrome/browser/chromeos/login/ui/login_display_host_webui.cc
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9907da6f88efaedf0c25c1398d2859952bafd61d

commit 9907da6f88efaedf0c25c1398d2859952bafd61d
Author: Jacob Dufault <jdufault@google.com>
Date: Wed Nov 15 21:26:59 2017

cros: Simplify LoginDisplayHostWebUi constructor.

Bug:  784495 
Change-Id: I5637b64624af37a28aa31005f9a21cb88f41098f
Reviewed-on: https://chromium-review.googlesource.com/753126
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516835}
[modify] https://crrev.com/9907da6f88efaedf0c25c1398d2859952bafd61d/chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.cc
[modify] https://crrev.com/9907da6f88efaedf0c25c1398d2859952bafd61d/chrome/browser/chromeos/login/helper.cc
[modify] https://crrev.com/9907da6f88efaedf0c25c1398d2859952bafd61d/chrome/browser/chromeos/login/helper.h
[modify] https://crrev.com/9907da6f88efaedf0c25c1398d2859952bafd61d/chrome/browser/chromeos/login/ui/login_display_host_webui.cc
[modify] https://crrev.com/9907da6f88efaedf0c25c1398d2859952bafd61d/chrome/browser/chromeos/login/ui/login_display_host_webui.h
[modify] https://crrev.com/9907da6f88efaedf0c25c1398d2859952bafd61d/chrome/browser/chromeos/login/ui/login_web_dialog.cc
[modify] https://crrev.com/9907da6f88efaedf0c25c1398d2859952bafd61d/chrome/browser/chromeos/login/ui/simple_web_view_dialog.cc
[modify] https://crrev.com/9907da6f88efaedf0c25c1398d2859952bafd61d/chrome/browser/chromeos/login/ui/user_adding_screen.cc
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ffd9b0dcdb7aa029182582512b7fb4225a991b95

commit ffd9b0dcdb7aa029182582512b7fb4225a991b95
Author: Jacob Dufault <jdufault@google.com>
Date: Wed Nov 15 23:07:16 2017

cros: Rename lock_screen.mojom to login_screen.mojom

lock_screen.mojom was primarily used for interfacing with ash/login,
which (will) contain the login, lock, and user-add UI. It is not really
ideal to name this all "login" since it is more than login, but that has
been what we've been using thus far.

Alternative names:
- ash/authentication
- ash/entry
- ash/session
- ash/session_entry

Bug:  784495 
Change-Id: I6f0830e21f785ffad899d5e72dba0fa7ef7b7ca5
Reviewed-on: https://chromium-review.googlesource.com/767032
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516875}
[modify] https://crrev.com/ffd9b0dcdb7aa029182582512b7fb4225a991b95/ash/BUILD.gn
[rename] https://crrev.com/ffd9b0dcdb7aa029182582512b7fb4225a991b95/ash/login/login_screen_controller.cc
[rename] https://crrev.com/ffd9b0dcdb7aa029182582512b7fb4225a991b95/ash/login/login_screen_controller.h
[rename] https://crrev.com/ffd9b0dcdb7aa029182582512b7fb4225a991b95/ash/login/login_screen_controller_unittest.cc
[delete] https://crrev.com/5210107a20e89a581e9dd42a7301a0a34a7aea3a/ash/login/mock_lock_screen_client.cc
[add] https://crrev.com/ffd9b0dcdb7aa029182582512b7fb4225a991b95/ash/login/mock_login_screen_client.cc
[rename] https://crrev.com/ffd9b0dcdb7aa029182582512b7fb4225a991b95/ash/login/mock_login_screen_client.h
[modify] https://crrev.com/ffd9b0dcdb7aa029182582512b7fb4225a991b95/ash/login/ui/lock_contents_view.cc
[modify] https://crrev.com/ffd9b0dcdb7aa029182582512b7fb4225a991b95/ash/login/ui/lock_debug_view.cc
[modify] https://crrev.com/ffd9b0dcdb7aa029182582512b7fb4225a991b95/ash/login/ui/lock_debug_view.h
[modify] https://crrev.com/ffd9b0dcdb7aa029182582512b7fb4225a991b95/ash/login/ui/lock_screen_sanity_unittest.cc
[modify] https://crrev.com/ffd9b0dcdb7aa029182582512b7fb4225a991b95/ash/login/ui/login_auth_user_view.cc
[modify] https://crrev.com/ffd9b0dcdb7aa029182582512b7fb4225a991b95/ash/metrics/login_metrics_recorder_unittest.cc
[modify] https://crrev.com/ffd9b0dcdb7aa029182582512b7fb4225a991b95/ash/mojo_interface_factory.cc
[modify] https://crrev.com/ffd9b0dcdb7aa029182582512b7fb4225a991b95/ash/mus/manifest.json
[modify] https://crrev.com/ffd9b0dcdb7aa029182582512b7fb4225a991b95/ash/public/interfaces/BUILD.gn
[rename] https://crrev.com/ffd9b0dcdb7aa029182582512b7fb4225a991b95/ash/public/interfaces/login_screen.mojom
[modify] https://crrev.com/ffd9b0dcdb7aa029182582512b7fb4225a991b95/ash/public/interfaces/login_user_info.mojom
[modify] https://crrev.com/ffd9b0dcdb7aa029182582512b7fb4225a991b95/ash/shelf/login_shelf_view.cc
[modify] https://crrev.com/ffd9b0dcdb7aa029182582512b7fb4225a991b95/ash/shelf/login_shelf_view_unittest.cc
[modify] https://crrev.com/ffd9b0dcdb7aa029182582512b7fb4225a991b95/ash/shell.cc
[modify] https://crrev.com/ffd9b0dcdb7aa029182582512b7fb4225a991b95/ash/shell.h
[modify] https://crrev.com/ffd9b0dcdb7aa029182582512b7fb4225a991b95/chrome/browser/chromeos/login/lock/screen_locker.cc
[modify] https://crrev.com/ffd9b0dcdb7aa029182582512b7fb4225a991b95/chrome/browser/chromeos/login/lock/views_screen_locker.cc
[modify] https://crrev.com/ffd9b0dcdb7aa029182582512b7fb4225a991b95/chrome/browser/chromeos/login/lock/views_screen_locker.h
[modify] https://crrev.com/ffd9b0dcdb7aa029182582512b7fb4225a991b95/chrome/browser/chromeos/login/screens/user_selection_screen.h
[modify] https://crrev.com/ffd9b0dcdb7aa029182582512b7fb4225a991b95/chrome/browser/chromeos/login/user_selection_screen_proxy.cc
[modify] https://crrev.com/ffd9b0dcdb7aa029182582512b7fb4225a991b95/chrome/browser/ui/BUILD.gn
[delete] https://crrev.com/5210107a20e89a581e9dd42a7301a0a34a7aea3a/chrome/browser/ui/ash/lock_screen_client.cc
[add] https://crrev.com/ffd9b0dcdb7aa029182582512b7fb4225a991b95/chrome/browser/ui/ash/login_screen_client.cc
[rename] https://crrev.com/ffd9b0dcdb7aa029182582512b7fb4225a991b95/chrome/browser/ui/ash/login_screen_client.h
[modify] https://crrev.com/ffd9b0dcdb7aa029182582512b7fb4225a991b95/chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc
[modify] https://crrev.com/ffd9b0dcdb7aa029182582512b7fb4225a991b95/chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.h
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/50a372b0c9c349c72d95e0bd7b9e17a0694b195b

commit 50a372b0c9c349c72d95e0bd7b9e17a0694b195b
Author: Tsuyoshi Horo <horo@chromium.org>
Date: Thu Nov 16 02:02:37 2017

Revert "cros: Simplify LoginDisplayHostWebUi constructor."

This reverts commit 9907da6f88efaedf0c25c1398d2859952bafd61d.

Reason for revert: Caused ASan failure.
BUG:785608

Original change's description:
> cros: Simplify LoginDisplayHostWebUi constructor.
> 
> Bug:  784495 
> Change-Id: I5637b64624af37a28aa31005f9a21cb88f41098f
> Reviewed-on: https://chromium-review.googlesource.com/753126
> Commit-Queue: Jacob Dufault <jdufault@chromium.org>
> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#516835}

TBR=achuith@chromium.org,jdufault@chromium.org

Change-Id: I24bdf4485ca2002d26a8fbf7e03b9d167d371ea9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  784495 
Reviewed-on: https://chromium-review.googlesource.com/773858
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516953}
[modify] https://crrev.com/50a372b0c9c349c72d95e0bd7b9e17a0694b195b/chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.cc
[modify] https://crrev.com/50a372b0c9c349c72d95e0bd7b9e17a0694b195b/chrome/browser/chromeos/login/helper.cc
[modify] https://crrev.com/50a372b0c9c349c72d95e0bd7b9e17a0694b195b/chrome/browser/chromeos/login/helper.h
[modify] https://crrev.com/50a372b0c9c349c72d95e0bd7b9e17a0694b195b/chrome/browser/chromeos/login/ui/login_display_host_webui.cc
[modify] https://crrev.com/50a372b0c9c349c72d95e0bd7b9e17a0694b195b/chrome/browser/chromeos/login/ui/login_display_host_webui.h
[modify] https://crrev.com/50a372b0c9c349c72d95e0bd7b9e17a0694b195b/chrome/browser/chromeos/login/ui/login_web_dialog.cc
[modify] https://crrev.com/50a372b0c9c349c72d95e0bd7b9e17a0694b195b/chrome/browser/chromeos/login/ui/simple_web_view_dialog.cc
[modify] https://crrev.com/50a372b0c9c349c72d95e0bd7b9e17a0694b195b/chrome/browser/chromeos/login/ui/user_adding_screen.cc

Comment 6 by agawronska@chromium.org, Nov 16 2017

Cc: agawronska@google.com
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/061ef694629a559c35ac56168e02915899a4a0e0

commit 061ef694629a559c35ac56168e02915899a4a0e0
Author: Jacob Dufault <jdufault@google.com>
Date: Tue Dec 05 22:14:06 2017

cros: Rename WebUILoginDisplay to LoginDisplayWebUI

This is more consistent.

Bug:  784495 
Change-Id: I39bdff1cf126d6d3abf245620ce3c803d382db34
Reviewed-on: https://chromium-review.googlesource.com/806644
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521855}
[modify] https://crrev.com/061ef694629a559c35ac56168e02915899a4a0e0/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/061ef694629a559c35ac56168e02915899a4a0e0/chrome/browser/chromeos/login/lock/webui_screen_locker.cc
[modify] https://crrev.com/061ef694629a559c35ac56168e02915899a4a0e0/chrome/browser/chromeos/login/lock/webui_screen_locker.h
[modify] https://crrev.com/061ef694629a559c35ac56168e02915899a4a0e0/chrome/browser/chromeos/login/login_utils_browsertest.cc
[modify] https://crrev.com/061ef694629a559c35ac56168e02915899a4a0e0/chrome/browser/chromeos/login/oobe_browsertest.cc
[modify] https://crrev.com/061ef694629a559c35ac56168e02915899a4a0e0/chrome/browser/chromeos/login/saml/saml_browsertest.cc
[modify] https://crrev.com/061ef694629a559c35ac56168e02915899a4a0e0/chrome/browser/chromeos/login/session/chrome_session_manager_browsertest.cc
[modify] https://crrev.com/061ef694629a559c35ac56168e02915899a4a0e0/chrome/browser/chromeos/login/test/oobe_base_test.cc
[modify] https://crrev.com/061ef694629a559c35ac56168e02915899a4a0e0/chrome/browser/chromeos/login/test/oobe_base_test.h
[modify] https://crrev.com/061ef694629a559c35ac56168e02915899a4a0e0/chrome/browser/chromeos/login/ui/login_display_host_webui.cc
[modify] https://crrev.com/061ef694629a559c35ac56168e02915899a4a0e0/chrome/browser/chromeos/login/ui/login_display_host_webui.h
[rename] https://crrev.com/061ef694629a559c35ac56168e02915899a4a0e0/chrome/browser/chromeos/login/ui/login_display_webui.cc
[rename] https://crrev.com/061ef694629a559c35ac56168e02915899a4a0e0/chrome/browser/chromeos/login/ui/login_display_webui.h
[modify] https://crrev.com/061ef694629a559c35ac56168e02915899a4a0e0/chrome/browser/chromeos/login/ui/webui_login_view.cc
[modify] https://crrev.com/061ef694629a559c35ac56168e02915899a4a0e0/chrome/browser/chromeos/login/webview_login_browsertest.cc
[modify] https://crrev.com/061ef694629a559c35ac56168e02915899a4a0e0/chrome/browser/chromeos/policy/blocking_login_browsertest.cc
[modify] https://crrev.com/061ef694629a559c35ac56168e02915899a4a0e0/chrome/browser/chromeos/policy/login_policy_test_base.cc
[modify] https://crrev.com/061ef694629a559c35ac56168e02915899a4a0e0/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_browsertest.cc
[modify] https://crrev.com/061ef694629a559c35ac56168e02915899a4a0e0/chrome/browser/ui/webui/chromeos/login/eula_screen_handler.cc
[modify] https://crrev.com/061ef694629a559c35ac56168e02915899a4a0e0/chrome/browser/ui/webui/chromeos/login/network_dropdown_handler.cc
[modify] https://crrev.com/061ef694629a559c35ac56168e02915899a4a0e0/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
[modify] https://crrev.com/061ef694629a559c35ac56168e02915899a4a0e0/chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.cc
Project Member

Comment 9 by bugdroid1@chromium.org, Dec 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/957e092894edadd2f28c75b3ef0ea9a37cc8f13a

commit 957e092894edadd2f28c75b3ef0ea9a37cc8f13a
Author: Jacob Dufault <jdufault@google.com>
Date: Wed Dec 06 19:16:09 2017

cros: Basic views-based login screen.

The views-based login screen shows the users on the device and the
basic login flow works, but lots of additional features, such as
registering a new user, do not work yet.

Bug:  784495 
Change-Id: I67ee83d1ca84fedf465882a90e6be47e6b079967
Reviewed-on: https://chromium-review.googlesource.com/767647
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522156}
[modify] https://crrev.com/957e092894edadd2f28c75b3ef0ea9a37cc8f13a/ash/login/login_screen_controller.cc
[modify] https://crrev.com/957e092894edadd2f28c75b3ef0ea9a37cc8f13a/ash/login/login_screen_controller.h
[modify] https://crrev.com/957e092894edadd2f28c75b3ef0ea9a37cc8f13a/ash/login/login_screen_controller_unittest.cc
[modify] https://crrev.com/957e092894edadd2f28c75b3ef0ea9a37cc8f13a/ash/login/ui/lock_screen.cc
[modify] https://crrev.com/957e092894edadd2f28c75b3ef0ea9a37cc8f13a/ash/login/ui/lock_screen.h
[modify] https://crrev.com/957e092894edadd2f28c75b3ef0ea9a37cc8f13a/ash/public/interfaces/login_screen.mojom
[modify] https://crrev.com/957e092894edadd2f28c75b3ef0ea9a37cc8f13a/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/957e092894edadd2f28c75b3ef0ea9a37cc8f13a/chrome/browser/chromeos/arc/arc_session_manager_unittest.cc
[modify] https://crrev.com/957e092894edadd2f28c75b3ef0ea9a37cc8f13a/chrome/browser/chromeos/login/auth/auth_prewarmer.cc
[modify] https://crrev.com/957e092894edadd2f28c75b3ef0ea9a37cc8f13a/chrome/browser/chromeos/login/auth/auth_prewarmer.h
[modify] https://crrev.com/957e092894edadd2f28c75b3ef0ea9a37cc8f13a/chrome/browser/chromeos/login/ui/login_display_host.cc
[modify] https://crrev.com/957e092894edadd2f28c75b3ef0ea9a37cc8f13a/chrome/browser/chromeos/login/ui/login_display_host.h
[modify] https://crrev.com/957e092894edadd2f28c75b3ef0ea9a37cc8f13a/chrome/browser/chromeos/login/ui/login_display_host_views.cc
[modify] https://crrev.com/957e092894edadd2f28c75b3ef0ea9a37cc8f13a/chrome/browser/chromeos/login/ui/login_display_host_views.h
[modify] https://crrev.com/957e092894edadd2f28c75b3ef0ea9a37cc8f13a/chrome/browser/chromeos/login/ui/login_display_host_webui.cc
[modify] https://crrev.com/957e092894edadd2f28c75b3ef0ea9a37cc8f13a/chrome/browser/chromeos/login/ui/login_display_host_webui.h
[add] https://crrev.com/957e092894edadd2f28c75b3ef0ea9a37cc8f13a/chrome/browser/chromeos/login/ui/login_display_views.cc
[add] https://crrev.com/957e092894edadd2f28c75b3ef0ea9a37cc8f13a/chrome/browser/chromeos/login/ui/login_display_views.h
[modify] https://crrev.com/957e092894edadd2f28c75b3ef0ea9a37cc8f13a/chrome/browser/chromeos/login/ui/mock_login_display_host.h
[modify] https://crrev.com/957e092894edadd2f28c75b3ef0ea9a37cc8f13a/chrome/browser/ui/ash/login_screen_client.cc
[modify] https://crrev.com/957e092894edadd2f28c75b3ef0ea9a37cc8f13a/chrome/browser/ui/ash/login_screen_client.h

Comment 10 by jdufault@chromium.org, Dec 6 2017

Blockedon: 792654

Comment 11 by jdufault@chromium.org, Dec 6 2017

Blockedon: 792579

Comment 12 by jdufault@chromium.org, Dec 6 2017

Blockedon: 792656

Comment 13 by jdufault@chromium.org, Dec 7 2017

Blockedon: 792742
Project Member

Comment 14 by bugdroid1@chromium.org, Dec 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd6e47f9c1e2462aaf0b6ac287da41ddbb264d7f

commit fd6e47f9c1e2462aaf0b6ac287da41ddbb264d7f
Author: Jacob Dufault <jdufault@google.com>
Date: Thu Dec 07 23:08:52 2017

cros: Move DemoAppLauncher to LoginDisplayHost from LoginDisplayHostWebUI.

Bug:  784495 
Change-Id: I4924b538c37bfc1ba1aaf797c94377d47455eac2
Reviewed-on: https://chromium-review.googlesource.com/809239
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522597}
[modify] https://crrev.com/fd6e47f9c1e2462aaf0b6ac287da41ddbb264d7f/chrome/browser/chromeos/arc/arc_session_manager_unittest.cc
[modify] https://crrev.com/fd6e47f9c1e2462aaf0b6ac287da41ddbb264d7f/chrome/browser/chromeos/login/ui/login_display_host.cc
[modify] https://crrev.com/fd6e47f9c1e2462aaf0b6ac287da41ddbb264d7f/chrome/browser/chromeos/login/ui/login_display_host.h
[modify] https://crrev.com/fd6e47f9c1e2462aaf0b6ac287da41ddbb264d7f/chrome/browser/chromeos/login/ui/login_display_host_views.cc
[modify] https://crrev.com/fd6e47f9c1e2462aaf0b6ac287da41ddbb264d7f/chrome/browser/chromeos/login/ui/login_display_host_views.h
[modify] https://crrev.com/fd6e47f9c1e2462aaf0b6ac287da41ddbb264d7f/chrome/browser/chromeos/login/ui/login_display_host_webui.cc
[modify] https://crrev.com/fd6e47f9c1e2462aaf0b6ac287da41ddbb264d7f/chrome/browser/chromeos/login/ui/login_display_host_webui.h
Project Member

Comment 15 by bugdroid1@chromium.org, Dec 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a7643c3ef99521f32ee0072c2c72d0d8237a14b

commit 5a7643c3ef99521f32ee0072c2c72d0d8237a14b
Author: Jacob Dufault <jdufault@google.com>
Date: Tue Dec 19 20:48:41 2017

cros: Give LoginShelfView a name.

Makes using tooling easier, especially w.r.t. accessibility.

Bug:  784495 
Change-Id: Icbe712f562cc8fb9546645b6254ac7d6625fecdc
Reviewed-on: https://chromium-review.googlesource.com/834789
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525137}
[modify] https://crrev.com/5a7643c3ef99521f32ee0072c2c72d0d8237a14b/ash/shelf/login_shelf_view.cc
[modify] https://crrev.com/5a7643c3ef99521f32ee0072c2c72d0d8237a14b/ash/shelf/login_shelf_view.h
Project Member

Comment 16 by bugdroid1@chromium.org, Jan 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/494918f18bfcc36f428f2ee0d3fde61761305a87

commit 494918f18bfcc36f428f2ee0d3fde61761305a87
Author: Jacob Dufault <jdufault@google.com>
Date: Thu Jan 18 22:34:50 2018

cros: Port StartArcKiosk to LoginDisplayHost.

Bug:  784495 
Change-Id: If58401246ba905279624805b31b866ad93b0ec62
Reviewed-on: https://chromium-review.googlesource.com/824915
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530307}
[modify] https://crrev.com/494918f18bfcc36f428f2ee0d3fde61761305a87/chrome/browser/chromeos/arc/arc_session_manager_unittest.cc
[modify] https://crrev.com/494918f18bfcc36f428f2ee0d3fde61761305a87/chrome/browser/chromeos/login/ui/login_display_host.cc
[modify] https://crrev.com/494918f18bfcc36f428f2ee0d3fde61761305a87/chrome/browser/chromeos/login/ui/login_display_host.h
[modify] https://crrev.com/494918f18bfcc36f428f2ee0d3fde61761305a87/chrome/browser/chromeos/login/ui/login_display_host_views.cc
[modify] https://crrev.com/494918f18bfcc36f428f2ee0d3fde61761305a87/chrome/browser/chromeos/login/ui/login_display_host_views.h
[modify] https://crrev.com/494918f18bfcc36f428f2ee0d3fde61761305a87/chrome/browser/chromeos/login/ui/login_display_host_webui.cc
[modify] https://crrev.com/494918f18bfcc36f428f2ee0d3fde61761305a87/chrome/browser/chromeos/login/ui/login_display_host_webui.h
[modify] https://crrev.com/494918f18bfcc36f428f2ee0d3fde61761305a87/chrome/browser/chromeos/login/ui/mock_login_display_host.h
Project Member

Comment 18 by bugdroid1@chromium.org, Feb 1 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9710786ec4abf96bf5d35d08c782b67164dd665

commit c9710786ec4abf96bf5d35d08c782b67164dd665
Author: Jacob Dufault <jdufault@google.com>
Date: Thu Feb 01 00:14:36 2018

cros: Introduce LoginDisplayHostCommon.

There are a couple of reasons to have a separate interface and common
implementation:

- Clear interface
- MockLoginDisplayHost needs pure virtual functions
- MockLoginDisplayHost started to run LoginDisplayHost ctor
initialization code which breaks tests

LoginDisplayHost still maintains the single global instance (instead of
LoginDisplayHostCommon).

Inheritance tree:

                           LoginDisplayHost
                             /         \
            LoginDisplayHostCommon  MockLoginDisplayHost
                /           \
  LoginDisplayHostViews  LoginDisplayHostWebUI

Bug:  784495 
Change-Id: Iafa435d8773a7780d041881f43aca18395536bec
Reviewed-on: https://chromium-review.googlesource.com/881925
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533483}
[modify] https://crrev.com/c9710786ec4abf96bf5d35d08c782b67164dd665/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/c9710786ec4abf96bf5d35d08c782b67164dd665/chrome/browser/chromeos/arc/arc_session_manager_unittest.cc
[modify] https://crrev.com/c9710786ec4abf96bf5d35d08c782b67164dd665/chrome/browser/chromeos/login/ui/login_display_host.cc
[modify] https://crrev.com/c9710786ec4abf96bf5d35d08c782b67164dd665/chrome/browser/chromeos/login/ui/login_display_host.h
[add] https://crrev.com/c9710786ec4abf96bf5d35d08c782b67164dd665/chrome/browser/chromeos/login/ui/login_display_host_common.cc
[add] https://crrev.com/c9710786ec4abf96bf5d35d08c782b67164dd665/chrome/browser/chromeos/login/ui/login_display_host_common.h
[modify] https://crrev.com/c9710786ec4abf96bf5d35d08c782b67164dd665/chrome/browser/chromeos/login/ui/login_display_host_views.h
[modify] https://crrev.com/c9710786ec4abf96bf5d35d08c782b67164dd665/chrome/browser/chromeos/login/ui/login_display_host_webui.h
[modify] https://crrev.com/c9710786ec4abf96bf5d35d08c782b67164dd665/chrome/browser/chromeos/login/ui/mock_login_display_host.h
[modify] https://crrev.com/c9710786ec4abf96bf5d35d08c782b67164dd665/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
Project Member

Comment 19 by bugdroid1@chromium.org, Feb 1 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b6f02826cf326f74f46eef9d145b907198c2ff3

commit 9b6f02826cf326f74f46eef9d145b907198c2ff3
Author: Balazs Engedy <engedy@chromium.org>
Date: Thu Feb 01 11:23:04 2018

Revert "cros: Introduce LoginDisplayHostCommon."

This reverts commit c9710786ec4abf96bf5d35d08c782b67164dd665.

Reason for revert: Causes the following browser_tests to segfault on Chromium OS ASAN/LSAN builders:

WebviewLoginTest.AllowNewUser
WebviewLoginTest.EmailPrefill
WizardControllerCellularFirstTest.CellularFirstFlow
WizardControllerFlowTest.ControlFlowMain

https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20(1)/25959

https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.memory%2FLinux_Chromium_OS_ASan_LSan_Tests__1_%2F25959%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests%2F0%2Flogs%2FWebviewLoginTest.AllowNewUser%2F0

Original change's description:
> cros: Introduce LoginDisplayHostCommon.
> 
> There are a couple of reasons to have a separate interface and common
> implementation:
> 
> - Clear interface
> - MockLoginDisplayHost needs pure virtual functions
> - MockLoginDisplayHost started to run LoginDisplayHost ctor
> initialization code which breaks tests
> 
> LoginDisplayHost still maintains the single global instance (instead of
> LoginDisplayHostCommon).
> 
> Inheritance tree:
> 
>                            LoginDisplayHost
>                              /         \
>             LoginDisplayHostCommon  MockLoginDisplayHost
>                 /           \
>   LoginDisplayHostViews  LoginDisplayHostWebUI
> 
> Bug:  784495 
> Change-Id: Iafa435d8773a7780d041881f43aca18395536bec
> Reviewed-on: https://chromium-review.googlesource.com/881925
> Commit-Queue: Jacob Dufault <jdufault@chromium.org>
> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#533483}

TBR=achuith@chromium.org,jdufault@chromium.org

Change-Id: I5ef2e3082ffa4b03da81e59fe3c256feba60c1e3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  784495 
Reviewed-on: https://chromium-review.googlesource.com/897662
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533637}
[modify] https://crrev.com/9b6f02826cf326f74f46eef9d145b907198c2ff3/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/9b6f02826cf326f74f46eef9d145b907198c2ff3/chrome/browser/chromeos/arc/arc_session_manager_unittest.cc
[modify] https://crrev.com/9b6f02826cf326f74f46eef9d145b907198c2ff3/chrome/browser/chromeos/login/ui/login_display_host.cc
[modify] https://crrev.com/9b6f02826cf326f74f46eef9d145b907198c2ff3/chrome/browser/chromeos/login/ui/login_display_host.h
[delete] https://crrev.com/293e035df5adb1496e7151869c219b50a75e8387/chrome/browser/chromeos/login/ui/login_display_host_common.cc
[delete] https://crrev.com/293e035df5adb1496e7151869c219b50a75e8387/chrome/browser/chromeos/login/ui/login_display_host_common.h
[modify] https://crrev.com/9b6f02826cf326f74f46eef9d145b907198c2ff3/chrome/browser/chromeos/login/ui/login_display_host_views.h
[modify] https://crrev.com/9b6f02826cf326f74f46eef9d145b907198c2ff3/chrome/browser/chromeos/login/ui/login_display_host_webui.h
[modify] https://crrev.com/9b6f02826cf326f74f46eef9d145b907198c2ff3/chrome/browser/chromeos/login/ui/mock_login_display_host.h
[modify] https://crrev.com/9b6f02826cf326f74f46eef9d145b907198c2ff3/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
Project Member

Comment 20 by bugdroid1@chromium.org, Feb 6 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab9f5bc4f18201d415f1a08eca3d685620a36f7e

commit ab9f5bc4f18201d415f1a08eca3d685620a36f7e
Author: Jacob Dufault <jdufault@google.com>
Date: Tue Feb 06 17:31:57 2018

Revert "Revert "cros: Introduce LoginDisplayHostCommon.""

Reason for original revert: Causes the following browser_tests to
segfault on Chromium OS ASAN/LSAN builders:

    WebviewLoginTest.AllowNewUser
    WebviewLoginTest.EmailPrefill
    WizardControllerCellularFirstTest.CellularFirstFlow
    WizardControllerFlowTest.ControlFlowMain

- https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20(1)/25959

Bug:  784495 
Change-Id: If19459259e6927e8e05127ebfb77472d1b1d7ddd
Reviewed-on: https://chromium-review.googlesource.com/898385
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534702}
[modify] https://crrev.com/ab9f5bc4f18201d415f1a08eca3d685620a36f7e/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/ab9f5bc4f18201d415f1a08eca3d685620a36f7e/chrome/browser/chromeos/arc/arc_session_manager_unittest.cc
[modify] https://crrev.com/ab9f5bc4f18201d415f1a08eca3d685620a36f7e/chrome/browser/chromeos/login/ui/login_display_host.cc
[modify] https://crrev.com/ab9f5bc4f18201d415f1a08eca3d685620a36f7e/chrome/browser/chromeos/login/ui/login_display_host.h
[add] https://crrev.com/ab9f5bc4f18201d415f1a08eca3d685620a36f7e/chrome/browser/chromeos/login/ui/login_display_host_common.cc
[add] https://crrev.com/ab9f5bc4f18201d415f1a08eca3d685620a36f7e/chrome/browser/chromeos/login/ui/login_display_host_common.h
[modify] https://crrev.com/ab9f5bc4f18201d415f1a08eca3d685620a36f7e/chrome/browser/chromeos/login/ui/login_display_host_views.h
[modify] https://crrev.com/ab9f5bc4f18201d415f1a08eca3d685620a36f7e/chrome/browser/chromeos/login/ui/login_display_host_webui.h
[modify] https://crrev.com/ab9f5bc4f18201d415f1a08eca3d685620a36f7e/chrome/browser/chromeos/login/ui/mock_login_display_host.h
[modify] https://crrev.com/ab9f5bc4f18201d415f1a08eca3d685620a36f7e/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc
[modify] https://crrev.com/ab9f5bc4f18201d415f1a08eca3d685620a36f7e/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
Project Member

Comment 21 by bugdroid1@chromium.org, Feb 6 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d742024d26672720f4b3786ab646702792070e84

commit d742024d26672720f4b3786ab646702792070e84
Author: Jacob Dufault <jdufault@google.com>
Date: Tue Feb 06 23:40:23 2018

cros: Move keep_alive and drag'n'drop to LoginDisplayHostCommon.

- keep_alive ensures we do not exit/shutdown.
- drag'n'drop disables drag and drop.

Bug:  784495 
Change-Id: I65525cf5065db48bc14db93af3f3b6e86bc715c7
Reviewed-on: https://chromium-review.googlesource.com/871835
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534836}
[modify] https://crrev.com/d742024d26672720f4b3786ab646702792070e84/chrome/browser/chromeos/login/ui/login_display_host_common.cc
[modify] https://crrev.com/d742024d26672720f4b3786ab646702792070e84/chrome/browser/chromeos/login/ui/login_display_host_common.h
[modify] https://crrev.com/d742024d26672720f4b3786ab646702792070e84/chrome/browser/chromeos/login/ui/login_display_host_views.cc
[modify] https://crrev.com/d742024d26672720f4b3786ab646702792070e84/chrome/browser/chromeos/login/ui/login_display_host_views.h
[modify] https://crrev.com/d742024d26672720f4b3786ab646702792070e84/chrome/browser/chromeos/login/ui/login_display_host_webui.cc
[modify] https://crrev.com/d742024d26672720f4b3786ab646702792070e84/chrome/browser/chromeos/login/ui/login_display_host_webui.h
Project Member

Comment 22 by bugdroid1@chromium.org, Feb 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0af1f458c6bd2a0defcda638af9859a2701c145e

commit 0af1f458c6bd2a0defcda638af9859a2701c145e
Author: Jacob Dufault <jdufault@google.com>
Date: Thu Feb 08 16:56:58 2018

cros: Move completion_callback_ logic to LoginDisplayHost.

Bug:  784495 
Change-Id: Ic1efd8a1ac50da37954de9b0edff92459f583dff
Reviewed-on: https://chromium-review.googlesource.com/876883
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535409}
[modify] https://crrev.com/0af1f458c6bd2a0defcda638af9859a2701c145e/chrome/browser/chromeos/login/ui/gaia_dialog_delegate.h
[modify] https://crrev.com/0af1f458c6bd2a0defcda638af9859a2701c145e/chrome/browser/chromeos/login/ui/login_display_host_common.cc
[modify] https://crrev.com/0af1f458c6bd2a0defcda638af9859a2701c145e/chrome/browser/chromeos/login/ui/login_display_host_common.h
[modify] https://crrev.com/0af1f458c6bd2a0defcda638af9859a2701c145e/chrome/browser/chromeos/login/ui/login_display_host_views.cc
[modify] https://crrev.com/0af1f458c6bd2a0defcda638af9859a2701c145e/chrome/browser/chromeos/login/ui/login_display_host_views.h
[modify] https://crrev.com/0af1f458c6bd2a0defcda638af9859a2701c145e/chrome/browser/chromeos/login/ui/login_display_host_webui.cc
[modify] https://crrev.com/0af1f458c6bd2a0defcda638af9859a2701c145e/chrome/browser/chromeos/login/ui/login_display_host_webui.h
Project Member

Comment 23 by bugdroid1@chromium.org, Feb 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d052b5c6a01353bf6a07b3962c8d7dd4adf73740

commit d052b5c6a01353bf6a07b3962c8d7dd4adf73740
Author: Jacob Dufault <jdufault@google.com>
Date: Thu Feb 08 23:56:00 2018

cros: Inline wallpaper_bounds constructor parameter for LoginDisplayHostWebUI.

Also rename LoginDisplayHostWebUI::animation_weak_ptr_factory_ to weak_factory_.

Bug:  784495 
Change-Id: Id5d1f6e1479b73239e34b67d51548652e7a2e168
Reviewed-on: https://chromium-review.googlesource.com/877180
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535578}
[modify] https://crrev.com/d052b5c6a01353bf6a07b3962c8d7dd4adf73740/chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.cc
[modify] https://crrev.com/d052b5c6a01353bf6a07b3962c8d7dd4adf73740/chrome/browser/chromeos/login/ui/login_display_host_webui.cc
[modify] https://crrev.com/d052b5c6a01353bf6a07b3962c8d7dd4adf73740/chrome/browser/chromeos/login/ui/login_display_host_webui.h
[modify] https://crrev.com/d052b5c6a01353bf6a07b3962c8d7dd4adf73740/chrome/browser/chromeos/login/ui/user_adding_screen.cc
Project Member

Comment 24 by bugdroid1@chromium.org, Feb 9 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b4b6cb0ddb7cef659314f8b629b1026a825bb38

commit 8b4b6cb0ddb7cef659314f8b629b1026a825bb38
Author: Jacob Dufault <jdufault@google.com>
Date: Fri Feb 09 23:48:58 2018

Add docs on how to run asan tests.

Bug:  784495 
Change-Id: Ia9fe03dcca374d08e708bd47c91c8eeb8484880c
Reviewed-on: https://chromium-review.googlesource.com/910034
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535887}
[add] https://crrev.com/8b4b6cb0ddb7cef659314f8b629b1026a825bb38/docs/linux_running_asan_tests.md

Comment 25 by zalcorn@chromium.org, Feb 13 2018

Blocking: 787292
Project Member

Comment 26 by bugdroid1@chromium.org, Feb 21 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aad20baa13d651187bdb56593cf63ac9bb2830ed

commit aad20baa13d651187bdb56593cf63ac9bb2830ed
Author: Jacob Dufault <jdufault@google.com>
Date: Wed Feb 21 21:36:58 2018

cros: Show oobe (not login) if eula is accepted but there are no users.

The user may still want to enterprise enroll, etc. This can happen if,
for example, CrOS shuts down or there is a crash after eula acceptance /
update check.

Also remove the ability for webui to operate in a state where it
supports views-based shelf. This is hacky and we should remove webui
header bar support entirely instead.

Bug:  784495 
Change-Id: I0d93d925a539b4438574a780017f6d9f305e8f8d
Reviewed-on: https://chromium-review.googlesource.com/902922
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538214}
[modify] https://crrev.com/aad20baa13d651187bdb56593cf63ac9bb2830ed/ash/login/ui/lock_contents_view.cc
[modify] https://crrev.com/aad20baa13d651187bdb56593cf63ac9bb2830ed/chrome/browser/chromeos/login/ui/login_display_host_webui.cc

Comment 27 by jdufault@chromium.org, Mar 8 2018

Blockedon: 820212
Project Member

Comment 28 by bugdroid1@chromium.org, Mar 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a14bfd83d6b44ff1e83ea86a259a76f4df621038

commit a14bfd83d6b44ff1e83ea86a259a76f4df621038
Author: Jacob Dufault <jdufault@google.com>
Date: Mon Mar 19 21:43:47 2018

cros: Simplify LoginScreenClient by removing a wrapper.

Bug:  784495 
Change-Id: I73564231df70b8bce3899d9695d834bde2346b73
Reviewed-on: https://chromium-review.googlesource.com/961602
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544170}
[modify] https://crrev.com/a14bfd83d6b44ff1e83ea86a259a76f4df621038/ash/login/login_screen_controller.h
[modify] https://crrev.com/a14bfd83d6b44ff1e83ea86a259a76f4df621038/chrome/browser/chromeos/login/lock/screen_locker.cc
[modify] https://crrev.com/a14bfd83d6b44ff1e83ea86a259a76f4df621038/chrome/browser/chromeos/login/lock/views_screen_locker.cc
[modify] https://crrev.com/a14bfd83d6b44ff1e83ea86a259a76f4df621038/chrome/browser/chromeos/login/ui/login_display_views.cc
[modify] https://crrev.com/a14bfd83d6b44ff1e83ea86a259a76f4df621038/chrome/browser/chromeos/login/user_selection_screen_proxy.cc
[modify] https://crrev.com/a14bfd83d6b44ff1e83ea86a259a76f4df621038/chrome/browser/extensions/api/autotest_private/autotest_private_api.cc
[modify] https://crrev.com/a14bfd83d6b44ff1e83ea86a259a76f4df621038/chrome/browser/ui/ash/login_screen_client.cc
[modify] https://crrev.com/a14bfd83d6b44ff1e83ea86a259a76f4df621038/chrome/browser/ui/ash/login_screen_client.h
Project Member

Comment 29 by bugdroid1@chromium.org, Mar 21 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76d2b41e7216407da43dc0ec1e547c0a2b286bfc

commit 76d2b41e7216407da43dc0ec1e547c0a2b286bfc
Author: Jacob Dufault <jdufault@google.com>
Date: Wed Mar 21 20:38:12 2018

cros: Force tests to use webui login.

These tests fail in views-based login since OobeBaseTest has some hard
dependencies on webui login. Refactoring OobeBaseTest will likely take
some time.

Change-Id: Ic7cac68c1e9e0d6630deacfbfdad36a3651f5e6b
BUG:  784495 
Reviewed-on: https://chromium-review.googlesource.com/957967
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544829}
[modify] https://crrev.com/76d2b41e7216407da43dc0ec1e547c0a2b286bfc/ash/ash_strings.grd
[modify] https://crrev.com/76d2b41e7216407da43dc0ec1e547c0a2b286bfc/ash/login/login_screen_controller.cc
[modify] https://crrev.com/76d2b41e7216407da43dc0ec1e547c0a2b286bfc/ash/public/cpp/ash_switches.cc
[modify] https://crrev.com/76d2b41e7216407da43dc0ec1e547c0a2b286bfc/ash/public/cpp/ash_switches.h
[modify] https://crrev.com/76d2b41e7216407da43dc0ec1e547c0a2b286bfc/ash/shelf/login_shelf_view.cc
[modify] https://crrev.com/76d2b41e7216407da43dc0ec1e547c0a2b286bfc/ash/shelf/login_shelf_view.h
[modify] https://crrev.com/76d2b41e7216407da43dc0ec1e547c0a2b286bfc/ash/shelf/shelf_widget_unittest.cc
[modify] https://crrev.com/76d2b41e7216407da43dc0ec1e547c0a2b286bfc/chrome/browser/chromeos/login/chrome_restart_request.cc
[modify] https://crrev.com/76d2b41e7216407da43dc0ec1e547c0a2b286bfc/chrome/browser/chromeos/login/login_manager_test.cc
[modify] https://crrev.com/76d2b41e7216407da43dc0ec1e547c0a2b286bfc/chrome/browser/chromeos/login/test/oobe_base_test.cc
[modify] https://crrev.com/76d2b41e7216407da43dc0ec1e547c0a2b286bfc/chrome/browser/chromeos/login/ui/login_display_host_webui.cc
[modify] https://crrev.com/76d2b41e7216407da43dc0ec1e547c0a2b286bfc/chrome/browser/chromeos/preferences_chromeos_browsertest.cc
Project Member

Comment 30 by bugdroid1@chromium.org, Mar 21 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4a06e6a26d2ca2d83df227be6298cfa21f2afd8

commit d4a06e6a26d2ca2d83df227be6298cfa21f2afd8
Author: Jacob Dufault <jdufault@google.com>
Date: Wed Mar 21 22:15:14 2018

cros: Views-login should emit login-prompt-visible.

Some autotests require this, such as login_SameSessionTwice.

Bug:  784495 
Change-Id: I140aa2824f8a536c85c8f1f7ce5bc8e06748cb55
Reviewed-on: https://chromium-review.googlesource.com/973888
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544867}
[modify] https://crrev.com/d4a06e6a26d2ca2d83df227be6298cfa21f2afd8/chrome/browser/chromeos/login/ui/login_display_views.cc
Project Member

Comment 31 by bugdroid1@chromium.org, Mar 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/589d99422222281765bcbc1a0fc14b7d16a93d5b

commit 589d99422222281765bcbc1a0fc14b7d16a93d5b
Author: Jacob Dufault <jdufault@google.com>
Date: Tue Mar 27 20:28:47 2018

cros: Refactor login_screen_controller a bit.

- Reorder class members to follow styleguide
- Move LockScreenAppsFocusObserver to LoginScreenController::Observer

I am planning on adding more methods to the observer; instead of having a
separate observer for each method it seems cleaner to have one larger observer.

Bug:  784495 
Change-Id: I7de65cbc4abae26b23a11344b0a065b73032e09d
Reviewed-on: https://chromium-review.googlesource.com/978833
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546235}
[modify] https://crrev.com/589d99422222281765bcbc1a0fc14b7d16a93d5b/ash/BUILD.gn
[delete] https://crrev.com/9437a886fd122bafbeb744542902b9c188576ee0/ash/login/lock_screen_apps_focus_observer.h
[modify] https://crrev.com/589d99422222281765bcbc1a0fc14b7d16a93d5b/ash/login/login_screen_controller.cc
[modify] https://crrev.com/589d99422222281765bcbc1a0fc14b7d16a93d5b/ash/login/login_screen_controller.h
[add] https://crrev.com/589d99422222281765bcbc1a0fc14b7d16a93d5b/ash/login/login_screen_controller_observer.cc
[add] https://crrev.com/589d99422222281765bcbc1a0fc14b7d16a93d5b/ash/login/login_screen_controller_observer.h
[modify] https://crrev.com/589d99422222281765bcbc1a0fc14b7d16a93d5b/ash/login/ui/lock_contents_view.cc
[modify] https://crrev.com/589d99422222281765bcbc1a0fc14b7d16a93d5b/ash/login/ui/lock_contents_view.h
Project Member

Comment 33 by bugdroid1@chromium.org, Apr 13 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0fbbb42cc667988f5712bfdba7855355b4e37b36

commit 0fbbb42cc667988f5712bfdba7855355b4e37b36
Author: Jacob Dufault <jdufault@google.com>
Date: Fri Apr 13 01:21:41 2018

cros: Rename browser-side login types from *Views to *Mojo.

Also rename UserSelectionScreenProxy to UserBoardViewMojo.

The backend is a mojo client; the browser-side code should not know
that the implementation is in views.

Bug:  784495 
Change-Id: I1f3933e7191a9be8f1d73720a27c747391763737
Reviewed-on: https://chromium-review.googlesource.com/1008843
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550458}
[modify] https://crrev.com/0fbbb42cc667988f5712bfdba7855355b4e37b36/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/0fbbb42cc667988f5712bfdba7855355b4e37b36/chrome/browser/chromeos/login/lock/views_screen_locker.cc
[modify] https://crrev.com/0fbbb42cc667988f5712bfdba7855355b4e37b36/chrome/browser/chromeos/login/lock/views_screen_locker.h
[modify] https://crrev.com/0fbbb42cc667988f5712bfdba7855355b4e37b36/chrome/browser/chromeos/login/ui/gaia_dialog_delegate.cc
[modify] https://crrev.com/0fbbb42cc667988f5712bfdba7855355b4e37b36/chrome/browser/chromeos/login/ui/gaia_dialog_delegate.h
[modify] https://crrev.com/0fbbb42cc667988f5712bfdba7855355b4e37b36/chrome/browser/chromeos/login/ui/login_display_host.h
[modify] https://crrev.com/0fbbb42cc667988f5712bfdba7855355b4e37b36/chrome/browser/chromeos/login/ui/login_display_host_common.h
[rename] https://crrev.com/0fbbb42cc667988f5712bfdba7855355b4e37b36/chrome/browser/chromeos/login/ui/login_display_host_mojo.cc
[rename] https://crrev.com/0fbbb42cc667988f5712bfdba7855355b4e37b36/chrome/browser/chromeos/login/ui/login_display_host_mojo.h
[modify] https://crrev.com/0fbbb42cc667988f5712bfdba7855355b4e37b36/chrome/browser/chromeos/login/ui/login_display_host_webui.cc
[add] https://crrev.com/0fbbb42cc667988f5712bfdba7855355b4e37b36/chrome/browser/chromeos/login/ui/login_display_mojo.cc
[rename] https://crrev.com/0fbbb42cc667988f5712bfdba7855355b4e37b36/chrome/browser/chromeos/login/ui/login_display_mojo.h
[delete] https://crrev.com/3688c6039d109aa4a258195545e93bf7e71959c6/chrome/browser/chromeos/login/ui/login_display_views.cc
[rename] https://crrev.com/0fbbb42cc667988f5712bfdba7855355b4e37b36/chrome/browser/chromeos/login/user_board_view_mojo.cc
[rename] https://crrev.com/0fbbb42cc667988f5712bfdba7855355b4e37b36/chrome/browser/chromeos/login/user_board_view_mojo.h
Project Member

Comment 34 by bugdroid1@chromium.org, Apr 13 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/77d75ce98710f15d84b2c510acfad778a0f23a5b

commit 77d75ce98710f15d84b2c510acfad778a0f23a5b
Author: Jacob Dufault <jdufault@google.com>
Date: Fri Apr 13 18:20:09 2018

cros: Fix avatar loaded from disk not being shown in views-login.

Bug:  784495 
Change-Id: I8a797815817b364b0dcdd5e836cad40c571cb2fa
Reviewed-on: https://chromium-review.googlesource.com/978862
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Oliver Chang <ochang@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550687}
[modify] https://crrev.com/77d75ce98710f15d84b2c510acfad778a0f23a5b/ash/display/resolution_notification_controller_unittest.cc
[modify] https://crrev.com/77d75ce98710f15d84b2c510acfad778a0f23a5b/ash/login/login_screen_controller.cc
[modify] https://crrev.com/77d75ce98710f15d84b2c510acfad778a0f23a5b/ash/login/login_screen_controller.h
[modify] https://crrev.com/77d75ce98710f15d84b2c510acfad778a0f23a5b/ash/login/login_screen_controller_observer.h
[modify] https://crrev.com/77d75ce98710f15d84b2c510acfad778a0f23a5b/ash/login/ui/lock_contents_view.cc
[modify] https://crrev.com/77d75ce98710f15d84b2c510acfad778a0f23a5b/ash/login/ui/lock_contents_view.h
[modify] https://crrev.com/77d75ce98710f15d84b2c510acfad778a0f23a5b/ash/login/ui/login_test_utils.cc
[modify] https://crrev.com/77d75ce98710f15d84b2c510acfad778a0f23a5b/ash/login/ui/login_user_view.cc
[modify] https://crrev.com/77d75ce98710f15d84b2c510acfad778a0f23a5b/ash/public/interfaces/login_screen.mojom
[modify] https://crrev.com/77d75ce98710f15d84b2c510acfad778a0f23a5b/ash/public/interfaces/user_info.mojom
[modify] https://crrev.com/77d75ce98710f15d84b2c510acfad778a0f23a5b/ash/session/test_session_controller_client.cc
[modify] https://crrev.com/77d75ce98710f15d84b2c510acfad778a0f23a5b/ash/system/unified/top_shortcuts_view.cc
[modify] https://crrev.com/77d75ce98710f15d84b2c510acfad778a0f23a5b/ash/system/user/tray_user.cc
[modify] https://crrev.com/77d75ce98710f15d84b2c510acfad778a0f23a5b/ash/system/user/tray_user_unittest.cc
[modify] https://crrev.com/77d75ce98710f15d84b2c510acfad778a0f23a5b/ash/system/user/user_card_view.cc
[modify] https://crrev.com/77d75ce98710f15d84b2c510acfad778a0f23a5b/chrome/browser/chromeos/login/screens/user_selection_screen.cc
[modify] https://crrev.com/77d75ce98710f15d84b2c510acfad778a0f23a5b/chrome/browser/chromeos/login/screens/user_selection_screen.h
[modify] https://crrev.com/77d75ce98710f15d84b2c510acfad778a0f23a5b/chrome/browser/chromeos/login/ui/login_display_mojo.cc
[modify] https://crrev.com/77d75ce98710f15d84b2c510acfad778a0f23a5b/chrome/browser/chromeos/login/ui/login_display_mojo.h
[modify] https://crrev.com/77d75ce98710f15d84b2c510acfad778a0f23a5b/chrome/browser/ui/ash/session_controller_client.cc
Project Member

Comment 35 by bugdroid1@chromium.org, Apr 13 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0a94e7a5496de18dbb860a1275cdb40e6205ab3

commit f0a94e7a5496de18dbb860a1275cdb40e6205ab3
Author: Jacob Dufault <jdufault@google.com>
Date: Fri Apr 13 18:41:28 2018

cros: Send NOTIFICATION_LOGIN_OR_LOCK_WEBUI_VISIBLE for views login/lock

It'd be better to remove the notification entirely, but there are still some
users of this notification, like accessibility and power. I suspect the correct
long-term fix is to migrate these users to session state changed observers.

Bug:  784495 
Change-Id: I5a60f4ff4010cb11e541415bea11245766dd6eeb
Reviewed-on: https://chromium-review.googlesource.com/964713
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550698}
[modify] https://crrev.com/f0a94e7a5496de18dbb860a1275cdb40e6205ab3/chrome/browser/chromeos/login/lock/screen_locker.cc
[modify] https://crrev.com/f0a94e7a5496de18dbb860a1275cdb40e6205ab3/chrome/browser/chromeos/login/ui/login_display_mojo.cc
Project Member

Comment 36 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0fbbb42cc667988f5712bfdba7855355b4e37b36

commit 0fbbb42cc667988f5712bfdba7855355b4e37b36
Author: Jacob Dufault <jdufault@google.com>
Date: Fri Apr 13 01:21:41 2018

cros: Rename browser-side login types from *Views to *Mojo.

Also rename UserSelectionScreenProxy to UserBoardViewMojo.

The backend is a mojo client; the browser-side code should not know
that the implementation is in views.

Bug:  784495 
Change-Id: I1f3933e7191a9be8f1d73720a27c747391763737
Reviewed-on: https://chromium-review.googlesource.com/1008843
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550458}
[modify] https://crrev.com/0fbbb42cc667988f5712bfdba7855355b4e37b36/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/0fbbb42cc667988f5712bfdba7855355b4e37b36/chrome/browser/chromeos/login/lock/views_screen_locker.cc
[modify] https://crrev.com/0fbbb42cc667988f5712bfdba7855355b4e37b36/chrome/browser/chromeos/login/lock/views_screen_locker.h
[modify] https://crrev.com/0fbbb42cc667988f5712bfdba7855355b4e37b36/chrome/browser/chromeos/login/ui/gaia_dialog_delegate.cc
[modify] https://crrev.com/0fbbb42cc667988f5712bfdba7855355b4e37b36/chrome/browser/chromeos/login/ui/gaia_dialog_delegate.h
[modify] https://crrev.com/0fbbb42cc667988f5712bfdba7855355b4e37b36/chrome/browser/chromeos/login/ui/login_display_host.h
[modify] https://crrev.com/0fbbb42cc667988f5712bfdba7855355b4e37b36/chrome/browser/chromeos/login/ui/login_display_host_common.h
[rename] https://crrev.com/0fbbb42cc667988f5712bfdba7855355b4e37b36/chrome/browser/chromeos/login/ui/login_display_host_mojo.cc
[rename] https://crrev.com/0fbbb42cc667988f5712bfdba7855355b4e37b36/chrome/browser/chromeos/login/ui/login_display_host_mojo.h
[modify] https://crrev.com/0fbbb42cc667988f5712bfdba7855355b4e37b36/chrome/browser/chromeos/login/ui/login_display_host_webui.cc
[add] https://crrev.com/0fbbb42cc667988f5712bfdba7855355b4e37b36/chrome/browser/chromeos/login/ui/login_display_mojo.cc
[rename] https://crrev.com/0fbbb42cc667988f5712bfdba7855355b4e37b36/chrome/browser/chromeos/login/ui/login_display_mojo.h
[delete] https://crrev.com/3688c6039d109aa4a258195545e93bf7e71959c6/chrome/browser/chromeos/login/ui/login_display_views.cc
[rename] https://crrev.com/0fbbb42cc667988f5712bfdba7855355b4e37b36/chrome/browser/chromeos/login/user_board_view_mojo.cc
[rename] https://crrev.com/0fbbb42cc667988f5712bfdba7855355b4e37b36/chrome/browser/chromeos/login/user_board_view_mojo.h
Project Member

Comment 37 by bugdroid1@chromium.org, Apr 17 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/77d75ce98710f15d84b2c510acfad778a0f23a5b

commit 77d75ce98710f15d84b2c510acfad778a0f23a5b
Author: Jacob Dufault <jdufault@google.com>
Date: Fri Apr 13 18:20:09 2018

cros: Fix avatar loaded from disk not being shown in views-login.

Bug:  784495 
Change-Id: I8a797815817b364b0dcdd5e836cad40c571cb2fa
Reviewed-on: https://chromium-review.googlesource.com/978862
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Oliver Chang <ochang@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550687}
[modify] https://crrev.com/77d75ce98710f15d84b2c510acfad778a0f23a5b/ash/display/resolution_notification_controller_unittest.cc
[modify] https://crrev.com/77d75ce98710f15d84b2c510acfad778a0f23a5b/ash/login/login_screen_controller.cc
[modify] https://crrev.com/77d75ce98710f15d84b2c510acfad778a0f23a5b/ash/login/login_screen_controller.h
[modify] https://crrev.com/77d75ce98710f15d84b2c510acfad778a0f23a5b/ash/login/login_screen_controller_observer.h
[modify] https://crrev.com/77d75ce98710f15d84b2c510acfad778a0f23a5b/ash/login/ui/lock_contents_view.cc
[modify] https://crrev.com/77d75ce98710f15d84b2c510acfad778a0f23a5b/ash/login/ui/lock_contents_view.h
[modify] https://crrev.com/77d75ce98710f15d84b2c510acfad778a0f23a5b/ash/login/ui/login_test_utils.cc
[modify] https://crrev.com/77d75ce98710f15d84b2c510acfad778a0f23a5b/ash/login/ui/login_user_view.cc
[modify] https://crrev.com/77d75ce98710f15d84b2c510acfad778a0f23a5b/ash/public/interfaces/login_screen.mojom
[modify] https://crrev.com/77d75ce98710f15d84b2c510acfad778a0f23a5b/ash/public/interfaces/user_info.mojom
[modify] https://crrev.com/77d75ce98710f15d84b2c510acfad778a0f23a5b/ash/session/test_session_controller_client.cc
[modify] https://crrev.com/77d75ce98710f15d84b2c510acfad778a0f23a5b/ash/system/unified/top_shortcuts_view.cc
[modify] https://crrev.com/77d75ce98710f15d84b2c510acfad778a0f23a5b/ash/system/user/tray_user.cc
[modify] https://crrev.com/77d75ce98710f15d84b2c510acfad778a0f23a5b/ash/system/user/tray_user_unittest.cc
[modify] https://crrev.com/77d75ce98710f15d84b2c510acfad778a0f23a5b/ash/system/user/user_card_view.cc
[modify] https://crrev.com/77d75ce98710f15d84b2c510acfad778a0f23a5b/chrome/browser/chromeos/login/screens/user_selection_screen.cc
[modify] https://crrev.com/77d75ce98710f15d84b2c510acfad778a0f23a5b/chrome/browser/chromeos/login/screens/user_selection_screen.h
[modify] https://crrev.com/77d75ce98710f15d84b2c510acfad778a0f23a5b/chrome/browser/chromeos/login/ui/login_display_mojo.cc
[modify] https://crrev.com/77d75ce98710f15d84b2c510acfad778a0f23a5b/chrome/browser/chromeos/login/ui/login_display_mojo.h
[modify] https://crrev.com/77d75ce98710f15d84b2c510acfad778a0f23a5b/chrome/browser/ui/ash/session_controller_client.cc
Project Member

Comment 38 by bugdroid1@chromium.org, Apr 17 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0a94e7a5496de18dbb860a1275cdb40e6205ab3

commit f0a94e7a5496de18dbb860a1275cdb40e6205ab3
Author: Jacob Dufault <jdufault@google.com>
Date: Fri Apr 13 18:41:28 2018

cros: Send NOTIFICATION_LOGIN_OR_LOCK_WEBUI_VISIBLE for views login/lock

It'd be better to remove the notification entirely, but there are still some
users of this notification, like accessibility and power. I suspect the correct
long-term fix is to migrate these users to session state changed observers.

Bug:  784495 
Change-Id: I5a60f4ff4010cb11e541415bea11245766dd6eeb
Reviewed-on: https://chromium-review.googlesource.com/964713
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550698}
[modify] https://crrev.com/f0a94e7a5496de18dbb860a1275cdb40e6205ab3/chrome/browser/chromeos/login/lock/screen_locker.cc
[modify] https://crrev.com/f0a94e7a5496de18dbb860a1275cdb40e6205ab3/chrome/browser/chromeos/login/ui/login_display_mojo.cc
Project Member

Comment 39 by bugdroid1@chromium.org, Apr 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76950f2c8ccc1a8dcd2de8fa8a469a13464cb79e

commit 76950f2c8ccc1a8dcd2de8fa8a469a13464cb79e
Author: Jacob Dufault <jdufault@google.com>
Date: Thu Apr 19 17:44:37 2018

cros: Enable views login

If there is a crash session manager will revert to webui. If there is a feature
missing the user can click a button on the shelf which will revert to webui.

Bug:  784495 
Change-Id: I218b5a217941dfde51d1a78080ef4d9e30ca87d2
Reviewed-on: https://chromium-review.googlesource.com/972328
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552075}
[modify] https://crrev.com/76950f2c8ccc1a8dcd2de8fa8a469a13464cb79e/ash/public/cpp/ash_switches.cc
Project Member

Comment 41 by bugdroid1@chromium.org, Jun 7 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/77f04217825a68597d00c22038ff3cb9c4f763af

commit 77f04217825a68597d00c22038ff3cb9c4f763af
Author: Jacob Dufault <jdufault@google.com>
Date: Thu Jun 07 01:19:57 2018

cros: Show gaia auth on login if user mistypes password 4 times in a row.

Bug:  784495 
Change-Id: Iced3219a6e837e5abe4ed122d32086b9bc3f961c
Reviewed-on: https://chromium-review.googlesource.com/1012575
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565132}
[modify] https://crrev.com/77f04217825a68597d00c22038ff3cb9c4f763af/ash/login/ui/lock_contents_view.cc
[modify] https://crrev.com/77f04217825a68597d00c22038ff3cb9c4f763af/ash/login/ui/lock_contents_view.h
[modify] https://crrev.com/77f04217825a68597d00c22038ff3cb9c4f763af/ash/login/ui/lock_contents_view_unittest.cc
[modify] https://crrev.com/77f04217825a68597d00c22038ff3cb9c4f763af/ash/login/ui/lock_debug_view.cc
[modify] https://crrev.com/77f04217825a68597d00c22038ff3cb9c4f763af/ash/login/ui/lock_debug_view.h
[modify] https://crrev.com/77f04217825a68597d00c22038ff3cb9c4f763af/ash/login/ui/lock_screen.cc
[modify] https://crrev.com/77f04217825a68597d00c22038ff3cb9c4f763af/ash/login/ui/lock_screen.h
[modify] https://crrev.com/77f04217825a68597d00c22038ff3cb9c4f763af/ash/login/ui/lock_screen_sanity_unittest.cc
[modify] https://crrev.com/77f04217825a68597d00c22038ff3cb9c4f763af/ash/metrics/login_metrics_recorder_unittest.cc

Comment 42 by bartfab@chromium.org, Jul 23

Blockedon: 866535

Comment 43 by jdufault@chromium.org, Sep 20

Status: Fixed (was: Started)
Marking fixed, we have since migrated to more specific bugs. Also see the LoginRefresh hotlist.

https://bugs.chromium.org/u/jdufault@chromium.org/hotlists/LoginRefresh

Comment 44 by pmarko@chromium.org, Nov 7

Cc: atwilson@chromium.org pmarko@chromium.org
BTW, do we have a tracking bug for getting rid of ash::switches::kShowWebUiLogin in browsertests?
I'm asking because while investigating a Views-based login specific bug ( bug 900323 ), I was also trying to find out why our regression test didn't trigger.
One of the reasons is that we never run this test with the LoginDisplayHostMojo being used // with ash::features::IsViewsLoginEnabled() returning true.

Comment 45 by jdufault@chromium.org, Nov 7 

I'm working on migrating tests at the moment. Issue 899777 for tracking.
►

Sign in to add a comment