Issue metadata
Sign in to add a comment
|
Compile Error macOS: error: 'FLAPPER_VERSION_STRING' macro redefined [-Werror,-Wmacro-redefined] #define FLAPPER_VERSION_STRING "27.0.0.130"
Reported by
davec.b...@gmail.com,
Nov 13 2017
|
||||||||||||||||||||||
Issue description
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.75 Safari/537.36
Steps to reproduce the problem:
1. Pull Release 62.0.3202.89 from source
2. Build
3.
What is the expected behavior?
Completed Build
What went wrong?
../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/chrome/common/common/chrome_content_client.o.d -DV8_DEPRECATION_WARNINGS -DNO_TCMALLOC -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DOFFICIAL_BUILD -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=\"310694-2\" -DCR_XCODE_VERSION=0910 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DTOOLKIT_VIEWS=1 -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DUCHAR_TYPE=uint16_t -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DHAVE_PTHREAD -DV8_USE_EXTERNAL_STARTUP_DATA -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSK_HAS_PNG_LIBRARY -DSK_HAS_WEBP_LIBRARY -DSK_HAS_JPEG_LIBRARY -DSK_SUPPORT_GPU=1 -DSK_BUILD_FOR_MAC -DMESA_EGL_NO_X11_HEADERS -I../.. -Igen -I../../third_party/libwebp/src -I../../third_party/khronos -I../../gpu -I../../third_party/ced/src -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -I../../third_party/protobuf/src -I../../third_party/libwebm/source -I../../skia/config -I../../skia/ext -I../../third_party/skia/include/c -I../../third_party/skia/include/config -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/encode -I../../third_party/skia/include/gpu -I../../third_party/skia/include/images -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pdf -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/skia/third_party/vulkan -I../../third_party/skia/include/codec -I../../third_party/skia/src/gpu -I../../third_party/skia/src/sksl -I../../third_party/protobuf/src -Igen/protoc_out -I../../third_party/boringssl/src/include -Igen -I../../third_party/WebKit -Igen/third_party/WebKit -I../../v8/include -Igen/v8/include -Igen/components/metrics/proto -I../../third_party/re2/src -I../../third_party/mesa/src/include -Igen -Igen -I../../third_party/google_toolbox_for_mac -I../../third_party/google_toolbox_for_mac/src -I../../third_party/google_toolbox_for_mac/src/AppKit -I../../third_party/google_toolbox_for_mac/src/DebugUtils -I../../third_party/google_toolbox_for_mac/src/Foundation -fno-strict-aliasing -fstack-protector -fcolor-diagnostics -arch x86_64 -Wall -Werror -Wextra -Wunguarded-availability -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -Wno-unused-lambda-capture -Wno-user-defined-warnings -Wno-enum-compare-switch -O2 -fno-omit-frame-pointer -g0 -isysroot ../../../../MacOSX-SDKs/MacOSX10.12.sdk -mmacosx-version-min=10.9.0 -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-auto-raw-pointer -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -Wexit-time-destructors -std=c++14 -stdlib=libc++ -fno-rtti -fno-exceptions -fvisibility-inlines-hidden -c ../../chrome/common/chrome_content_client.cc -o obj/chrome/common/common/chrome_content_client.o
In file included from ../../chrome/common/chrome_content_client.cc:80:
gen/flapper_version.h:18:9: error: 'FLAPPER_VERSION_STRING' macro redefined [-Werror,-Wmacro-redefined]
#define FLAPPER_VERSION_STRING "27.0.0.130"
^
gen/flapper_version.h:16:9: note: previous definition is here
#define FLAPPER_VERSION_STRING "27.0.0.183"
^
1 error generated.
Did this work before? Yes 62.0.3202.75
Chrome version: 62.0.3202.89 Channel: stable
OS Version: OS X 10.13.1
Flash Version:
,
Nov 13 2017
No, is the reporter trying to do an official build?
,
Nov 14 2017
I am trying to do an official build. is_official_build = true
,
Nov 16 2017
The issue seems to be out of TE-scope as it is related to build. Hence, adding label TE-NeedsTriageHelp for further investigation. Thanks...!!
,
Nov 16 2017
I didn't know branded builds were possible without src-internal. What are the contents of the file at src/third_party/adobe/flash/symbols/ppapi/mac_64/flapper_version.h?
,
Nov 16 2017
There is no file named flapper_version.h at src/third_party/adobe/flash/symbols/ppapi/mac_64/flapper_version.h, however a file with this name is located at src/third_party/adobe/flash/flapper_version.h, and its contents are below: // This is a stand-in for a generated file that is available when Flapper is // available. #ifndef FLAPPER_VERSION_H_INCLUDED_ #define FLAPPER_VERSION_H_INCLUDED_ // If Flapper were available, we'd define two things: // - FLAPPER_AVAILABLE (to indicate availability), and // - FLAPPER_VERSION_STRING (with the version of the Flapper that's available // as a string, e.g., "11.2.123.456"). #define FLAPPER_AVAILABLE #define FLAPPER_VERSION_STRING "27.0.0.183" #define FLAPPER_AVAILABLE #define FLAPPER_VERSION_STRING "27.0.0.183" #define FLAPPER_AVAILABLE #define FLAPPER_VERSION_STRING "27.0.0.183" #define FLAPPER_AVAILABLE #define FLAPPER_VERSION_STRING "27.0.0.130" #define FLAPPER_AVAILABLE #define FLAPPER_VERSION_STRING "27.0.0.130" #define FLAPPER_AVAILABLE #define FLAPPER_VERSION_STRING "27.0.0.130" #endif // FLAPPER_VERSION_H_INCLUDED_
,
Nov 16 2017
Well, that is the problem. I don't know how that file got to be like that: did you apply some kind of patch? What do your `git status` and `git branch -vv` say? e.g. if I do: `git fetch --tags` `git checkout -b temp tags/62.0.3202.89` `git branch -vv | grep temp` * temp ba7a0041073a Publish DEPS for Chromium 62.0.3202.89 `openssl dgst -sha256 flapper_version.h` SHA256(flapper_version.h)= 047a31a3cefadadf22cd83e8e521f936b85bcdd9e2e2d81665762d54fa13e6b3 (And I get the file with the contents listed at https://cs.chromium.org/chromium/src/third_party/adobe/flash/flapper_version.h)
,
Nov 17 2017
I apologize, I did patched that file but forgot to reset my repo.
,
Nov 17 2017
No worries, glad we figured it out! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by manoranj...@chromium.org
, Nov 13 2017Labels: Needs-Triage-M62