Address bar not updated when returning to previous webpage |
||||||||||||
Issue descriptionApp Version: 64.0.3267.0 canary iOS Version: 10.3.3, 11.2 Device: iPhone7plus, iPhoneX URL: na Steps to reproduce: 1. Launch Google Chrome 2. Search for "how to change wallpaper on iPhone automatically" in omnibox 3. Tap on the result from the website ios.gadgetjacks.com 4. Wait for the page to completely load and scroll down few pages 5. Edge swipe to navigate back to search results Observed results: Google Search results page is loaded but address bar still shows ios.gadgethack.com Expected results: Address bar should be updated correctly. Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: Not tested Bug reproducible on Safari/Firefox: Firefox:NO , Safari: No Bug reproducible on current stable build (App Version, iOS Version): M62 NO Bug reproducible on the current beta channel build (App Version, iOS Version): M63 No Link to video/image: https://drive.google.com/file/d/1c8dd895R4c_AtrxrHBdSNYa6FGgSODrI/view
,
Nov 13 2017
Assigned to eugenebut, but if srikanthg can help bisect would be helpful.
,
Nov 13 2017
Tapping back button worked fine. Only reproduced with edge-swipe. I will try to bisect tomorrow and update the bug.
,
Nov 13 2017
Assigning to Justin for Swipe to Navigate.
,
Nov 14 2017
Actually this is not a regression. I was able to reproduce this in M61 and M62 also. Also note tapping on back arrow also reproduces the issue. I am not doing any bisect since this is reproduced on M61 as well. Please let me know if you need any other information.
,
Nov 14 2017
Per comment #4 this looks like Swipe To Navigate bug.
,
Nov 14 2017
Per comment #5 not related to Swipe To Navigate. Also RBS because the bug leads to URL spoofing. Sorry for the noise.
,
Nov 15 2017
Can not reproduce with iOS 11, Chromium 64.0.3268.0. Srikanth, do you have any experiments enabled in chrome://flags?
,
Nov 15 2017
I don't have any special flags enabled other than whats available by default. I am able to repro on M63,62 also. At step#4, you don't need to scroll down the page as well. Just wait for 5~10 seconds. This websites has lots of requests loading in the background. After ~5+ seconds, tap the back arrow.
,
Nov 16 2017
I could reproduce with bug on 10.0.2 with iPhone 7 Plus (Rose Gold) using Chrome 62.0.3202.70. Perhaps OS minor version actually matters. The scary part in this bug is that webView.URL is empty inside webView:didCommitNavigation:. webView.backForwardList.currentItem.URL returns valid URL, which is probably one we should be using everywhere.
,
Nov 21 2017
,
Nov 21 2017
Filed rdar://35658290 with ios.gadgetjacks.com. It would be very hard to construct test app without referring to a real web site.
,
Nov 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4527bad8c9593b16a5ecd883510a4a4a10dcf218 commit 4527bad8c9593b16a5ecd883510a4a4a10dcf218 Author: Eugene But <eugenebut@google.com> Date: Tue Nov 21 20:10:58 2017 Use webView.backForwardList.currentItem.URL if webView.URL is nil. It is possible for WKWebView.URL to be empty inside webView:didCommitNavigation:. That's probably a bug, but WKWebView.URL does not represent last committed URL anyway, so it is safer to fallback to WKBackForwardList's currentItem when WKWebView.URL is nil. Using webView.backForwardList.currentItem.URL everywhere is not an option because that URL is not correct for WebUI pages loaded via loadHTML:. After dropping iOS 10 and switching WebUI to iOS 11's custom URL protocols it might be possible to use webView.backForwardList.currentItem.URL unconditionally. Bug: 784480 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I2c2cdb9fad425afec6756bc8e841389e979d066b Reviewed-on: https://chromium-review.googlesource.com/773621 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#518355} [modify] https://crrev.com/4527bad8c9593b16a5ecd883510a4a4a10dcf218/ios/web/web_state/ui/crw_web_controller.mm
,
Nov 21 2017
,
Nov 22 2017
,
Nov 28 2017
Verified on M64.0.3279.0 canary iPhoneX iOS11.2 beta#5 URL is correctly updated.
,
Feb 28 2018
This bug has been closed for more than 14 weeks. Removing security view restrictions. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 28 2018
per comment 12 adding hotlist label. |
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by eugene...@chromium.org
, Nov 13 2017Labels: ReleaseBlock-Stable M-64 Needs-Bisect