viz_perftests need to run on the perf bots |
|||||
Issue descriptionviz_perftests currently do not run on any of the perf bots.
,
Nov 14 2017
Part of me wonders if we should bother. We continue to run cc_perftests but also to never get any alerts worth doing anything with from them. cc_perftests are really helpful for profiling, or testing before/after with a change, but have done very little in ways of regression testing.
,
Dec 1 2017
/cc +yiyix@ I have not worked with cc_perftests a lot. So I don't have opinions whether they are useful or not for catching regressions. enne@ any thoughts on whether to run viz_perftests on the bots?
,
Apr 19 2018
Coming back to this: if cc_perftests have not been very useful for regression testing, should we turn off monitoring for these tests? Should viz_perftests also run on the bots, but not monitored for regression? As long as the tests are running on the bots, we can monitor manually for regression/improvements for particular changes. Or maybe they don't even need to run on the bots, and we can do local running to test improvement/regression? To summarize: two questions: 1. Should cc_perftests and viz_perftests run on the perf bots at all? 2. If yes, should these tests run unmonitored (like gpu_perftests)?
,
Apr 19 2018
I don't have much strong feelings besides what you've said. They're useful for local running. I don't personally use them on the bots, dunno if others do.
,
Apr 19 2018
,
Apr 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/87711633bd43436dea338b0869f5ab89c89d758d commit 87711633bd43436dea338b0869f5ab89c89d758d Author: Sadrul Habib Chowdhury <sadrul@chromium.org> Date: Fri Apr 20 19:10:30 2018 cc_perftests: Stop running on the perf bots. The tests have not been very useful, and has remain disabled on a number of bots for a while. So stop running the tests on the perf bots altogether. The tests can still be used locally to watch for improvements/regressions for specific changes as desired/needed. BUG= 784454 , 721757 , 736150 BUG= 698831 , 792995, 723821 Change-Id: Ifede89a3f7a87d96bbb726e0911e1df26e6f9a6b Reviewed-on: https://chromium-review.googlesource.com/1021653 Reviewed-by: enne <enne@chromium.org> Reviewed-by: Ned Nguyen <nednguyen@google.com> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#552422} [modify] https://crrev.com/87711633bd43436dea338b0869f5ab89c89d758d/testing/buildbot/chromium.perf.json [modify] https://crrev.com/87711633bd43436dea338b0869f5ab89c89d758d/testing/buildbot/gn_isolate_map.pyl [modify] https://crrev.com/87711633bd43436dea338b0869f5ab89c89d758d/tools/perf/benchmark.csv [modify] https://crrev.com/87711633bd43436dea338b0869f5ab89c89d758d/tools/perf/core/perf_data_generator.py
,
May 15 2018
We decided that we don't want to run these tests on the perf bots. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by sadrul@chromium.org
, Nov 13 2017