Omnibox is too wide when opening a new tab on iPhone X landscape |
|||||
Issue descriptioniPhone X only. What steps will reproduce the problem? (1) Open chrome in landscape (2) Open a NTP What is the expected result? The omnibox should be in the correct size directly. What happens instead? The omnibox is too wide. It does not take into account the safe area insets when drawing it.
,
Nov 17 2017
,
Nov 21 2017
,
Nov 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/34b0c9f166247ca3652886df178d3e8ac7eacb8a commit 34b0c9f166247ca3652886df178d3e8ac7eacb8a Author: Justin Cohen <justincohen@google.com> Date: Wed Nov 22 15:34:28 2017 [ios] Omnibox is too wide when opening a new tab on iPhone X landscape. -headerForView is regularly called before self.headerView has been added to the view hierarchy, so there's no simple way to get the correct safeAreaInsets. Since this situation is universally called for the full screen new tab animation, it's safe to check the rootViewController's view instead. Bug: 784408 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iadee7033eeb461bc4a10a28c8bd30c482afbb226 Reviewed-on: https://chromium-review.googlesource.com/780525 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#518640} [modify] https://crrev.com/34b0c9f166247ca3652886df178d3e8ac7eacb8a/ios/chrome/browser/content_suggestions/content_suggestions_header_view_controller.mm
,
Nov 22 2017
,
Nov 27 2017
Verified in 64.0.3279.0 canary, iPhone X iOS 11.2 Looks good. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by fhorschig@google.com
, Nov 17 2017