New issue
Advanced search Search tips

Issue 784404 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Feature

Blocking:
issue 787562



Sign in to add a comment

Hide the Swarming bot console window on startup

Project Member Reported by mar...@chromium.org, Nov 13 2017

Issue description

I thought about implementing in our bot_config but I think it's worth having in bot_main everywhere for consistency.

In short:

h = GetConsoleWindow()
SW_MINIMIZE = 6
ShowWindow(h, SW_MINIMIZE)
 

Comment 1 by mar...@chromium.org, Nov 14 2017

The place to inject would be at around https://cs.chromium.org/chromium/infra/luci/appengine/swarming/swarming_bot/bot_code/bot_main.py?l=813

which is far enough that the bot is not completely hosed but before requesting tasks from the server.

Greg if you have time today you can take it otherwise this will have to wait to tomorrow.

Comment 2 by grt@chromium.org, Nov 15 2017

I'm trying something like this in the test itself in https://chromium-review.googlesource.com/c/chromium/src/+/771330. I haven't yet hit a bot with the problem, but I'm continuing to rerun the tests on win7_chromium_rel_ng hoping for a jackpot.

Comment 3 by grt@chromium.org, Nov 15 2017

Jackpot! https://chromium-swarm.appspot.com/task?id=39d8301768c43510&refresh=10&show_raw=1:

[1115/030957.388:ERROR:always_on_top_window_killer_win.cc(251)] There is an always on top window on the desktop. This may have been caused by a previous test and may cause this test to fail; window class name: VMwareDragDetWndClass; owning process lineage: (process_id: 2068, command_line: ""C:\Program Files\VMware\VMware Tools\vmtoolsd.exe" -n vmusr"), (process_id: 1692, command_line: "C:\Windows\Explorer.EXE"); screen snapshot saved to file: "e:\b\swarm_slave\w\io867l_p\ss_20171115030957_327.png";
[1115/030957.389:ERROR:always_on_top_window_killer_win.cc(258)] Stripped WS_EX_TOPMOST.
[1115/030957.641:ERROR:always_on_top_window_killer_win.cc(263)] Minimized window.

Sending out for review now.

Comment 4 by hinoka@chromium.org, Nov 15 2017

Labels: -Type-Bug OS-Windows Type-Feature
Status: Available (was: Untriaged)
Summary: Hide the Swarming bot console window on startup (was: Make the Swarming bot console window to hide on startup)

Comment 5 by grt@chromium.org, Nov 16 2017

Blocking: -764415
This is no longer blocking, as the test itself now takes care of it. It may still be a nice-to-have, but I'll leave it to you infra folks to prioritize it as you see fit.

Comment 6 by mar...@chromium.org, Nov 21 2017

Owner: mar...@chromium.org
Status: Assigned (was: Available)
Will take it on.

Comment 7 by mar...@chromium.org, Nov 21 2017

Blocking: 787562

Sign in to add a comment