New issue
Advanced search Search tips

Issue 784398 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

ScreenlockPrivateApiTests broken on Mash

Project Member Reported by jonr...@chromium.org, Nov 13 2017

Issue description

With the landing of: https://chromium-review.googlesource.com/c/chromium/src/+/764400

The following tests have begun failing on mash_browser_tests:
  ScreenlockPrivateApiTest.LockUnlock
  ScreenlockPrivateApiTest.AuthType

These can be ran locally with:
  browser_tests --mash --override-use-software-gl-for-tests

First failing run: https://build.chromium.org/p/chromium.fyi/builders/Mojo%20ChromiumOS/builds/24205

Example failure from the logs:
8768:8768:1110/184205.680288:FATAL:native_widget_aura.cc(152)] Check failed: params.parent || params.context.
#0 0x000003bd9ebc base::debug::StackTrace::StackTrace()
#1 0x000003bf3cdc logging::LogMessage::~LogMessage()
#2 0x000004aa9d5b views::NativeWidgetAura::InitNativeWidget()
#3 0x000004a9e1ce views::Widget::Init()
#4 0x00000664ce02 ash::LockWindow::LockWindow()
#5 0x000006712f51 ash::LockScreen::Show()
#6 0x0000067116b4 ash::LockScreenController::ShowLockScreen()
#7 0x000002dba026 ash::mojom::LockScreenStubDispatch::AcceptWithResponder()
#8 0x0000067126d6 ash::mojom::LockScreenStub<>::AcceptWithResponder()
#9 0x000004eae7fc mojo::InterfaceEndpointClient::HandleValidatedMessage()
#10 0x000004ec5856 mojo::FilterChain::Accept()
#11 0x000004eafb95 mojo::InterfaceEndpointClient::HandleIncomingMessage()
#12 0x000004eb8902 mojo::internal::MultiplexRouter::ProcessIncomingMessage()
#13 0x000004eb7e34 mojo::internal::MultiplexRouter::Accept()
#14 0x000004ec5856 mojo::FilterChain::Accept()
#15 0x000004ead8f5 mojo::Connector::ReadSingleMessage()
#16 0x000004eae201 mojo::Connector::ReadAllAvailableMessages()
#17 0x000004eae0a9 mojo::Connector::OnHandleReadyInternal()
#18 0x0000024369c7 _ZN4base8internal22CancelableCallbackImplINS_17RepeatingCallbackIFviEEEE16ForwardRepeatingIJiEEEvDpT_
#19 0x000004ecb942 mojo::SimpleWatcher::OnHandleReady()
#20 0x000004ecbe61 _ZN4base8internal7InvokerINS0_9BindStateIMN4mojo13SimpleWatcherEFvijRKNS3_18HandleSignalsStateEEJNS_7WeakPtrIS4_EEijS5_EEEFvvEE7RunImplIRKS9_RKNSt3__15tupleIJSB_ijS5_EEEJLm0ELm1ELm2ELm3EEEEvOT_OT0_NSI_16integer_sequenceImJXspT1_EEEE
#21 0x000003bda675 base::debug::TaskAnnotator::RunTask()
#22 0x000003c90eb9 base::internal::IncomingTaskQueue::RunTask()
#23 0x000003bfb948 base::MessageLoop::RunTask()
#24 0x000003bfbcaa base::MessageLoop::DeferOrRunPendingTask()
#25 0x000003bfbf36 base::MessageLoop::DoWork()
#26 0x000003bfdfc9 base::MessagePumpLibevent::Run()
#27 0x000003bfb299 base::MessageLoop::Run()
#28 0x000003c24db8 base::RunLoop::Run()
#29 0x000003b9aec3 content::UtilityMain()
#30 0x000003bbba51 content::ContentMainRunnerImpl::Run()
#31 0x000005b5e04b service_manager::Main()
#32 0x000003bba434 content::ContentMain()
#33 0x000004245b25 content::LaunchTests()
#34 0x000003bcd375 LaunchChromeTests()
#35 0x000003bccdc6 RunMashBrowserTests()
#36 0x000003bccc77 main
#37 0x7f8df3289f45 __libc_start_main
#38 0x0000005ac24a _start

jdufault@ could you please take a look?

jamescook@ with the test currently only on the FYI I haven't reverted the change, nor disabled the test. Since this is a consistent known failure and not a random flake.
 
Under mash does this code run in the browser process or ash process?

If it's the ash process then I don't think it needs to do the Widget::InitParams::mus_properties dance to set the container id -- ash has knowledge of all the containers. I'm suspicious that leads to the DCHECK, since there won't be a window parent.

This should be running in the ash process under mash.
Thanks for not reverting, I'll take a look at fixing the tests shortly.
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1221503a8a41115a28119063e50e27ab8165d3a

commit d1221503a8a41115a28119063e50e27ab8165d3a
Author: Jacob Dufault <jdufault@google.com>
Date: Wed Nov 15 22:24:46 2017

cros: Fix ScreenlockPrivateApiTest in mash.

Bug:  784398 
Change-Id: Ic5cab7dab088645161ca7fa251faf7328b6aec5f
Reviewed-on: https://chromium-review.googlesource.com/766987
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516860}
[modify] https://crrev.com/d1221503a8a41115a28119063e50e27ab8165d3a/ash/login/ui/lock_window.cc
[modify] https://crrev.com/d1221503a8a41115a28119063e50e27ab8165d3a/testing/buildbot/filters/mojo.fyi.mash.browser_tests.filter

Status: Fixed (was: Assigned)

Sign in to add a comment