Cleanup FontPlatformData / SimpleFontData duality |
||
Issue descriptionWe have two types of font handles, FontPlatformData objects, as well as SimpleFontData objects. They have overlapping semantics, point to/own each other in a weird circular dependency and are another legacy WebKit abstraction that we do not need any more. Parallel to those two types we have a FontCache and a FontDataCache storing FontPlatformData's and SimpleFontData's respectively. This should be cleaned up.
,
Nov 27 2017
,
Nov 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/93b6749b38fe255b067b0cd1e1141c54ad9c4ffa commit 93b6749b38fe255b067b0cd1e1141c54ad9c4ffa Author: Dominik Röttsches <drott@chromium.org> Date: Mon Nov 27 21:08:24 2017 Remove used_vertically_ flag from SimpleFontData FontPlatformData already keeps information on whether the font is used in a vertical context or not. No functional change, ShapeResultBloberizerTest updated. Bug: 784386 Change-Id: Ib6d60fdb7f5a786844fcb06a5c233bc3a60ab5ec Reviewed-on: https://chromium-review.googlesource.com/789034 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#519397} [modify] https://crrev.com/93b6749b38fe255b067b0cd1e1141c54ad9c4ffa/third_party/WebKit/Source/platform/fonts/SimpleFontData.cpp [modify] https://crrev.com/93b6749b38fe255b067b0cd1e1141c54ad9c4ffa/third_party/WebKit/Source/platform/fonts/SimpleFontData.h [modify] https://crrev.com/93b6749b38fe255b067b0cd1e1141c54ad9c4ffa/third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBloberizerTest.cpp |
||
►
Sign in to add a comment |
||
Comment 1 by drott@chromium.org
, Nov 13 2017