New issue
Advanced search Search tips

Issue 784379 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in safe_browsing::dmg::ConvertBigEndian

Project Member Reported by ClusterFuzz, Nov 13 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5397431595565056

Fuzzer: libFuzzer_safe_browsing_hfs_fuzzer
Job Type: mac_libfuzzer_chrome_asan
Platform Id: mac

Crash Type: Null-dereference READ
Crash Address: 0x000000000000
Crash State:
  safe_browsing::dmg::ConvertBigEndian
  safe_browsing::dmg::ConvertBigEndian
  safe_browsing::dmg::HFSBTreeIterator::ReadCurrentLeaf
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=mac_libfuzzer_chrome_asan&range=509376:509426

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5397431595565056

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Nov 13 2017

Labels: Test-Predator-Auto-Owner
Owner: rsesek@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/902112f50d2142fe611aac017954cfd5024023e6 (Add a new safe_browsing DMG fuzzer for the HFS+ layer.).

If this is incorrect, please remove the owner and apply the Test-Predator-Wrong-CLs label.

Comment 2 by rsesek@chromium.org, Nov 14 2017

Components: Services>Safebrowsing
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c1e2cdf14541bb871ffd78bdac35bc703fe70c5

commit 2c1e2cdf14541bb871ffd78bdac35bc703fe70c5
Author: Robert Sesek <rsesek@chromium.org>
Date: Tue Nov 14 19:23:49 2017

Fix null-deref under safe_browsing::dmg::ConvertBigEndian().

Bug:  784379 
Change-Id: I32e8145ecefbf275ae04a7c9c07c117d517ce4a2
Reviewed-on: https://chromium-review.googlesource.com/768853
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516383}
[modify] https://crrev.com/2c1e2cdf14541bb871ffd78bdac35bc703fe70c5/chrome/utility/safe_browsing/mac/hfs.cc

Project Member

Comment 4 by ClusterFuzz, Nov 15 2017

ClusterFuzz has detected this issue as fixed in range 516325:516519.

Detailed report: https://clusterfuzz.com/testcase?key=5397431595565056

Fuzzer: libFuzzer_safe_browsing_hfs_fuzzer
Job Type: mac_libfuzzer_chrome_asan
Platform Id: mac

Crash Type: Null-dereference READ
Crash Address: 0x000000000000
Crash State:
  safe_browsing::dmg::ConvertBigEndian
  safe_browsing::dmg::ConvertBigEndian
  safe_browsing::dmg::HFSBTreeIterator::ReadCurrentLeaf
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=mac_libfuzzer_chrome_asan&range=509376:509426
Fixed: https://clusterfuzz.com/revisions?job=mac_libfuzzer_chrome_asan&range=516325:516519

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5397431595565056

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 5 by ClusterFuzz, Nov 15 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5397431595565056 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment