New issue
Advanced search Search tips

Issue 784377 link

Starred by 1 user
Status: Fixed
Owner:
khushals...@chromium.org
Closed: Nov 2017
Cc:
enne@chromium.org
tdresser@google.com
khushals...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

3.8%-35.9% regression in rasterize_and_record_micro.top_25 at 515849:515858

Project Member Reported by tdres...@chromium.org, Nov 13 2017 
See the link to graphs below.
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Nov 13 2017 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=784377

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=607b153fbbfb24dce972a75257d30bd8874972a0b7aa8acdcfcbb69142904ba6


Bot(s) for this bug's original alert(s):

chromium-rel-mac-retina
chromium-rel-mac11
chromium-rel-mac11-air
chromium-rel-mac11-pro
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Nov 14 2017 

📍 Couldn't reproduce a difference.
https://pinpoint-dot-chromeperf.appspot.com/job/1590c6b1f80000
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Nov 15 2017

Cc: khushals...@chromium.org enne@chromium.org
Owner: khushals...@chromium.org
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/110d00d1f80000

cc: Move alpha override to ScopedImageFlags.
By khushalsagar@chromium.org · Sat Nov 11 22:33:54 2017
chromium @ aa65368bea63683028ef4820306d36c4cdf6061d

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Project Member

Comment 7 by 42576172...@developer.gserviceaccount.com, Nov 16 2017 

📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/14c2b879f80000

cc: Move alpha override to ScopedImageFlags.
By khushalsagar@chromium.org · Sat Nov 11 22:33:54 2017
chromium @ aa65368bea63683028ef4820306d36c4cdf6061d

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/415bc2258ceb3c4b470b267571bf67704d078c5f

commit 415bc2258ceb3c4b470b267571bf67704d078c5f
Author: Khushal <khushalsagar@chromium.org>
Date: Thu Nov 16 20:56:44 2017

cc: Don't use ScopedImageFlags with no overrides.

Using this object for every op impacts rasterization performance.
Restrict it only to cases which need an override.

Also use StackVector in DecodeStashingImageProvider for the common case
of image shaders which have a single image.

R=enne@chromium.org

Bug:  784377 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I7ee99abf890e65f3e347185fa0d53f92acf8f2fe
Reviewed-on: https://chromium-review.googlesource.com/773779
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517181}
[modify] https://crrev.com/415bc2258ceb3c4b470b267571bf67704d078c5f/cc/paint/paint_op_buffer.cc
[modify] https://crrev.com/415bc2258ceb3c4b470b267571bf67704d078c5f/cc/paint/scoped_image_flags.cc
[modify] https://crrev.com/415bc2258ceb3c4b470b267571bf67704d078c5f/cc/paint/scoped_image_flags.h
[modify] https://crrev.com/415bc2258ceb3c4b470b267571bf67704d078c5f/cc/paint/scoped_image_flags_unittest.cc
Project Member

Comment 10 by 42576172...@developer.gserviceaccount.com, Nov 17 2017 

📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/121dc6b9f80000

cc: Don't use ScopedImageFlags with no overrides.
By khushalsagar@chromium.org · Thu Nov 16 20:56:44 2017
chromium @ 415bc2258ceb3c4b470b267571bf67704d078c5f

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Comment 11 by khushals...@chromium.org, Nov 17 2017

Status: Fixed (was: Assigned)
Great. Looks like the patch above fixed the regression.
►

Sign in to add a comment