New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 784369 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR

Blocked on:
issue 783788

Blocking:
issue 787912



Sign in to add a comment

Move toward primitive elements

Project Member Reported by vollick@chromium.org, Nov 13 2017

Issue description

Where possible, have functionality specific to a UiElement housed in that UiElement.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/826f56b0b5ce06470fd16b9dec5f14ff9fcc5d7a

commit 826f56b0b5ce06470fd16b9dec5f14ff9fcc5d7a
Author: Ian Vollick <vollick@chromium.org>
Date: Mon Nov 13 19:53:57 2017

[vr] Move renderers into separate files

Previously, we'd housed all our renderers in VrShellRenderer, but this
file has grown. In this change, the generic renderers (quad renderers,
mostly) have been moved to their own files. Element-specific renderers
have been moved into the files corresponding to said elements.

Since the WebVR content is not yet represented as an element and is
drawn explicitly by VrShellGl, it has a first-class renderer in the
renderers/ directory, but this should be a temporary state of affairs.

Bug:  784369 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I6c27328b020e741fd275726b6e9cb51baddc0ff3
Reviewed-on: https://chromium-review.googlesource.com/766267
Commit-Queue: Ian Vollick <vollick@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516014}
[modify] https://crrev.com/826f56b0b5ce06470fd16b9dec5f14ff9fcc5d7a/chrome/browser/android/vr_shell/vr_shell_gl.cc
[modify] https://crrev.com/826f56b0b5ce06470fd16b9dec5f14ff9fcc5d7a/chrome/browser/vr/BUILD.gn
[modify] https://crrev.com/826f56b0b5ce06470fd16b9dec5f14ff9fcc5d7a/chrome/browser/vr/elements/controller.cc
[modify] https://crrev.com/826f56b0b5ce06470fd16b9dec5f14ff9fcc5d7a/chrome/browser/vr/elements/controller.h
[modify] https://crrev.com/826f56b0b5ce06470fd16b9dec5f14ff9fcc5d7a/chrome/browser/vr/elements/grid.cc
[modify] https://crrev.com/826f56b0b5ce06470fd16b9dec5f14ff9fcc5d7a/chrome/browser/vr/elements/grid.h
[modify] https://crrev.com/826f56b0b5ce06470fd16b9dec5f14ff9fcc5d7a/chrome/browser/vr/elements/laser.cc
[modify] https://crrev.com/826f56b0b5ce06470fd16b9dec5f14ff9fcc5d7a/chrome/browser/vr/elements/laser.h
[modify] https://crrev.com/826f56b0b5ce06470fd16b9dec5f14ff9fcc5d7a/chrome/browser/vr/elements/reticle.cc
[modify] https://crrev.com/826f56b0b5ce06470fd16b9dec5f14ff9fcc5d7a/chrome/browser/vr/elements/reticle.h
[add] https://crrev.com/826f56b0b5ce06470fd16b9dec5f14ff9fcc5d7a/chrome/browser/vr/renderers/base_quad_renderer.cc
[add] https://crrev.com/826f56b0b5ce06470fd16b9dec5f14ff9fcc5d7a/chrome/browser/vr/renderers/base_quad_renderer.h
[add] https://crrev.com/826f56b0b5ce06470fd16b9dec5f14ff9fcc5d7a/chrome/browser/vr/renderers/base_renderer.cc
[add] https://crrev.com/826f56b0b5ce06470fd16b9dec5f14ff9fcc5d7a/chrome/browser/vr/renderers/base_renderer.h
[add] https://crrev.com/826f56b0b5ce06470fd16b9dec5f14ff9fcc5d7a/chrome/browser/vr/renderers/external_textured_quad_renderer.cc
[add] https://crrev.com/826f56b0b5ce06470fd16b9dec5f14ff9fcc5d7a/chrome/browser/vr/renderers/external_textured_quad_renderer.h
[add] https://crrev.com/826f56b0b5ce06470fd16b9dec5f14ff9fcc5d7a/chrome/browser/vr/renderers/gradient_quad_renderer.cc
[add] https://crrev.com/826f56b0b5ce06470fd16b9dec5f14ff9fcc5d7a/chrome/browser/vr/renderers/gradient_quad_renderer.h
[add] https://crrev.com/826f56b0b5ce06470fd16b9dec5f14ff9fcc5d7a/chrome/browser/vr/renderers/textured_quad_renderer.cc
[add] https://crrev.com/826f56b0b5ce06470fd16b9dec5f14ff9fcc5d7a/chrome/browser/vr/renderers/textured_quad_renderer.h
[add] https://crrev.com/826f56b0b5ce06470fd16b9dec5f14ff9fcc5d7a/chrome/browser/vr/renderers/web_vr_renderer.cc
[add] https://crrev.com/826f56b0b5ce06470fd16b9dec5f14ff9fcc5d7a/chrome/browser/vr/renderers/web_vr_renderer.h
[modify] https://crrev.com/826f56b0b5ce06470fd16b9dec5f14ff9fcc5d7a/chrome/browser/vr/test/fake_ui_element_renderer.cc
[modify] https://crrev.com/826f56b0b5ce06470fd16b9dec5f14ff9fcc5d7a/chrome/browser/vr/testapp/vr_test_context.cc
[modify] https://crrev.com/826f56b0b5ce06470fd16b9dec5f14ff9fcc5d7a/chrome/browser/vr/ui.cc
[modify] https://crrev.com/826f56b0b5ce06470fd16b9dec5f14ff9fcc5d7a/chrome/browser/vr/ui.h
[add] https://crrev.com/826f56b0b5ce06470fd16b9dec5f14ff9fcc5d7a/chrome/browser/vr/ui_element_renderer.cc
[modify] https://crrev.com/826f56b0b5ce06470fd16b9dec5f14ff9fcc5d7a/chrome/browser/vr/ui_element_renderer.h
[modify] https://crrev.com/826f56b0b5ce06470fd16b9dec5f14ff9fcc5d7a/chrome/browser/vr/ui_renderer.cc
[modify] https://crrev.com/826f56b0b5ce06470fd16b9dec5f14ff9fcc5d7a/chrome/browser/vr/ui_renderer.h
[modify] https://crrev.com/826f56b0b5ce06470fd16b9dec5f14ff9fcc5d7a/chrome/browser/vr/vr_gl_util.cc
[modify] https://crrev.com/826f56b0b5ce06470fd16b9dec5f14ff9fcc5d7a/chrome/browser/vr/vr_gl_util.h
[delete] https://crrev.com/d558791a8b5ee5733fed74e81133b8eb3f6f5308/chrome/browser/vr/vr_shell_renderer.cc
[delete] https://crrev.com/d558791a8b5ee5733fed74e81133b8eb3f6f5308/chrome/browser/vr/vr_shell_renderer.h

Summary: Move toward primitive elements (was: Encapsulate element-specific logic)
Labels: -Pri-2 Pri-3
Blocking: 787912
Blockedon: 783788
Status: Fixed (was: Assigned)
Marking this fixed since much of the work has been finished. We can create separate bugs (such as the blocking issue) for particular bits of UI that should be broken apart.
Labels: M-64 Test-Complete

Sign in to add a comment